You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2020/12/30 23:55:44 UTC
[GitHub] [incubator-nuttx] btashton opened a new pull request #2629: vfs: Fix unsed label warning
btashton opened a new pull request #2629:
URL: https://github.com/apache/incubator-nuttx/pull/2629
## Summary
PR #2618 snuck in while the CI was broken and broke master with the warning
```
vfs/fs_unlink.c:194:1: error: label 'errout_with_sem' defined but not used [-Werror=unused-label]
```
This change covers this and another possible unused label in the same function.
## Impact
This label is now conditionally defined.
## Testing
CI and local builds
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] btashton commented on a change in pull request #2629: vfs: Fix unsed label warning
Posted by GitBox <gi...@apache.org>.
btashton commented on a change in pull request #2629:
URL: https://github.com/apache/incubator-nuttx/pull/2629#discussion_r550361613
##########
File path: fs/vfs/fs_unlink.c
##########
@@ -191,11 +191,14 @@ int nx_unlink(FAR const char *pathname)
RELEASE_SEARCH(&desc);
return OK;
+#ifndef CONFIG_DISABLE_PSEUDOFS_OPERATIONS
errout_with_sem:
inode_semgive();
-
+#endif
+#if !defined(CONFIG_DISABLE_MOUNTPOINT) || !defined(CONFIG_DISABLE_MOUNTPOINT)
Review comment:
Thanks. Fixed it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] btashton commented on pull request #2629: vfs: Fix unsed label warning
Posted by GitBox <gi...@apache.org>.
btashton commented on pull request #2629:
URL: https://github.com/apache/incubator-nuttx/pull/2629#issuecomment-752832695
> @btashton thanks for the patch. It's strange that CI doesn't complain and stop when hitting the warnning.
It's because of the CI breakage they all came back green while it was broken :(.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 merged pull request #2629: vfs: Fix unsed label warning
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 merged pull request #2629:
URL: https://github.com/apache/incubator-nuttx/pull/2629
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] btashton commented on pull request #2629: vfs: Fix unsed label warning
Posted by GitBox <gi...@apache.org>.
btashton commented on pull request #2629:
URL: https://github.com/apache/incubator-nuttx/pull/2629#issuecomment-752794414
@Ouss4 Maybe you are around to review this to un-break master.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] Ouss4 commented on a change in pull request #2629: vfs: Fix unsed label warning
Posted by GitBox <gi...@apache.org>.
Ouss4 commented on a change in pull request #2629:
URL: https://github.com/apache/incubator-nuttx/pull/2629#discussion_r550360535
##########
File path: fs/vfs/fs_unlink.c
##########
@@ -191,11 +191,14 @@ int nx_unlink(FAR const char *pathname)
RELEASE_SEARCH(&desc);
return OK;
+#ifndef CONFIG_DISABLE_PSEUDOFS_OPERATIONS
errout_with_sem:
inode_semgive();
-
+#endif
+#if !defined(CONFIG_DISABLE_MOUNTPOINT) || !defined(CONFIG_DISABLE_MOUNTPOINT)
Review comment:
```suggestion
#if !defined(CONFIG_DISABLE_MOUNTPOINT) || !defined(CONFIG_DISABLE_PSEUDOFS_OPERATIONS)
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #2629: vfs: Fix unsed label warning
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on pull request #2629:
URL: https://github.com/apache/incubator-nuttx/pull/2629#issuecomment-752833487
Ohh, I forgot you mention that the CI break due to the new more security setting. @btashton, thanks for making the CI work again!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #2629: vfs: Fix unsed label warning
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on pull request #2629:
URL: https://github.com/apache/incubator-nuttx/pull/2629#issuecomment-752828876
@btashton thanks for the patch. It's strange that CI doesn't complain and stop when hitting the warnning.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org