[GitHub] [nifi-minifi-cpp] fgerlits commented on pull request #947: MINIFICPP-1401 Read certificates from the Windows system store

[GitBox <gi...@apache.org>]

fgerlits commented on pull request #947:
URL: https://github.com/apache/nifi-minifi-cpp/pull/947#issuecomment-739859623


   @lordgamez:
   
   > Tested manually the possible configuration options on Windows 10. They all worked well, I only have 2 comments:
   > 
   >     1. While loading the server certificates, there is the possibility that a certificate might be loaded multiple times which results in an error `cert already in hash table`. As this is done for every heartbeat, this might flood the logs:
   
   I have moved this log to debug level in https://github.com/apache/nifi-minifi-cpp/pull/947/commits/a4ee1fcdd27be870470af9d0a754214197dd8fcc; please retest.
   
   >     2. I encountered an error, that my private key was not exportable and the certificate could not be used because of this. As this is a requirement this should be noted in the documentation as well.
   
   We have discussed this with the user; they agreed to use exportable client certificates.  I have added a comment about this to the Jira, and we will include it in the documentation.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org