You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2018/08/14 17:41:57 UTC
[GitHub] GJL commented on a change in pull request #6522:
[FLINK-10101][mesos] Add web ui url for mesos.
GJL commented on a change in pull request #6522: [FLINK-10101][mesos] Add web ui url for mesos.
URL: https://github.com/apache/flink/pull/6522#discussion_r210036352
##########
File path: flink-mesos/src/main/java/org/apache/flink/mesos/runtime/clusterframework/MesosResourceManager.java
##########
@@ -185,6 +190,8 @@ public MesosResourceManager(
this.workersInNew = new HashMap<>(8);
this.workersInLaunch = new HashMap<>(8);
this.workersBeingReturned = new HashMap<>(8);
+
+ this.webUiUrl = webUiUrl;
Review comment:
I would move this line below this assignment:
```
this.taskManagerContainerSpec = Preconditions.checkNotNull(taskManagerContainerSpec);
```
so that the assignments of all constructor arguments are grouped.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services