You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hop.apache.org by GitBox <gi...@apache.org> on 2020/11/24 21:25:06 UTC
[GitHub] [incubator-hop] nadment opened a new pull request #414: HOP-METADATA Perspective (not to merge, only for tests and feedback)
nadment opened a new pull request #414:
URL: https://github.com/apache/incubator-hop/pull/414
New perspective to see and edit all available metadata.
Editing in dual mode (dialog / editor) using the new IMetadataEditor interface.
MetadataManager has new methods for dual mode:
- newWithDialog / newWithEditor
- editWithDialog / editWithEditor
The metadata tree supports inline renaming.
Bug to detect changes when using GuiCompositeWidgets
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-hop] hansva commented on pull request #414: HOP-METADATA Perspective (not to merge, only for tests and feedback)
Posted by GitBox <gi...@apache.org>.
hansva commented on pull request #414:
URL: https://github.com/apache/incubator-hop/pull/414#issuecomment-733251641
Found 1 issue, when opening the perspective and switching projects an NPE is thrown
```
org.apache.hop.core.exception.HopException:
Error enabling project 'test' in HopGui
at org.apache.hop.ui.hopgui.HopGui.main (HopGui.java:294)
at org.apache.hop.ui.hopgui.HopGui.open (HopGui.java:352)
at org.eclipse.swt.widgets.Display.readAndDispatch (Display.java:4448)
at org.eclipse.swt.widgets.Display.runDeferredEvents (Display.java:4955)
at org.eclipse.swt.widgets.Widget.sendEvent (Widget.java:1423)
at org.eclipse.swt.widgets.Display.sendEvent (Display.java:5687)
at org.eclipse.swt.widgets.EventTable.sendEvent (EventTable.java:89)
at org.apache.hop.ui.core.gui.BaseGuiWidgets.lambda$getListener$1 (BaseGuiWidgets.java:145)
at java.lang.reflect.Method.invoke (Method.java:498)
at sun.reflect.DelegatingMethodAccessorImpl.invoke (DelegatingMethodAccessorImpl.java:43)
at sun.reflect.NativeMethodAccessorImpl.invoke (NativeMethodAccessorImpl.java:62)
at sun.reflect.NativeMethodAccessorImpl.invoke0 (NativeMethodAccessorImpl.java:-2)
at org.apache.hop.projects.gui.ProjectsGuiPlugin.selectProject (ProjectsGuiPlugin.java:171)
at org.apache.hop.projects.gui.ProjectsGuiPlugin.enableHopGuiProject (ProjectsGuiPlugin.java:558)
at org.apache.hop.projects.gui.ProjectsGuiPlugin.enableHopGuiProject(ProjectsGuiPlugin.java:591)
at org.apache.hop.projects.gui.ProjectsGuiPlugin.selectProject(ProjectsGuiPlugin.java:171)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:498)
at org.apache.hop.ui.core.gui.BaseGuiWidgets.lambda$getListener$1(BaseGuiWidgets.java:145)
at org.eclipse.swt.widgets.EventTable.sendEvent(EventTable.java:89)
at org.eclipse.swt.widgets.Display.sendEvent(Display.java:5687)
at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1423)
at org.eclipse.swt.widgets.Display.runDeferredEvents(Display.java:4955)
at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java:4448)
at org.apache.hop.ui.hopgui.HopGui.open(HopGui.java:352)
at org.apache.hop.ui.hopgui.HopGui.main(HopGui.java:294)
Caused by: java.lang.NullPointerException
at org.apache.hop.projects.gui.ProjectsGuiPlugin.enableHopGuiProject(ProjectsGuiPlugin.java:558)
... 13 more
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-hop] nadment closed pull request #414: HOP-METADATA Perspective (not to merge, only for tests and feedback)
Posted by GitBox <gi...@apache.org>.
nadment closed pull request #414:
URL: https://github.com/apache/incubator-hop/pull/414
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-hop] nadment commented on pull request #414: HOP-METADATA Perspective (not to merge, only for tests and feedback)
Posted by GitBox <gi...@apache.org>.
nadment commented on pull request #414:
URL: https://github.com/apache/incubator-hop/pull/414#issuecomment-733730832
>
>
> Doesn't work with metadata plugins. Uses the wrong classloader somewhere.
>
> org.apache.hop.core.exception.HopException:
> Unable to find editor class (org.neo4j.hop.ui.shared.NeoConnectionEditor)
>
> ```
> at org.apache.hop.ui.core.metadata.MetadataManager.createEditor(MetadataManager.java:404)
> at org.apache.hop.ui.core.metadata.MetadataManager.editWithDialog(MetadataManager.java:162)
> at org.apache.hop.ui.core.widget.MetaSelectionLine.editMetadata(MetaSelectionLine.java:206)
> at org.apache.hop.ui.core.widget.MetaSelectionLine.lambda$new$2(MetaSelectionLine.java:185)
> at org.eclipse.swt.widgets.EventTable.sendEvent(EventTable.java:89)
> at org.eclipse.swt.widgets.Display.sendEvent(Display.java:5687)
> at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1423)
> at org.eclipse.swt.widgets.Display.runDeferredEvents(Display.java:4955)
> at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java:4448)
> at org.neo4j.hop.transforms.graph.GraphOutputDialog.open(GraphOutputDialog.java:337)
> at org.apache.hop.ui.hopgui.file.pipeline.delegates.HopGuiPipelineTransformDelegate.editTransform(HopGuiPipelineTransformDelegate.java:140)
> at org.apache.hop.ui.hopgui.file.pipeline.HopGuiPipelineGraph.editTransform(HopGuiPipelineGraph.java:2870)
> at org.apache.hop.ui.hopgui.file.pipeline.HopGuiPipelineGraph.mouseDoubleClick(HopGuiPipelineGraph.java:584)
> at org.eclipse.swt.widgets.TypedListener.handleEvent(TypedListener.java:200)
> at org.eclipse.swt.widgets.EventTable.sendEvent(EventTable.java:89)
> at org.eclipse.swt.widgets.Display.sendEvent(Display.java:5687)
> at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1423)
> at org.eclipse.swt.widgets.Display.runDeferredEvents(Display.java:4955)
> at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java:4448)
> at org.apache.hop.ui.hopgui.HopGui.open(HopGui.java:352)
> at org.apache.hop.ui.hopgui.HopGui.main(HopGui.java:294)
> ```
Metadata editor work with Beam, Testing and Git plugins, it use same logic to find editor class than dialog:
1) Try with className + Editor in same package
className = managedClass.getName();
className += "Editor";
2) Else try in hop.ui package
className = managedClass.getName();
className = className.replaceFirst("\\.hop\\.", ".hop.ui.");
className += "Editor";
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-hop] mattcasters commented on pull request #414: HOP-METADATA Perspective (not to merge, only for tests and feedback)
Posted by GitBox <gi...@apache.org>.
mattcasters commented on pull request #414:
URL: https://github.com/apache/incubator-hop/pull/414#issuecomment-733763157
Yeah when I wrote that comment I didn't realize you created a completely separate set of Editor classes. Forget the classpath thing. In my separate plugins I obviously didn't have those new classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-hop] mattcasters commented on pull request #414: HOP-METADATA Perspective (not to merge, only for tests and feedback)
Posted by GitBox <gi...@apache.org>.
mattcasters commented on pull request #414:
URL: https://github.com/apache/incubator-hop/pull/414#issuecomment-733558118
Are we creating massive code duplication between the Dialog and Editor classes? Why not have the Dialog classes generate the Composite, Buttons, ... since the code is already there?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-hop] hansva commented on pull request #414: HOP-METADATA Perspective (not to merge, only for tests and feedback)
Posted by GitBox <gi...@apache.org>.
hansva commented on pull request #414:
URL: https://github.com/apache/incubator-hop/pull/414#issuecomment-733248078
One small comment... change the headers to following text
```
/*
* Licensed to the Apache Software Foundation (ASF) under one or more
* contributor license agreements. See the NOTICE file distributed with
* this work for additional information regarding copyright ownership.
* The ASF licenses this file to You under the Apache License, Version 2.0
* (the "License"); you may not use this file except in compliance with
* the License. You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-hop] mattcasters commented on pull request #414: HOP-METADATA Perspective (not to merge, only for tests and feedback)
Posted by GitBox <gi...@apache.org>.
mattcasters commented on pull request #414:
URL: https://github.com/apache/incubator-hop/pull/414#issuecomment-733553119
Doesn't work with metadata plugins. Uses the wrong classloader somewhere.
org.apache.hop.core.exception.HopException:
Unable to find editor class (org.neo4j.hop.ui.shared.NeoConnectionEditor)
at org.apache.hop.ui.core.metadata.MetadataManager.createEditor(MetadataManager.java:404)
at org.apache.hop.ui.core.metadata.MetadataManager.editWithDialog(MetadataManager.java:162)
at org.apache.hop.ui.core.widget.MetaSelectionLine.editMetadata(MetaSelectionLine.java:206)
at org.apache.hop.ui.core.widget.MetaSelectionLine.lambda$new$2(MetaSelectionLine.java:185)
at org.eclipse.swt.widgets.EventTable.sendEvent(EventTable.java:89)
at org.eclipse.swt.widgets.Display.sendEvent(Display.java:5687)
at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1423)
at org.eclipse.swt.widgets.Display.runDeferredEvents(Display.java:4955)
at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java:4448)
at org.neo4j.hop.transforms.graph.GraphOutputDialog.open(GraphOutputDialog.java:337)
at org.apache.hop.ui.hopgui.file.pipeline.delegates.HopGuiPipelineTransformDelegate.editTransform(HopGuiPipelineTransformDelegate.java:140)
at org.apache.hop.ui.hopgui.file.pipeline.HopGuiPipelineGraph.editTransform(HopGuiPipelineGraph.java:2870)
at org.apache.hop.ui.hopgui.file.pipeline.HopGuiPipelineGraph.mouseDoubleClick(HopGuiPipelineGraph.java:584)
at org.eclipse.swt.widgets.TypedListener.handleEvent(TypedListener.java:200)
at org.eclipse.swt.widgets.EventTable.sendEvent(EventTable.java:89)
at org.eclipse.swt.widgets.Display.sendEvent(Display.java:5687)
at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1423)
at org.eclipse.swt.widgets.Display.runDeferredEvents(Display.java:4955)
at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java:4448)
at org.apache.hop.ui.hopgui.HopGui.open(HopGui.java:352)
at org.apache.hop.ui.hopgui.HopGui.main(HopGui.java:294)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org