You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2019/05/28 16:39:00 UTC

[jira] [Commented] (AIRFLOW-4486) Enhance MySQL hook to allow for IAM authentication

    [ https://issues.apache.org/jira/browse/AIRFLOW-4486?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16849912#comment-16849912 ] 

ASF GitHub Bot commented on AIRFLOW-4486:
-----------------------------------------

andrewhharmon commented on pull request #5334: [AIRFLOW-4486] Support IAM Auth in MySqlHook
URL: https://github.com/apache/airflow/pull/5334
 
 
   update MySQL hook and add new test
   
   ### Jira
   
   - [x] My PR addresses the following [Airflow Jira](https://issues.apache.org/jira/projects/AIRFLOW/issues/AIRFLOW-4486) issue.
   
   ### Description
   
   - [x] Enhanced the MySQL Hook to allow for IAM authentication in AWS. 
   
   ### Tests
   
   - [x] Added test test_mysql_hook.test_get_conn_rds_iam()
   
   ### Commits
   
   - [x] My commits all reference Jira issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
     1. Subject is separated from body by a blank line
     1. Subject is limited to 50 characters (not including Jira issue reference)
     1. Subject does not end with a period
     1. Subject uses the imperative mood ("add", not "adding")
     1. Body wraps at 72 characters
     1. Body explains "what" and "why", not "how"
   
   ### Documentation
   
   - [x] In case of new functionality, my PR adds documentation that describes how to use it.
     - All the public functions and the classes in the PR contain docstrings that explain what it does
   
   ### Code Quality
   
   - [x] Passes `flake8`
   
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Enhance MySQL hook to allow for IAM authentication
> --------------------------------------------------
>
>                 Key: AIRFLOW-4486
>                 URL: https://issues.apache.org/jira/browse/AIRFLOW-4486
>             Project: Apache Airflow
>          Issue Type: Improvement
>            Reporter: Andrew Harmon
>            Assignee: Andrew Harmon
>            Priority: Minor
>              Labels: features
>
> Enhance to current MySqlHook to allow for connecting to AWS RDS AWS IAM authentication.
> The hook will use an AWSHook to generate a temporary token via boto3. This token will be passed in as the password.
> To specify IAM authentication, the following extras can be added to the MySql connection
> { "iam":true, "region":"us-west-1", "aws_conn_id":"my_aws_conn" }



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)