[jira] [Commented] (AVRO-4350) [javascript] npm avrojs@1.12.2 missing underscore

["ASF subversion and git services (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/AVRO-4350?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18108679#comment-18108679 ] 

ASF subversion and git services commented on AVRO-4350:
-------------------------------------------------------

Commit d02512a5d7cc75c552ec1a7fcd50ed01b960911c in avro's branch refs/heads/main from Stefano Vozza
[ https://gitbox.apache.org/repos/asf?p=avro.git;h=d02512a5d7 ]

AVRO-4350: [JavaScript] Restore underscore dependency (#3970)

* AVRO-4350: Restore underscore dependency

* AVRO-4350: Test package entry point

> [javascript] npm avrojs@1.12.2 missing underscore
> -------------------------------------------------
>
>                 Key: AVRO-4350
>                 URL: https://issues.apache.org/jira/browse/AVRO-4350
>             Project: Apache Avro
>          Issue Type: Bug
>          Components: javascript
>            Reporter: Ryan Skraba
>            Priority: Major
>              Labels: pull-request-available
>          Time Spent: 50m
>  Remaining Estimate: 0h
>
> (from https://lists.apache.org/thread/7xlfdryn99vln4ybsx1yhs257pk9hlcl)
> It looks like the underscore dependency was removed as part of a security patch but there is still a file in the project that tries to require it ([https://github.com/apache/avro/blob/2b5fe02502b77fc33c7b2f1a1f8184d46d7700d4/lang/js/etc/deprecated/validator.js#L16]). This causes an "Cannot find module 'underscore’ “ error whenever you try to do a clean install.
> You can do a repro with this one liner:
> mkdir test && cd test && npm init -y && npm i avro-js@1.12.2 && node -e "require('avro-js')”
> or 
> docker run -it node:10 bash -c "npm install avro-js@1.12.2 && node -e \"require('avro-js')\""



--
This message was sent by Atlassian Jira
(v8.20.10#820010)