You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/01/26 21:43:58 UTC
[GitHub] [arrow] nealrichardson opened a new pull request #9332: ARROW-7288: [C++] Replace boost::regex with re2 in Parquet
nealrichardson opened a new pull request #9332:
URL: https://github.com/apache/arrow/pull/9332
I started on this and think I got the cmake bits worked out, but since re2 doesn't look like a drop-in replacement for std::regex, I think there's more C++ refactoring required, which I don't feel competent enough to take on.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] nealrichardson commented on pull request #9332: ARROW-7288: [C++] Replace boost::regex with re2 in Parquet
Posted by GitBox <gi...@apache.org>.
nealrichardson commented on pull request #9332:
URL: https://github.com/apache/arrow/pull/9332#issuecomment-770291621
Closing in favor of #9367
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] nealrichardson commented on a change in pull request #9332: ARROW-7288: [C++] Replace boost::regex with re2 in Parquet
Posted by GitBox <gi...@apache.org>.
nealrichardson commented on a change in pull request #9332:
URL: https://github.com/apache/arrow/pull/9332#discussion_r564854300
##########
File path: cpp/src/parquet/thrift_internal.h
##########
@@ -20,13 +20,7 @@
#include "arrow/util/windows_compatibility.h"
#include <cstdint>
-// Check if thrift version < 0.11.0
Review comment:
We now require thrift >= 0.11, so this isn't relevant anymore.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] jonkeane commented on pull request #9332: ARROW-7288: [C++] Replace boost::regex with re2 in Parquet
Posted by GitBox <gi...@apache.org>.
jonkeane commented on pull request #9332:
URL: https://github.com/apache/arrow/pull/9332#issuecomment-767860030
LGTM
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #9332: ARROW-7288: [C++] Replace boost::regex with re2 in Parquet
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #9332:
URL: https://github.com/apache/arrow/pull/9332#issuecomment-767847295
https://issues.apache.org/jira/browse/ARROW-7288
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] jonkeane removed a comment on pull request #9332: ARROW-7288: [C++] Replace boost::regex with re2 in Parquet
Posted by GitBox <gi...@apache.org>.
jonkeane removed a comment on pull request #9332:
URL: https://github.com/apache/arrow/pull/9332#issuecomment-767860030
LGTM
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] pitrou closed pull request #9332: ARROW-7288: [C++] Replace boost::regex with re2 in Parquet
Posted by GitBox <gi...@apache.org>.
pitrou closed pull request #9332:
URL: https://github.com/apache/arrow/pull/9332
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] pitrou closed pull request #9332: ARROW-7288: [C++] Replace boost::regex with re2 in Parquet
Posted by GitBox <gi...@apache.org>.
pitrou closed pull request #9332:
URL: https://github.com/apache/arrow/pull/9332
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org