You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2020/12/17 01:26:52 UTC
[GitHub] [camel-k] tadayosi opened a new pull request #1866: chore(e2e): add test for Affinity trait #1547
tadayosi opened a new pull request #1866:
URL: https://github.com/apache/camel-k/pull/1866
<!-- Description -->
<!--
Enter your extended release note in the below block. If the PR requires
additional action from users switching to the new release, include the string
"action required". If no release note is required, write "NONE".
You can (optionally) mark this PR with labels "kind/bug" or "kind/feature" to make sure
the text is added to the right section of the release notes.
-->
**Release Note**
```release-note
NONE
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] tadayosi commented on a change in pull request #1866: chore(e2e): add test for Affinity trait #1547
Posted by GitBox <gi...@apache.org>.
tadayosi commented on a change in pull request #1866:
URL: https://github.com/apache/camel-k/pull/1866#discussion_r544919540
##########
File path: e2e/common/affinity_test.go
##########
@@ -0,0 +1,149 @@
+// +build integration
+
+// To enable compilation of this file in Goland, go to "Settings -> Go -> Vendoring & Build Tags -> Custom Tags" and add "integration"
+
+/*
+Licensed to the Apache Software Foundation (ASF) under one or more
+contributor license agreements. See the NOTICE file distributed with
+this work for additional information regarding copyright ownership.
+The ASF licenses this file to You under the Apache License, Version 2.0
+(the "License"); you may not use this file except in compliance with
+the License. You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+Unless required by applicable law or agreed to in writing, software
+distributed under the License is distributed on an "AS IS" BASIS,
+WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+See the License for the specific language governing permissions and
+limitations under the License.
+*/
+
+package common
+
+import (
+ "fmt"
+ "testing"
+
+ . "github.com/apache/camel-k/e2e/support"
+ camelv1 "github.com/apache/camel-k/pkg/apis/camel/v1"
+
+ . "github.com/onsi/gomega"
+
+ v1 "k8s.io/api/core/v1"
+ metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
+)
+
+func TestAffinityTrait(t *testing.T) {
+ WithNewTestNamespace(t, func(ns string) {
+ Expect(Kamel("install", "-n", ns).Execute()).Should(BeNil())
+
+ var hostname string
+ if node, err := selectSchedulableNode(); err == nil {
+ hostname = node.Labels["kubernetes.io/hostname"]
+ } else {
+ // if 'get nodes' is not allowed, just skip tests for node affinity
+ hostname = ""
+ }
+
+ if hostname != "" {
+ t.Run("Run Java with node affinity", func(t *testing.T) {
+ Expect(Kamel("run", "-n", ns, "files/Java.java",
+ "-t", "affinity.enabled=true",
+ "-t", fmt.Sprintf("affinity.node-affinity-labels=kubernetes.io/hostname in(%s)", hostname)).Execute()).Should(BeNil())
+ Eventually(IntegrationPodPhase(ns, "java"), TestTimeoutLong).Should(Equal(v1.PodRunning))
+ Eventually(IntegrationCondition(ns, "java", camelv1.IntegrationConditionReady), TestTimeoutShort).Should(Equal(v1.ConditionTrue))
+ Eventually(IntegrationLogs(ns, "java"), TestTimeoutShort).Should(ContainSubstring("Magicstring!"))
+
+ pod := IntegrationPod(ns, "java")()
+ Expect(pod.Spec.Affinity).ShouldNot(BeNil())
+ Expect(pod.Spec.Affinity.NodeAffinity).Should(Equal(&v1.NodeAffinity{
Review comment:
Is it just enough to check the pod's `spec.nodeName`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] astefanutti commented on a change in pull request #1866: chore(e2e): add test for Affinity trait #1547
Posted by GitBox <gi...@apache.org>.
astefanutti commented on a change in pull request #1866:
URL: https://github.com/apache/camel-k/pull/1866#discussion_r544921767
##########
File path: e2e/common/affinity_test.go
##########
@@ -0,0 +1,149 @@
+// +build integration
+
+// To enable compilation of this file in Goland, go to "Settings -> Go -> Vendoring & Build Tags -> Custom Tags" and add "integration"
+
+/*
+Licensed to the Apache Software Foundation (ASF) under one or more
+contributor license agreements. See the NOTICE file distributed with
+this work for additional information regarding copyright ownership.
+The ASF licenses this file to You under the Apache License, Version 2.0
+(the "License"); you may not use this file except in compliance with
+the License. You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+Unless required by applicable law or agreed to in writing, software
+distributed under the License is distributed on an "AS IS" BASIS,
+WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+See the License for the specific language governing permissions and
+limitations under the License.
+*/
+
+package common
+
+import (
+ "fmt"
+ "testing"
+
+ . "github.com/apache/camel-k/e2e/support"
+ camelv1 "github.com/apache/camel-k/pkg/apis/camel/v1"
+
+ . "github.com/onsi/gomega"
+
+ v1 "k8s.io/api/core/v1"
+ metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
+)
+
+func TestAffinityTrait(t *testing.T) {
+ WithNewTestNamespace(t, func(ns string) {
+ Expect(Kamel("install", "-n", ns).Execute()).Should(BeNil())
+
+ var hostname string
+ if node, err := selectSchedulableNode(); err == nil {
+ hostname = node.Labels["kubernetes.io/hostname"]
+ } else {
+ // if 'get nodes' is not allowed, just skip tests for node affinity
+ hostname = ""
+ }
+
+ if hostname != "" {
+ t.Run("Run Java with node affinity", func(t *testing.T) {
+ Expect(Kamel("run", "-n", ns, "files/Java.java",
+ "-t", "affinity.enabled=true",
+ "-t", fmt.Sprintf("affinity.node-affinity-labels=kubernetes.io/hostname in(%s)", hostname)).Execute()).Should(BeNil())
+ Eventually(IntegrationPodPhase(ns, "java"), TestTimeoutLong).Should(Equal(v1.PodRunning))
+ Eventually(IntegrationCondition(ns, "java", camelv1.IntegrationConditionReady), TestTimeoutShort).Should(Equal(v1.ConditionTrue))
+ Eventually(IntegrationLogs(ns, "java"), TestTimeoutShort).Should(ContainSubstring("Magicstring!"))
+
+ pod := IntegrationPod(ns, "java")()
+ Expect(pod.Spec.Affinity).ShouldNot(BeNil())
+ Expect(pod.Spec.Affinity.NodeAffinity).Should(Equal(&v1.NodeAffinity{
Review comment:
Ah we commented at the same time :) Yes it is enough the check `.Spec.NodeName` field.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] tadayosi commented on a change in pull request #1866: chore(e2e): add test for Affinity trait #1547
Posted by GitBox <gi...@apache.org>.
tadayosi commented on a change in pull request #1866:
URL: https://github.com/apache/camel-k/pull/1866#discussion_r544913910
##########
File path: e2e/common/affinity_test.go
##########
@@ -0,0 +1,149 @@
+// +build integration
+
+// To enable compilation of this file in Goland, go to "Settings -> Go -> Vendoring & Build Tags -> Custom Tags" and add "integration"
+
+/*
+Licensed to the Apache Software Foundation (ASF) under one or more
+contributor license agreements. See the NOTICE file distributed with
+this work for additional information regarding copyright ownership.
+The ASF licenses this file to You under the Apache License, Version 2.0
+(the "License"); you may not use this file except in compliance with
+the License. You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+Unless required by applicable law or agreed to in writing, software
+distributed under the License is distributed on an "AS IS" BASIS,
+WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+See the License for the specific language governing permissions and
+limitations under the License.
+*/
+
+package common
+
+import (
+ "fmt"
+ "testing"
+
+ . "github.com/apache/camel-k/e2e/support"
+ camelv1 "github.com/apache/camel-k/pkg/apis/camel/v1"
+
+ . "github.com/onsi/gomega"
+
+ v1 "k8s.io/api/core/v1"
+ metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
+)
+
+func TestAffinityTrait(t *testing.T) {
+ WithNewTestNamespace(t, func(ns string) {
+ Expect(Kamel("install", "-n", ns).Execute()).Should(BeNil())
+
+ var hostname string
+ if node, err := selectSchedulableNode(); err == nil {
+ hostname = node.Labels["kubernetes.io/hostname"]
+ } else {
+ // if 'get nodes' is not allowed, just skip tests for node affinity
+ hostname = ""
+ }
+
+ if hostname != "" {
+ t.Run("Run Java with node affinity", func(t *testing.T) {
+ Expect(Kamel("run", "-n", ns, "files/Java.java",
+ "-t", "affinity.enabled=true",
+ "-t", fmt.Sprintf("affinity.node-affinity-labels=kubernetes.io/hostname in(%s)", hostname)).Execute()).Should(BeNil())
+ Eventually(IntegrationPodPhase(ns, "java"), TestTimeoutLong).Should(Equal(v1.PodRunning))
+ Eventually(IntegrationCondition(ns, "java", camelv1.IntegrationConditionReady), TestTimeoutShort).Should(Equal(v1.ConditionTrue))
+ Eventually(IntegrationLogs(ns, "java"), TestTimeoutShort).Should(ContainSubstring("Magicstring!"))
+
+ pod := IntegrationPod(ns, "java")()
+ Expect(pod.Spec.Affinity).ShouldNot(BeNil())
+ Expect(pod.Spec.Affinity.NodeAffinity).Should(Equal(&v1.NodeAffinity{
Review comment:
Thanks for your suggestion. Is there a nice way to check that?
I thought it was enough to check the pod spec only because after it's set up as expected it's rather the responsibility of k8s control plane than camel-k operator that enforces the conditions. But if there is any quick way to do the additional check I can do that.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] astefanutti commented on a change in pull request #1866: chore(e2e): add test for Affinity trait #1547
Posted by GitBox <gi...@apache.org>.
astefanutti commented on a change in pull request #1866:
URL: https://github.com/apache/camel-k/pull/1866#discussion_r545001892
##########
File path: e2e/common/affinity_test.go
##########
@@ -0,0 +1,149 @@
+// +build integration
+
+// To enable compilation of this file in Goland, go to "Settings -> Go -> Vendoring & Build Tags -> Custom Tags" and add "integration"
+
+/*
+Licensed to the Apache Software Foundation (ASF) under one or more
+contributor license agreements. See the NOTICE file distributed with
+this work for additional information regarding copyright ownership.
+The ASF licenses this file to You under the Apache License, Version 2.0
+(the "License"); you may not use this file except in compliance with
+the License. You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+Unless required by applicable law or agreed to in writing, software
+distributed under the License is distributed on an "AS IS" BASIS,
+WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+See the License for the specific language governing permissions and
+limitations under the License.
+*/
+
+package common
+
+import (
+ "fmt"
+ "testing"
+
+ . "github.com/apache/camel-k/e2e/support"
+ camelv1 "github.com/apache/camel-k/pkg/apis/camel/v1"
+
+ . "github.com/onsi/gomega"
+
+ v1 "k8s.io/api/core/v1"
+ metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
+)
+
+func TestAffinityTrait(t *testing.T) {
+ WithNewTestNamespace(t, func(ns string) {
+ Expect(Kamel("install", "-n", ns).Execute()).Should(BeNil())
+
+ var hostname string
+ if node, err := selectSchedulableNode(); err == nil {
+ hostname = node.Labels["kubernetes.io/hostname"]
+ } else {
+ // if 'get nodes' is not allowed, just skip tests for node affinity
+ hostname = ""
+ }
+
+ if hostname != "" {
+ t.Run("Run Java with node affinity", func(t *testing.T) {
+ Expect(Kamel("run", "-n", ns, "files/Java.java",
+ "-t", "affinity.enabled=true",
+ "-t", fmt.Sprintf("affinity.node-affinity-labels=kubernetes.io/hostname in(%s)", hostname)).Execute()).Should(BeNil())
+ Eventually(IntegrationPodPhase(ns, "java"), TestTimeoutLong).Should(Equal(v1.PodRunning))
+ Eventually(IntegrationCondition(ns, "java", camelv1.IntegrationConditionReady), TestTimeoutShort).Should(Equal(v1.ConditionTrue))
+ Eventually(IntegrationLogs(ns, "java"), TestTimeoutShort).Should(ContainSubstring("Magicstring!"))
+
+ pod := IntegrationPod(ns, "java")()
+ Expect(pod.Spec.Affinity).ShouldNot(BeNil())
+ Expect(pod.Spec.Affinity.NodeAffinity).Should(Equal(&v1.NodeAffinity{
Review comment:
It looks like it worked!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] astefanutti commented on a change in pull request #1866: chore(e2e): add test for Affinity trait #1547
Posted by GitBox <gi...@apache.org>.
astefanutti commented on a change in pull request #1866:
URL: https://github.com/apache/camel-k/pull/1866#discussion_r544902065
##########
File path: e2e/common/affinity_test.go
##########
@@ -0,0 +1,149 @@
+// +build integration
+
+// To enable compilation of this file in Goland, go to "Settings -> Go -> Vendoring & Build Tags -> Custom Tags" and add "integration"
+
+/*
+Licensed to the Apache Software Foundation (ASF) under one or more
+contributor license agreements. See the NOTICE file distributed with
+this work for additional information regarding copyright ownership.
+The ASF licenses this file to You under the Apache License, Version 2.0
+(the "License"); you may not use this file except in compliance with
+the License. You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+Unless required by applicable law or agreed to in writing, software
+distributed under the License is distributed on an "AS IS" BASIS,
+WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+See the License for the specific language governing permissions and
+limitations under the License.
+*/
+
+package common
+
+import (
+ "fmt"
+ "testing"
+
+ . "github.com/apache/camel-k/e2e/support"
+ camelv1 "github.com/apache/camel-k/pkg/apis/camel/v1"
+
+ . "github.com/onsi/gomega"
+
+ v1 "k8s.io/api/core/v1"
+ metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
+)
+
+func TestAffinityTrait(t *testing.T) {
+ WithNewTestNamespace(t, func(ns string) {
+ Expect(Kamel("install", "-n", ns).Execute()).Should(BeNil())
+
+ var hostname string
+ if node, err := selectSchedulableNode(); err == nil {
+ hostname = node.Labels["kubernetes.io/hostname"]
+ } else {
+ // if 'get nodes' is not allowed, just skip tests for node affinity
+ hostname = ""
+ }
+
+ if hostname != "" {
+ t.Run("Run Java with node affinity", func(t *testing.T) {
+ Expect(Kamel("run", "-n", ns, "files/Java.java",
+ "-t", "affinity.enabled=true",
+ "-t", fmt.Sprintf("affinity.node-affinity-labels=kubernetes.io/hostname in(%s)", hostname)).Execute()).Should(BeNil())
+ Eventually(IntegrationPodPhase(ns, "java"), TestTimeoutLong).Should(Equal(v1.PodRunning))
+ Eventually(IntegrationCondition(ns, "java", camelv1.IntegrationConditionReady), TestTimeoutShort).Should(Equal(v1.ConditionTrue))
+ Eventually(IntegrationLogs(ns, "java"), TestTimeoutShort).Should(ContainSubstring("Magicstring!"))
+
+ pod := IntegrationPod(ns, "java")()
+ Expect(pod.Spec.Affinity).ShouldNot(BeNil())
+ Expect(pod.Spec.Affinity.NodeAffinity).Should(Equal(&v1.NodeAffinity{
Review comment:
Maybe it could be asserted that the integration pod has actually been scheduled on the expected node.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] astefanutti merged pull request #1866: chore(e2e): add test for Affinity trait #1547
Posted by GitBox <gi...@apache.org>.
astefanutti merged pull request #1866:
URL: https://github.com/apache/camel-k/pull/1866
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] astefanutti commented on a change in pull request #1866: chore(e2e): add test for Affinity trait #1547
Posted by GitBox <gi...@apache.org>.
astefanutti commented on a change in pull request #1866:
URL: https://github.com/apache/camel-k/pull/1866#discussion_r544921090
##########
File path: e2e/common/affinity_test.go
##########
@@ -0,0 +1,149 @@
+// +build integration
+
+// To enable compilation of this file in Goland, go to "Settings -> Go -> Vendoring & Build Tags -> Custom Tags" and add "integration"
+
+/*
+Licensed to the Apache Software Foundation (ASF) under one or more
+contributor license agreements. See the NOTICE file distributed with
+this work for additional information regarding copyright ownership.
+The ASF licenses this file to You under the Apache License, Version 2.0
+(the "License"); you may not use this file except in compliance with
+the License. You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+Unless required by applicable law or agreed to in writing, software
+distributed under the License is distributed on an "AS IS" BASIS,
+WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+See the License for the specific language governing permissions and
+limitations under the License.
+*/
+
+package common
+
+import (
+ "fmt"
+ "testing"
+
+ . "github.com/apache/camel-k/e2e/support"
+ camelv1 "github.com/apache/camel-k/pkg/apis/camel/v1"
+
+ . "github.com/onsi/gomega"
+
+ v1 "k8s.io/api/core/v1"
+ metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
+)
+
+func TestAffinityTrait(t *testing.T) {
+ WithNewTestNamespace(t, func(ns string) {
+ Expect(Kamel("install", "-n", ns).Execute()).Should(BeNil())
+
+ var hostname string
+ if node, err := selectSchedulableNode(); err == nil {
+ hostname = node.Labels["kubernetes.io/hostname"]
+ } else {
+ // if 'get nodes' is not allowed, just skip tests for node affinity
+ hostname = ""
+ }
+
+ if hostname != "" {
+ t.Run("Run Java with node affinity", func(t *testing.T) {
+ Expect(Kamel("run", "-n", ns, "files/Java.java",
+ "-t", "affinity.enabled=true",
+ "-t", fmt.Sprintf("affinity.node-affinity-labels=kubernetes.io/hostname in(%s)", hostname)).Execute()).Should(BeNil())
+ Eventually(IntegrationPodPhase(ns, "java"), TestTimeoutLong).Should(Equal(v1.PodRunning))
+ Eventually(IntegrationCondition(ns, "java", camelv1.IntegrationConditionReady), TestTimeoutShort).Should(Equal(v1.ConditionTrue))
+ Eventually(IntegrationLogs(ns, "java"), TestTimeoutShort).Should(ContainSubstring("Magicstring!"))
+
+ pod := IntegrationPod(ns, "java")()
+ Expect(pod.Spec.Affinity).ShouldNot(BeNil())
+ Expect(pod.Spec.Affinity.NodeAffinity).Should(Equal(&v1.NodeAffinity{
Review comment:
I think it can be checked with `pod.Spec.NodeName`, or `pod.Status.HostIP` indirectly.
I agree it is not the direct responsibility of Camel K, yet I'd be inclined to think it is the actual value of the e2e tests to cover the overall end result.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] tadayosi commented on a change in pull request #1866: chore(e2e): add test for Affinity trait #1547
Posted by GitBox <gi...@apache.org>.
tadayosi commented on a change in pull request #1866:
URL: https://github.com/apache/camel-k/pull/1866#discussion_r544924745
##########
File path: e2e/common/affinity_test.go
##########
@@ -0,0 +1,149 @@
+// +build integration
+
+// To enable compilation of this file in Goland, go to "Settings -> Go -> Vendoring & Build Tags -> Custom Tags" and add "integration"
+
+/*
+Licensed to the Apache Software Foundation (ASF) under one or more
+contributor license agreements. See the NOTICE file distributed with
+this work for additional information regarding copyright ownership.
+The ASF licenses this file to You under the Apache License, Version 2.0
+(the "License"); you may not use this file except in compliance with
+the License. You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+Unless required by applicable law or agreed to in writing, software
+distributed under the License is distributed on an "AS IS" BASIS,
+WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+See the License for the specific language governing permissions and
+limitations under the License.
+*/
+
+package common
+
+import (
+ "fmt"
+ "testing"
+
+ . "github.com/apache/camel-k/e2e/support"
+ camelv1 "github.com/apache/camel-k/pkg/apis/camel/v1"
+
+ . "github.com/onsi/gomega"
+
+ v1 "k8s.io/api/core/v1"
+ metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
+)
+
+func TestAffinityTrait(t *testing.T) {
+ WithNewTestNamespace(t, func(ns string) {
+ Expect(Kamel("install", "-n", ns).Execute()).Should(BeNil())
+
+ var hostname string
+ if node, err := selectSchedulableNode(); err == nil {
+ hostname = node.Labels["kubernetes.io/hostname"]
+ } else {
+ // if 'get nodes' is not allowed, just skip tests for node affinity
+ hostname = ""
+ }
+
+ if hostname != "" {
+ t.Run("Run Java with node affinity", func(t *testing.T) {
+ Expect(Kamel("run", "-n", ns, "files/Java.java",
+ "-t", "affinity.enabled=true",
+ "-t", fmt.Sprintf("affinity.node-affinity-labels=kubernetes.io/hostname in(%s)", hostname)).Execute()).Should(BeNil())
+ Eventually(IntegrationPodPhase(ns, "java"), TestTimeoutLong).Should(Equal(v1.PodRunning))
+ Eventually(IntegrationCondition(ns, "java", camelv1.IntegrationConditionReady), TestTimeoutShort).Should(Equal(v1.ConditionTrue))
+ Eventually(IntegrationLogs(ns, "java"), TestTimeoutShort).Should(ContainSubstring("Magicstring!"))
+
+ pod := IntegrationPod(ns, "java")()
+ Expect(pod.Spec.Affinity).ShouldNot(BeNil())
+ Expect(pod.Spec.Affinity.NodeAffinity).Should(Equal(&v1.NodeAffinity{
Review comment:
Thanks. OK, `pod.Status.HostIP` can be different from the label's `hostname` value so I added a check on `pod.Spec.NodeName` and force pushed it. Let's see if the CI builds run fine.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org