You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@inlong.apache.org by "fuweng11 (via GitHub)" <gi...@apache.org> on 2023/02/03 04:50:04 UTC

[GitHub] [inlong] fuweng11 opened a new pull request, #7316: [INLONG-7256][Manager] Add a check for serverUrl

fuweng11 opened a new pull request, #7316:
URL: https://github.com/apache/inlong/pull/7316

   ### Prepare a Pull Request
   - Fixes #7256 
   
   ### Motivation
   
   Add a check for serverUrl
   ### Modifications
   
   Add a check for serverUrl
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [inlong] healchow commented on a diff in pull request #7316: [INLONG-7256][Manager] Add a check for serverUrl

Posted by "healchow (via GitHub)" <gi...@apache.org>.
healchow commented on code in PR #7316:
URL: https://github.com/apache/inlong/pull/7316#discussion_r1095405246


##########
inlong-manager/manager-service/src/main/java/org/apache/inlong/manager/service/cluster/PulsarClusterOperator.java:
##########
@@ -87,17 +95,29 @@ protected void setTargetEntity(ClusterRequest request, InlongClusterEntity targe
         }
     }
 
-    @Override
     public Boolean testConnection(ClusterRequest request) {
         PulsarClusterRequest pulsarRequest = (PulsarClusterRequest) request;
         PulsarClusterInfo pulsarInfo = new PulsarClusterInfo();
         CommonBeanUtils.copyProperties(pulsarRequest, pulsarInfo);
         try (PulsarAdmin ignored = PulsarUtils.getPulsarAdmin(pulsarInfo)) {

Review Comment:
   `ignored` is weired too.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [inlong] healchow commented on a diff in pull request #7316: [INLONG-7256][Manager] Add a check for serverUrl

Posted by "healchow (via GitHub)" <gi...@apache.org>.
healchow commented on code in PR #7316:
URL: https://github.com/apache/inlong/pull/7316#discussion_r1095404473


##########
inlong-manager/manager-service/src/main/java/org/apache/inlong/manager/service/cluster/PulsarClusterOperator.java:
##########
@@ -87,17 +95,29 @@ protected void setTargetEntity(ClusterRequest request, InlongClusterEntity targe
         }
     }
 
-    @Override

Review Comment:
   Why remove it?



##########
inlong-manager/manager-service/src/main/java/org/apache/inlong/manager/service/cluster/PulsarClusterOperator.java:
##########
@@ -44,6 +50,8 @@ public class PulsarClusterOperator extends AbstractClusterOperator {
 
     private static final Logger LOGGER = LoggerFactory.getLogger(PulsarClusterOperator.class);
 
+    private static final String SERVER_URL_PREFIX = "pulsar://";

Review Comment:
   It should be `service URL`.



##########
inlong-manager/manager-service/src/main/java/org/apache/inlong/manager/service/cluster/PulsarClusterOperator.java:
##########
@@ -87,17 +95,29 @@ protected void setTargetEntity(ClusterRequest request, InlongClusterEntity targe
         }
     }
 
-    @Override
     public Boolean testConnection(ClusterRequest request) {
         PulsarClusterRequest pulsarRequest = (PulsarClusterRequest) request;
         PulsarClusterInfo pulsarInfo = new PulsarClusterInfo();
         CommonBeanUtils.copyProperties(pulsarRequest, pulsarInfo);
         try (PulsarAdmin ignored = PulsarUtils.getPulsarAdmin(pulsarInfo)) {
-            LOGGER.debug("pulsar connection not null - connection success for adminUrl={}", pulsarInfo.getAdminUrl());
+            ignored.tenants().getTenants();
+            String serviceUrl = pulsarInfo.getUrl();
+            Preconditions.expectNotNull(serviceUrl, "ServerUrl is empty");

Review Comment:
   Please change all `serverUrl` to `serviceUrl` for Apache Pulsar.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [inlong] dockerzhang merged pull request #7316: [INLONG-7256][Manager] Add a check for Pulsar service URL

Posted by "dockerzhang (via GitHub)" <gi...@apache.org>.
dockerzhang merged PR #7316:
URL: https://github.com/apache/inlong/pull/7316


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org