You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "pierrejeambrun (via GitHub)" <gi...@apache.org> on 2023/03/10 19:26:03 UTC
[GitHub] [airflow] pierrejeambrun opened a new pull request, #30027: Fix breeze release management shell expansion
pierrejeambrun opened a new pull request, #30027:
URL: https://github.com/apache/airflow/pull/30027
Shell expansion is not working for those two commands. (globing)
Related: https://github.com/apache/airflow/pull/3740
The other way would be to rewrite this in a more 'pythonic' way, for instance using `shutil`, `os.listdir`, and such
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ephraimbuddy commented on pull request #30027: Fix breeze release management shell expansion
Posted by "ephraimbuddy (via GitHub)" <gi...@apache.org>.
ephraimbuddy commented on PR #30027:
URL: https://github.com/apache/airflow/pull/30027#issuecomment-1464446924
Can you also do the same for this: https://github.com/apache/airflow/blob/b9c231ceb0f3053a27744b80e95f08ac0684fe38/dev/breeze/src/airflow_breeze/commands/release_candidate_command.py#L105-L107,
It failed. Should be one single command instead of all 3
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] pierrejeambrun commented on pull request #30027: Fix breeze release management shell expansion
Posted by "pierrejeambrun (via GitHub)" <gi...@apache.org>.
pierrejeambrun commented on PR #30027:
URL: https://github.com/apache/airflow/pull/30027#issuecomment-1464528352
Yes of course. I just updated the signing command, tested locally and working nicely.
We also avoid using "pushd" and "popd" which are not supported in 'sh' which is the default executable of the subprocess module.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] pierrejeambrun merged pull request #30027: Fix breeze release management shell expansion
Posted by "pierrejeambrun (via GitHub)" <gi...@apache.org>.
pierrejeambrun merged PR #30027:
URL: https://github.com/apache/airflow/pull/30027
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org