You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "szehon-ho (via GitHub)" <gi...@apache.org> on 2025/02/20 19:50:20 UTC
[PR] [SPARK-51222][SQL][FOLLOW-UP] Optimize ReplaceCurrentLike [spark]
szehon-ho opened a new pull request, #50028:
URL: https://github.com/apache/spark/pull/50028
### What changes were proposed in this pull request?
Minor follow up for https://github.com/apache/spark/pull/49963 to use lazy vals
### Why are the changes needed?
The original pr would have a small potential behavior change, if there are multiple current_ functions in the query, it could evaluate different results if the catalog is updated in the backend. Making a lazy val allows the FinishAnalysis phase to resolve one value for each current_function even in this case.
### Does this PR introduce _any_ user-facing change?
No
### How was this patch tested?
Existing unit test
### Was this patch authored or co-authored using generative AI tooling?
No
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-51222][SQL][FOLLOW-UP] Optimize ReplaceCurrentLike [spark]
Posted by "cloud-fan (via GitHub)" <gi...@apache.org>.
cloud-fan commented on PR #50028:
URL: https://github.com/apache/spark/pull/50028#issuecomment-2673135965
thanks, merging to master/4.0!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-51222][SQL][FOLLOW-UP] Optimize ReplaceCurrentLike [spark]
Posted by "cloud-fan (via GitHub)" <gi...@apache.org>.
cloud-fan closed pull request #50028: [SPARK-51222][SQL][FOLLOW-UP] Optimize ReplaceCurrentLike
URL: https://github.com/apache/spark/pull/50028
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-51222][SQL][FOLLOW-UP] Optimize ReplaceCurrentLike [spark]
Posted by "szehon-ho (via GitHub)" <gi...@apache.org>.
szehon-ho closed pull request #50028: [SPARK-51222][SQL][FOLLOW-UP] Optimize ReplaceCurrentLike
URL: https://github.com/apache/spark/pull/50028
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org