[GitHub] [spark] skonto commented on issue #25098: [SPARK-28280][SQL][PYTHON][TESTS] Convert and port 'group-by.sql' into UDF test base

[GitBox <gi...@apache.org>]

skonto commented on issue #25098: [SPARK-28280][SQL][PYTHON][TESTS] Convert and port 'group-by.sql' into UDF test base
URL: https://github.com/apache/spark/pull/25098#issuecomment-510213405
 
 
   if I set:
   ```
     case class TestScalaUDF(name: String) extends TestUDF {
       private def mapToString(input: Any): Any = {
         val ret = String.valueOf(input)
         if (input == null) {
           input
         } else {
           ret
         }
       }
       private[IntegratedUDFTestUtils] lazy val udf = SparkUserDefinedFunction(
         (input: Any) => mapToString(input),
         StringType,
         inputSchemas = Seq.fill(1)(None),
         name = Some(name))
   
       def apply(exprs: Column*): Column = udf(exprs: _*)
   
       val prettyName: String = "Scala UDF"
     }
   ```
   it validates against the golden file which means when golden file is not generated test suite picks up "--set" configs and results change... So there is a bug here about expected behavior. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org