You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@sling.apache.org by jo...@apache.org on 2026/09/14 14:30:59 UTC
(sling-org-apache-sling-engine) 01/01: SLING-13345 remove noisy statements from RequestProgressTracker in the logs
This is an automated email from the ASF dual-hosted git repository.
joerghoh pushed a commit to branch SLING-13345
in repository https://gitbox.apache.org/repos/asf/sling-org-apache-sling-engine.git
commit 451514b90e3768b15d4c190378d7dcf19503c4c0
Author: Joerg Hoh <jo...@apache.org>
AuthorDate: Mon Sep 14 16:30:42 2026 +0200
SLING-13345 remove noisy statements from RequestProgressTracker in the logs
---
.../sling/engine/impl/SlingJakartaHttpServletResponseImpl.java | 7 ++++++-
.../apache/sling/engine/impl/SlingHttpServletResponseImplTest.java | 5 +----
2 files changed, 7 insertions(+), 5 deletions(-)
diff --git a/src/main/java/org/apache/sling/engine/impl/SlingJakartaHttpServletResponseImpl.java b/src/main/java/org/apache/sling/engine/impl/SlingJakartaHttpServletResponseImpl.java
index 127609f..5ed609b 100644
--- a/src/main/java/org/apache/sling/engine/impl/SlingJakartaHttpServletResponseImpl.java
+++ b/src/main/java/org/apache/sling/engine/impl/SlingJakartaHttpServletResponseImpl.java
@@ -403,12 +403,17 @@ public class SlingJakartaHttpServletResponseImpl extends HttpServletResponseWrap
requestData.getRequestProgressTracker().getMessages();
LinkedList<String> lastMessages = new LinkedList<>();
while (messagesIterator.hasNext()) {
+ String message = messagesIterator.next();
+ // skip all log filter messages, as they are not helpful to understand this issue
+ if (message.contains("LOG Calling filter:")) {
+ continue;
+ }
nrOfOriginalMessages++;
if (gotCut || lastMessages.size() >= MAX_NR_OF_MESSAGES) {
lastMessages.removeFirst();
gotCut = true;
}
- lastMessages.add(messagesIterator.next());
+ lastMessages.add(message);
}
if (gotCut) {
diff --git a/src/test/java/org/apache/sling/engine/impl/SlingHttpServletResponseImplTest.java b/src/test/java/org/apache/sling/engine/impl/SlingHttpServletResponseImplTest.java
index b14bc5b..dbc2631 100644
--- a/src/test/java/org/apache/sling/engine/impl/SlingHttpServletResponseImplTest.java
+++ b/src/test/java/org/apache/sling/engine/impl/SlingHttpServletResponseImplTest.java
@@ -62,11 +62,8 @@ public class SlingHttpServletResponseImplTest {
"3724 TIMER_END{1040,resolveServlet(/content/slingshot)} Using servlet /libs/slingshot/Home/html.jsp",
"3727 TIMER_END{1047,ServletResolution} URI=/content/slingshot.html handled by Servlet=/libs/slingshot/Home/html.jsp",
"3736 LOG Applying REQUESTfilters",
- "3751 LOG Calling filter: com.composum.sling.nodes.mount.remote.RemoteRequestFilter",
"4722 TIMER_START{/libs/slingshot/Component/head.html.jsp#1}",
- "3757 LOG Calling filter: org.apache.sling.i18n.impl.I18NFilter",
"4859 TIMER_END{135,/libs/slingshot/Component/head.html.jsp#1}",
- "3765 LOG Calling filter: org.apache.sling.engine.impl.debug.RequestProgressTrackerLogFilter",
"2678 TIMER_START{ServletResolution}",
"2683 TIMER_START{resolveServlet(/content/slingshot)}",
"2678 TIMER_START{ServletResolution}",
@@ -245,7 +242,7 @@ public class SlingHttpServletResponseImplTest {
// validate that the log message is cut off and only the last MAX_NR_OF_MESSAGES
// remain in the log message, check for the cut message
- assertTrue(logMessage.contains("... cut 504 messages ..."));
+ assertTrue(logMessage.contains("... cut 348 messages ..."));
}
@Test