You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@groovy.apache.org by jwagenleitner <gi...@git.apache.org> on 2016/05/09 19:01:53 UTC
[GitHub] groovy pull request: GROOVY-7291 - Declaration of double variable ...
GitHub user jwagenleitner opened a pull request:
https://github.com/apache/groovy/pull/331
GROOVY-7291 - Declaration of double variable without value assignment referrenced in closure
Commit e08c389d67809a421f4f33c27012c54294f98259 made the change that broke this by resolving the type (Double) whereas the original method call resolved to `getOriginType` (double). This change tries to preserve the call to the type resolver where the origin is not a primitive. It should also be noted that fully reverting the call back to the original (`compileStack.defineVariable(ve, false)`) version prior to commit e08c389d67809a421f4f33c27012c54294f98259 also passes all tests.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jwagenleitner/groovy GROOVY-7291
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/groovy/pull/331.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #331
----
commit a50582bfb6ed015d700bd8899a2fb1c4e7387d6e
Author: John Wagenleitner <jw...@apache.org>
Date: 2016-05-08T18:56:45Z
GROOVY-7291 - Declaration of double variable without value assignment referrenced in closure
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] groovy pull request #331: GROOVY-7291 - Declaration of double variable witho...
Posted by jwagenleitner <gi...@git.apache.org>.
Github user jwagenleitner closed the pull request at:
https://github.com/apache/groovy/pull/331
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---