You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2020/06/16 04:48:04 UTC
[GitHub] [incubator-doris] morningman opened a new pull request #3886: [Planner] Set MysqlScanNode's cardinality to avoid unexpected shuffle join
morningman opened a new pull request #3886:
URL: https://github.com/apache/incubator-doris/pull/3886
Fix #3885
1. Set MysqlScanNode's cardinality to 0
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] wutiangan commented on a change in pull request #3886: [Planner] Set MysqlScanNode's cardinality to avoid unexpected shuffle join
Posted by GitBox <gi...@apache.org>.
wutiangan commented on a change in pull request #3886:
URL: https://github.com/apache/incubator-doris/pull/3886#discussion_r440594546
##########
File path: fe/src/main/java/org/apache/doris/planner/DistributedPlanner.java
##########
@@ -294,6 +294,11 @@ private PlanFragment createHashJoinFragment(HashJoinNode node, PlanFragment righ
// broadcast: send the rightChildFragment's output to each node executing
// the leftChildFragment; the cost across all nodes is proportional to the
// total amount of data sent
+
+ // NOTICE(cmy): for now, only MysqlScanNode and OlapScanNode has Cardinality. And MysqlScanNode's Cardinality
+ // is always 0. Other ScanNode's cardinality is -1, so they won't be able the calculate the cost of
Review comment:
```suggestion
// is always 0. Other ScanNode's cardinality is -1, so they won't be able to calculate the cost of
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] wutiangan commented on a change in pull request #3886: [Planner] Set MysqlScanNode's cardinality to avoid unexpected shuffle join
Posted by GitBox <gi...@apache.org>.
wutiangan commented on a change in pull request #3886:
URL: https://github.com/apache/incubator-doris/pull/3886#discussion_r440596171
##########
File path: fe/src/main/java/org/apache/doris/planner/DistributedPlanner.java
##########
@@ -294,6 +294,11 @@ private PlanFragment createHashJoinFragment(HashJoinNode node, PlanFragment righ
// broadcast: send the rightChildFragment's output to each node executing
// the leftChildFragment; the cost across all nodes is proportional to the
// total amount of data sent
+
+ // NOTICE(cmy): for now, only MysqlScanNode and OlapScanNode has Cardinality. And MysqlScanNode's Cardinality
+ // is always 0. Other ScanNode's cardinality is -1, so they won't be able the calculate the cost of
Review comment:
```suggestion
// is always -1. Other ScanNode's cardinality is greater than or equal to zero, so they won't be able to calculate the cost of
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] wuyunfeng commented on a change in pull request #3886: [Planner] Set MysqlScanNode's cardinality to avoid unexpected shuffle join
Posted by GitBox <gi...@apache.org>.
wuyunfeng commented on a change in pull request #3886:
URL: https://github.com/apache/incubator-doris/pull/3886#discussion_r440608474
##########
File path: fe/src/main/java/org/apache/doris/planner/DistributedPlanner.java
##########
@@ -294,6 +294,11 @@ private PlanFragment createHashJoinFragment(HashJoinNode node, PlanFragment righ
// broadcast: send the rightChildFragment's output to each node executing
// the leftChildFragment; the cost across all nodes is proportional to the
// total amount of data sent
+
+ // NOTICE(cmy): for now, only MysqlScanNode and OlapScanNode has Cardinality. And MysqlScanNode's Cardinality
Review comment:
```suggestion
// NOTICE: for now, only MysqlScanNode and OlapScanNode has Cardinality. And MysqlScanNode's Cardinality
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] wutiangan commented on a change in pull request #3886: [Planner] Set MysqlScanNode's cardinality to avoid unexpected shuffle join
Posted by GitBox <gi...@apache.org>.
wutiangan commented on a change in pull request #3886:
URL: https://github.com/apache/incubator-doris/pull/3886#discussion_r440596171
##########
File path: fe/src/main/java/org/apache/doris/planner/DistributedPlanner.java
##########
@@ -294,6 +294,11 @@ private PlanFragment createHashJoinFragment(HashJoinNode node, PlanFragment righ
// broadcast: send the rightChildFragment's output to each node executing
// the leftChildFragment; the cost across all nodes is proportional to the
// total amount of data sent
+
+ // NOTICE(cmy): for now, only MysqlScanNode and OlapScanNode has Cardinality. And MysqlScanNode's Cardinality
+ // is always 0. Other ScanNode's cardinality is -1, so they won't be able the calculate the cost of
Review comment:
```suggestion
// is always -1. Other ScanNode's cardinality is greater than or equal 1, so they won't be able the calculate the cost of
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] wutiangan commented on a change in pull request #3886: [Planner] Set MysqlScanNode's cardinality to avoid unexpected shuffle join
Posted by GitBox <gi...@apache.org>.
wutiangan commented on a change in pull request #3886:
URL: https://github.com/apache/incubator-doris/pull/3886#discussion_r440594546
##########
File path: fe/src/main/java/org/apache/doris/planner/DistributedPlanner.java
##########
@@ -294,6 +294,11 @@ private PlanFragment createHashJoinFragment(HashJoinNode node, PlanFragment righ
// broadcast: send the rightChildFragment's output to each node executing
// the leftChildFragment; the cost across all nodes is proportional to the
// total amount of data sent
+
+ // NOTICE(cmy): for now, only MysqlScanNode and OlapScanNode has Cardinality. And MysqlScanNode's Cardinality
+ // is always 0. Other ScanNode's cardinality is -1, so they won't be able the calculate the cost of
Review comment:
```suggestion
// is always 0. Other ScanNode's cardinality is -1, so they won't be able to calculate the cost of
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] wutiangan commented on a change in pull request #3886: [Planner] Set MysqlScanNode's cardinality to avoid unexpected shuffle join
Posted by GitBox <gi...@apache.org>.
wutiangan commented on a change in pull request #3886:
URL: https://github.com/apache/incubator-doris/pull/3886#discussion_r440596929
##########
File path: fe/src/main/java/org/apache/doris/planner/MysqlScanNode.java
##########
@@ -149,4 +150,14 @@ public int getNumInstances() {
return 1;
}
+ @Override
+ public void computeStats(Analyzer analyzer) {
+ super.computeStats(analyzer);
+ // even current node scan has no data,at least on backend will be assigned when the fragment actually execute
Review comment:
```suggestion
// even if current node scan has no data,at least on backend will be assigned when the fragment actually execute
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] kangkaisen merged pull request #3886: [Planner] Set MysqlScanNode's cardinality to avoid unexpected shuffle join
Posted by GitBox <gi...@apache.org>.
kangkaisen merged pull request #3886:
URL: https://github.com/apache/incubator-doris/pull/3886
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] wutiangan commented on a change in pull request #3886: [Planner] Set MysqlScanNode's cardinality to avoid unexpected shuffle join
Posted by GitBox <gi...@apache.org>.
wutiangan commented on a change in pull request #3886:
URL: https://github.com/apache/incubator-doris/pull/3886#discussion_r440596171
##########
File path: fe/src/main/java/org/apache/doris/planner/DistributedPlanner.java
##########
@@ -294,6 +294,11 @@ private PlanFragment createHashJoinFragment(HashJoinNode node, PlanFragment righ
// broadcast: send the rightChildFragment's output to each node executing
// the leftChildFragment; the cost across all nodes is proportional to the
// total amount of data sent
+
+ // NOTICE(cmy): for now, only MysqlScanNode and OlapScanNode has Cardinality. And MysqlScanNode's Cardinality
+ // is always 0. Other ScanNode's cardinality is -1, so they won't be able the calculate the cost of
Review comment:
```suggestion
// is always -1. Other ScanNode's cardinality is greater than or equal 1, so they won't be able to calculate the cost of
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] morningman commented on a change in pull request #3886: [Planner] Set MysqlScanNode's cardinality to avoid unexpected shuffle join
Posted by GitBox <gi...@apache.org>.
morningman commented on a change in pull request #3886:
URL: https://github.com/apache/incubator-doris/pull/3886#discussion_r440610898
##########
File path: fe/src/main/java/org/apache/doris/planner/DistributedPlanner.java
##########
@@ -294,6 +294,11 @@ private PlanFragment createHashJoinFragment(HashJoinNode node, PlanFragment righ
// broadcast: send the rightChildFragment's output to each node executing
// the leftChildFragment; the cost across all nodes is proportional to the
// total amount of data sent
+
+ // NOTICE(cmy): for now, only MysqlScanNode and OlapScanNode has Cardinality. And MysqlScanNode's Cardinality
+ // is always 0. Other ScanNode's cardinality is -1, so they won't be able the calculate the cost of
Review comment:
done
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org