You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2021/09/21 01:55:37 UTC
[GitHub] [pulsar] yuruguo opened a new pull request #12108: [pulsar-client] Make it possible to disable poolMessages
yuruguo opened a new pull request #12108:
URL: https://github.com/apache/pulsar/pull/12108
### Motivation
Detail see [[pulsar-perf] Make it possible to disable poolMessages](https://github.com/apache/pulsar/pull/12090#issue-736895104)
### Documentation
- no-need-doc
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] yuruguo commented on pull request #12108: [pulsar-client] Make it possible to disable poolMessages
Posted by GitBox <gi...@apache.org>.
yuruguo commented on pull request #12108:
URL: https://github.com/apache/pulsar/pull/12108#issuecomment-923531807
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] yuruguo removed a comment on pull request #12108: [pulsar-client] Make it possible to disable poolMessages
Posted by GitBox <gi...@apache.org>.
yuruguo removed a comment on pull request #12108:
URL: https://github.com/apache/pulsar/pull/12108#issuecomment-923607284
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] yuruguo commented on pull request #12108: [pulsar-client] Make it possible to disable poolMessages
Posted by GitBox <gi...@apache.org>.
yuruguo commented on pull request #12108:
URL: https://github.com/apache/pulsar/pull/12108#issuecomment-926380276
> +1
Thanks for you time! If there is no problem, could you merge it to `master`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] yuruguo commented on pull request #12108: [pulsar-client] Make it possible to disable poolMessages
Posted by GitBox <gi...@apache.org>.
yuruguo commented on pull request #12108:
URL: https://github.com/apache/pulsar/pull/12108#issuecomment-923641315
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] yuruguo commented on pull request #12108: [pulsar-client] Make it possible to disable poolMessages
Posted by GitBox <gi...@apache.org>.
yuruguo commented on pull request #12108:
URL: https://github.com/apache/pulsar/pull/12108#issuecomment-923515481
PTAL @merlimat @lhotari @eolivelli @gaoran10
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lhotari merged pull request #12108: [pulsar-client] Make it possible to disable poolMessages
Posted by GitBox <gi...@apache.org>.
lhotari merged pull request #12108:
URL: https://github.com/apache/pulsar/pull/12108
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] yuruguo removed a comment on pull request #12108: [pulsar-client] Make it possible to disable poolMessages
Posted by GitBox <gi...@apache.org>.
yuruguo removed a comment on pull request #12108:
URL: https://github.com/apache/pulsar/pull/12108#issuecomment-923515481
PTAL @merlimat @lhotari @eolivelli @codelipenghui @gaoran10
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] yuruguo commented on pull request #12108: [pulsar-client] Make it possible to disable poolMessages
Posted by GitBox <gi...@apache.org>.
yuruguo commented on pull request #12108:
URL: https://github.com/apache/pulsar/pull/12108#issuecomment-925430262
@merlimat @eolivelli @codelipenghui PTAL
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] yuruguo edited a comment on pull request #12108: [pulsar-client] Make it possible to disable poolMessages
Posted by GitBox <gi...@apache.org>.
yuruguo edited a comment on pull request #12108:
URL: https://github.com/apache/pulsar/pull/12108#issuecomment-923515481
PTAL @merlimat @lhotari @eolivelli @codelipenghui @gaoran10
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] yuruguo commented on pull request #12108: [pulsar-client] Make it possible to disable poolMessages
Posted by GitBox <gi...@apache.org>.
yuruguo commented on pull request #12108:
URL: https://github.com/apache/pulsar/pull/12108#issuecomment-923559944
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] yuruguo removed a comment on pull request #12108: [pulsar-client] Make it possible to disable poolMessages
Posted by GitBox <gi...@apache.org>.
yuruguo removed a comment on pull request #12108:
URL: https://github.com/apache/pulsar/pull/12108#issuecomment-923569150
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] yuruguo commented on pull request #12108: [pulsar-client] Make it possible to disable poolMessages
Posted by GitBox <gi...@apache.org>.
yuruguo commented on pull request #12108:
URL: https://github.com/apache/pulsar/pull/12108#issuecomment-923569150
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] yuruguo removed a comment on pull request #12108: [pulsar-client] Make it possible to disable poolMessages
Posted by GitBox <gi...@apache.org>.
yuruguo removed a comment on pull request #12108:
URL: https://github.com/apache/pulsar/pull/12108#issuecomment-924505185
PTAL @merlimat @lhotari @eolivelli @codelipenghui @315157973 @hangc0276 @gaoran10
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] yuruguo edited a comment on pull request #12108: [pulsar-client] Make it possible to disable poolMessages
Posted by GitBox <gi...@apache.org>.
yuruguo edited a comment on pull request #12108:
URL: https://github.com/apache/pulsar/pull/12108#issuecomment-924505185
PTAL @merlimat @lhotari @eolivelli @codelipenghui @315157973 @hangc0276 @gaoran10
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] yuruguo removed a comment on pull request #12108: [pulsar-client] Make it possible to disable poolMessages
Posted by GitBox <gi...@apache.org>.
yuruguo removed a comment on pull request #12108:
URL: https://github.com/apache/pulsar/pull/12108#issuecomment-923559944
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] yuruguo removed a comment on pull request #12108: [pulsar-client] Make it possible to disable poolMessages
Posted by GitBox <gi...@apache.org>.
yuruguo removed a comment on pull request #12108:
URL: https://github.com/apache/pulsar/pull/12108#issuecomment-925430262
@merlimat @eolivelli @codelipenghui @hangc0276 PTAL
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] yuruguo removed a comment on pull request #12108: [pulsar-client] Make it possible to disable poolMessages
Posted by GitBox <gi...@apache.org>.
yuruguo removed a comment on pull request #12108:
URL: https://github.com/apache/pulsar/pull/12108#issuecomment-923531807
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] MarvinCai commented on a change in pull request #12108: [pulsar-client] Make it possible to disable poolMessages
Posted by GitBox <gi...@apache.org>.
MarvinCai commented on a change in pull request #12108:
URL: https://github.com/apache/pulsar/pull/12108#discussion_r714050291
##########
File path: pulsar-client-tools/src/main/java/org/apache/pulsar/client/cli/CmdConsume.java
##########
@@ -139,7 +139,7 @@
@Parameter(names = { "-st", "--schema-type"}, description = "Set a schema type on the consumer, it can be 'bytes' or 'auto_consume'")
private String schematype = "bytes";
- @Parameter(names = { "-pm", "--pool-messages" }, description = "Use the pooled message")
+ @Parameter(names = { "-pm", "--pool-messages" }, description = "Use the pooled message", arity = 1)
Review comment:
can we also update the doc here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] yuruguo removed a comment on pull request #12108: [pulsar-client] Make it possible to disable poolMessages
Posted by GitBox <gi...@apache.org>.
yuruguo removed a comment on pull request #12108:
URL: https://github.com/apache/pulsar/pull/12108#issuecomment-926361588
PTAL @eolivelli
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] yuruguo commented on pull request #12108: [pulsar-client] Make it possible to disable poolMessages
Posted by GitBox <gi...@apache.org>.
yuruguo commented on pull request #12108:
URL: https://github.com/apache/pulsar/pull/12108#issuecomment-924505185
PTAL @merlimat @lhotari @eolivelli @codelipenghui @hangc0276 @gaoran10
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] yuruguo commented on pull request #12108: [pulsar-client] Make it possible to disable poolMessages
Posted by GitBox <gi...@apache.org>.
yuruguo commented on pull request #12108:
URL: https://github.com/apache/pulsar/pull/12108#issuecomment-926361588
PTAL @eolivelli
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] yuruguo edited a comment on pull request #12108: [pulsar-client] Make it possible to disable poolMessages
Posted by GitBox <gi...@apache.org>.
yuruguo edited a comment on pull request #12108:
URL: https://github.com/apache/pulsar/pull/12108#issuecomment-925430262
@merlimat @eolivelli @codelipenghui @hangc0276 PTAL
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] yuruguo removed a comment on pull request #12108: [pulsar-client] Make it possible to disable poolMessages
Posted by GitBox <gi...@apache.org>.
yuruguo removed a comment on pull request #12108:
URL: https://github.com/apache/pulsar/pull/12108#issuecomment-923641315
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] yuruguo removed a comment on pull request #12108: [pulsar-client] Make it possible to disable poolMessages
Posted by GitBox <gi...@apache.org>.
yuruguo removed a comment on pull request #12108:
URL: https://github.com/apache/pulsar/pull/12108#issuecomment-926380276
> +1
Thanks for you time! If there is no problem, could you merge it to `master`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] yuruguo commented on pull request #12108: [pulsar-client] Make it possible to disable poolMessages
Posted by GitBox <gi...@apache.org>.
yuruguo commented on pull request #12108:
URL: https://github.com/apache/pulsar/pull/12108#issuecomment-923607284
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org