You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@kyuubi.apache.org by GitBox <gi...@apache.org> on 2022/01/18 08:58:18 UTC
[GitHub] [incubator-kyuubi] yanghua opened a new pull request #1795: [KYUUBI #1787] Export FLINK_ENGINE_HOME in load-kyuubi-env script
yanghua opened a new pull request #1795:
URL: https://github.com/apache/incubator-kyuubi/pull/1795
<!--
Thanks for sending a pull request!
Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://kyuubi.readthedocs.io/en/latest/community/contributions.html
2. If the PR is related to an issue in https://github.com/apache/incubator-kyuubi/issues, add '[KYUUBI #XXXX]' in your PR title, e.g., '[KYUUBI #XXXX] Your PR title ...'.
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][KYUUBI #XXXX] Your PR title ...'.
-->
### _Why are the changes needed?_
<!--
Please clarify why the changes are needed. For instance,
1. If you add a feature, you can talk about the use case of it.
2. If you fix a bug, you can clarify why it is a bug.
-->
### _How was this patch tested?_
- [ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible
- [ ] Add screenshots for manual tests if appropriate
- [ ] [Run test](https://kyuubi.readthedocs.io/en/latest/develop_tools/testing.html#running-tests) locally before make a pull request
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] pan3793 commented on pull request #1795: [KYUUBI #1787] Export FLINK_ENGINE_HOME in load-kyuubi-env script
Posted by GitBox <gi...@apache.org>.
pan3793 commented on pull request #1795:
URL: https://github.com/apache/incubator-kyuubi/pull/1795#issuecomment-1015261199
Thanks, mering to master
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] pan3793 commented on pull request #1795: [KYUUBI #1787] Export FLINK_ENGINE_HOME in load-kyuubi-env script
Posted by GitBox <gi...@apache.org>.
pan3793 commented on pull request #1795:
URL: https://github.com/apache/incubator-kyuubi/pull/1795#issuecomment-1015249670
Would you please rebase and resolve conflicts?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] codecov-commenter edited a comment on pull request #1795: [KYUUBI #1787] Export FLINK_ENGINE_HOME in load-kyuubi-env script
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #1795:
URL: https://github.com/apache/incubator-kyuubi/pull/1795#issuecomment-1015239763
# [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1795?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#1795](https://codecov.io/gh/apache/incubator-kyuubi/pull/1795?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (e135dc7) into [master](https://codecov.io/gh/apache/incubator-kyuubi/commit/916f81abaf46f1f28386aa57739cd84059b93dcd?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (916f81a) will **not change** coverage.
> The diff coverage is `n/a`.
> :exclamation: Current head e135dc7 differs from pull request most recent head 2d01d62. Consider uploading reports for the commit 2d01d62 to get more accurate results
[](https://codecov.io/gh/apache/incubator-kyuubi/pull/1795?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #1795 +/- ##
=========================================
Coverage 59.87% 59.87%
Complexity 264 264
=========================================
Files 275 275
Lines 13658 13658
Branches 1750 1750
=========================================
Hits 8178 8178
Misses 4777 4777
Partials 703 703
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1795?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1795?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [35ea750...2d01d62](https://codecov.io/gh/apache/incubator-kyuubi/pull/1795?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] codecov-commenter commented on pull request #1795: [KYUUBI #1787] Export FLINK_ENGINE_HOME in load-kyuubi-env script
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #1795:
URL: https://github.com/apache/incubator-kyuubi/pull/1795#issuecomment-1015239763
# [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1795?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#1795](https://codecov.io/gh/apache/incubator-kyuubi/pull/1795?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (e135dc7) into [master](https://codecov.io/gh/apache/incubator-kyuubi/commit/916f81abaf46f1f28386aa57739cd84059b93dcd?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (916f81a) will **not change** coverage.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-kyuubi/pull/1795?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #1795 +/- ##
=========================================
Coverage 59.87% 59.87%
Complexity 264 264
=========================================
Files 275 275
Lines 13658 13658
Branches 1750 1750
=========================================
Hits 8178 8178
Misses 4777 4777
Partials 703 703
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1795?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1795?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [916f81a...e135dc7](https://codecov.io/gh/apache/incubator-kyuubi/pull/1795?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] pan3793 closed pull request #1795: [KYUUBI #1787] Export FLINK_ENGINE_HOME in load-kyuubi-env script
Posted by GitBox <gi...@apache.org>.
pan3793 closed pull request #1795:
URL: https://github.com/apache/incubator-kyuubi/pull/1795
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org