[GitHub] tinkerpop pull request #548: TINKERPOP-1589 Re-introduced CloseableIterator

[okram <gi...@git.apache.org>]

Github user okram commented on a diff in the pull request:

    https://github.com/apache/tinkerpop/pull/548#discussion_r98931140
  
    --- Diff: gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/process/traversal/step/map/GraphStep.java ---
    @@ -164,13 +164,13 @@ public int hashCode() {
         }
     
         /**
    -     * Attemps to close an underlying iterator if it is of type {@link CloseableIterator}. Graph providers may choose
    +     * Attempts to close an underlying iterator if it is of type {@link CloseableIterator}. Graph providers may choose
          * to return this interface containing their vertices and edges if there are expensive resources that might need to
          * be released at some point.
          */
         @Override
         public void close() throws Exception {
    -        if (iterator != null && iterator instanceof CloseableIterator) {
    --- End diff --
    
    Why doesn't `GraphStep` implement `AutoCloseable` like the others?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---