You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tika.apache.org by ta...@apache.org on 2022/09/14 16:31:24 UTC

[tika] branch main updated: TIKA-3852 use getSignatureDictionaries instead of getSignatures; fix log4j2.xml configuration to avoid logging to files

This is an automated email from the ASF dual-hosted git repository.

tallison pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/tika.git


The following commit(s) were added to refs/heads/main by this push:
     new e35280dd9 TIKA-3852 use getSignatureDictionaries instead of getSignatures; fix log4j2.xml configuration to avoid logging to files
e35280dd9 is described below

commit e35280dd976cf354b188c73e1024f4702c45dbd7
Author: tallison <ta...@apache.org>
AuthorDate: Wed Sep 14 12:31:17 2022 -0400

    TIKA-3852 use getSignatureDictionaries instead of getSignatures; fix log4j2.xml configuration to avoid logging to files
---
 .../src/main/java/org/apache/tika/parser/pdf/PDFParser.java          | 3 +--
 .../tika-parser-pdf-module/src/test/resources/log4j2.xml             | 5 ++---
 2 files changed, 3 insertions(+), 5 deletions(-)

diff --git a/tika-parsers/tika-parsers-standard/tika-parsers-standard-modules/tika-parser-pdf-module/src/main/java/org/apache/tika/parser/pdf/PDFParser.java b/tika-parsers/tika-parsers-standard/tika-parsers-standard-modules/tika-parser-pdf-module/src/main/java/org/apache/tika/parser/pdf/PDFParser.java
index 94afd30db..6a2d1ee51 100644
--- a/tika-parsers/tika-parsers-standard/tika-parsers-standard-modules/tika-parser-pdf-module/src/main/java/org/apache/tika/parser/pdf/PDFParser.java
+++ b/tika-parsers/tika-parsers-standard/tika-parsers-standard-modules/tika-parser-pdf-module/src/main/java/org/apache/tika/parser/pdf/PDFParser.java
@@ -224,8 +224,7 @@ public class PDFParser extends AbstractParser implements RenderingParser, Initia
     private void extractSignatures(PDDocument pdfDocument, Metadata metadata) {
         boolean hasSignature = false;
         try {
-            for (PDSignatureField signatureField : pdfDocument.getSignatureFields()) {
-                PDSignature signature = signatureField.getSignature();
+            for (PDSignature signature : pdfDocument.getSignatureDictionaries()) {
                 if (signature == null) {
                     continue;
                 }
diff --git a/tika-parsers/tika-parsers-standard/tika-parsers-standard-modules/tika-parser-pdf-module/src/test/resources/log4j2.xml b/tika-parsers/tika-parsers-standard/tika-parsers-standard-modules/tika-parser-pdf-module/src/test/resources/log4j2.xml
index 6f4371a49..1bee4ef28 100644
--- a/tika-parsers/tika-parsers-standard/tika-parsers-standard-modules/tika-parser-pdf-module/src/test/resources/log4j2.xml
+++ b/tika-parsers/tika-parsers-standard/tika-parsers-standard-modules/tika-parser-pdf-module/src/test/resources/log4j2.xml
@@ -23,10 +23,9 @@
     <Console name="Console" target="SYSTEM_ERR">
       <PatternLayout pattern="%-5p [%t] %d{HH:mm:ss,SSS} %c %m%n"/>
     </Console>
-
-    <File name="pdfbox-appender" fileName="logs/pdfbox-${sys:pipesClientId}.log">
+    <Console name="pdfbox-appender" target="SYSTEM_ERR">
       <PatternLayout pattern="%-5p [%t] %d{HH:mm:ss,SSS} %c %m%n"/>
-    </File>
+    </Console>
   </Appenders>
   <Loggers>
     <Root level="info">