You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@uniffle.apache.org by "zuston (via GitHub)" <gi...@apache.org> on 2023/02/27 08:45:27 UTC
[GitHub] [incubator-uniffle] zuston opened a new pull request, #666: [#665] feat(client): keep consistent with vanilla spark when key or value is null
zuston opened a new pull request, #666:
URL: https://github.com/apache/incubator-uniffle/pull/666
### What changes were proposed in this pull request?
keep consistent with vanilla spark when key or value is null
### Why are the changes needed?
Fix: #665
The PR of https://github.com/apache/incubator-uniffle/pull/296 has fixed the bug of NPE of value. But in some cases of production, the key also could be null. So this corner case also should keep consistent with vanilla spark.
And to prevent this logic reverting, the corresponding tests have been attached.
### Does this PR introduce _any_ user-facing change?
No.
### How was this patch tested?
1. Unit tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
[GitHub] [incubator-uniffle] zuston commented on pull request #666: [#665] fix(client): keep consistent with vanilla spark when key or value is null
Posted by "zuston (via GitHub)" <gi...@apache.org>.
zuston commented on PR #666:
URL: https://github.com/apache/incubator-uniffle/pull/666#issuecomment-1445977930
> > Directly push or submit PR?
>
> If there is no conflict, it's ok to push directly.
Got it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
[GitHub] [incubator-uniffle] jerqi commented on pull request #666: [#665] fix(client): keep consistent with vanilla spark when key or value is null
Posted by "jerqi (via GitHub)" <gi...@apache.org>.
jerqi commented on PR #666:
URL: https://github.com/apache/incubator-uniffle/pull/666#issuecomment-1445972799
> > LGTM, thanks @zuston , This should be a fix. We should cherry-pick and commit to branch 0.7.
>
> Yes. How to cherry pick in github web?
You can use git client in your local machine.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
[GitHub] [incubator-uniffle] zuston commented on pull request #666: [#665] fix(client): keep consistent with vanilla spark when key or value is null
Posted by "zuston (via GitHub)" <gi...@apache.org>.
zuston commented on PR #666:
URL: https://github.com/apache/incubator-uniffle/pull/666#issuecomment-1445968907
> LGTM, thanks @zuston , This should be a fix. We should cherry-pick and commit to branch 0.7.
Yes. How to cherry pick in github web?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
[GitHub] [incubator-uniffle] zuston merged pull request #666: [#665] fix(client): keep consistent with vanilla spark when key or value is null
Posted by "zuston (via GitHub)" <gi...@apache.org>.
zuston merged PR #666:
URL: https://github.com/apache/incubator-uniffle/pull/666
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
[GitHub] [incubator-uniffle] zuston commented on pull request #666: [#665] fix(client): keep consistent with vanilla spark when key or value is null
Posted by "zuston (via GitHub)" <gi...@apache.org>.
zuston commented on PR #666:
URL: https://github.com/apache/incubator-uniffle/pull/666#issuecomment-1445974681
Directly push or submit PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
[GitHub] [incubator-uniffle] jerqi commented on pull request #666: [#665] fix(client): keep consistent with vanilla spark when key or value is null
Posted by "jerqi (via GitHub)" <gi...@apache.org>.
jerqi commented on PR #666:
URL: https://github.com/apache/incubator-uniffle/pull/666#issuecomment-1445976784
> Directly push or submit PR?
If there is no conflict, it's ok to push directly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org