You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/10/05 09:45:24 UTC

[GitHub] [airflow] potiuk commented on pull request #11276: Switched to Run Checks for Building Images.

potiuk commented on pull request #11276:
URL: https://github.com/apache/airflow/pull/11276#issuecomment-703523707


   > @potiuk This is better than it was, certainly, but a question: Is it possible to have the build image workflow run against _the actual PR_ as a second workflow, as we do with the "Up to Date" check, WIP, or the CodeQL? I.e. what is special about the Build Image workflow that means it has to be against master, not the PR?
   
   It runs as 'workflow_run' which is the only way to get "write" permission that allows to push the build image to the registry. There is no other way to do it. 
   
   > 
   > ("I didn't have time to look" is of course a perfectly acceptable answer, just catching up here as this build feature was added when I was off on paterntiy leave and don't want to duplicate any effort)
   
   Sure :) I woudl be more than happy that more people get to know the build process. 
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org