You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@uniffle.apache.org by "jerqi (via GitHub)" <gi...@apache.org> on 2025/09/17 07:46:10 UTC
[PR] Remove protected branch [uniffle]
jerqi opened a new pull request, #2615:
URL: https://github.com/apache/uniffle/pull/2615
### What changes were proposed in this pull request?
Remove protected branch
### Why are the changes needed?
Just a minor.
### Does this PR introduce _any_ user-facing change?
No.
### How was this patch tested?
No need.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
Re: [PR] Remove protected branch [uniffle]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #2615:
URL: https://github.com/apache/uniffle/pull/2615#issuecomment-3301958228
## Test Results
3 120 files ±0 3 120 suites ±0 6h 48m 43s ⏱️ - 1m 9s
1 201 tests ±0 1 199 ✅ - 1 1 💤 ±0 0 ❌ ±0 1 🔥 +1
15 211 runs ±0 15 194 ✅ - 2 15 💤 ±0 0 ❌ ±0 2 🔥 +2
For more details on these errors, see [this check](https://github.com/apache/uniffle/runs/50570547773).
Results for commit 0f69fe10. ± Comparison against base commit 1a46e2d0.
[test-results]:data:application/gzip;base64,H4sIAPRzymgC/03MTQ7CIBCG4as0rF3MDKDiZQxFSIj9MRRWjXd32hTs8ntm8q4ixMEv4tFJJLh0Yikxn/erJJvjPLGQ0iSZ+J63D37AOp9LcW4zNOZv7/jZrEGwcWCABj6lOR0vqUx7VRPW2aoajWp2VHWFU3XfNUoMbh7HmHkICFcTPEK4a7wBSoWyd0pbZQB7RQaVBW+oF98fVlXe9hQBAAA=
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
Re: [PR] Remove protected branch [uniffle]
Posted by "zuston (via GitHub)" <gi...@apache.org>.
zuston commented on code in PR #2615:
URL: https://github.com/apache/uniffle/pull/2615#discussion_r2354645863
##########
.asf.yaml:
##########
@@ -46,13 +46,7 @@ github:
squash: true
merge: false
rebase: false
- protected_branches:
- master:
- required_status_checks:
- strict: true
- required_pull_request_reviews:
- dismiss_stale_reviews: true
- required_approving_review_count: 1
+
Review Comment:
Can we only allow specified user to push into master branch directly ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
Re: [PR] Remove protected branch [uniffle]
Posted by "jerqi (via GitHub)" <gi...@apache.org>.
jerqi merged PR #2615:
URL: https://github.com/apache/uniffle/pull/2615
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
Re: [PR] Remove protected branch [uniffle]
Posted by "jerqi (via GitHub)" <gi...@apache.org>.
jerqi commented on code in PR #2615:
URL: https://github.com/apache/uniffle/pull/2615#discussion_r2354650100
##########
.asf.yaml:
##########
@@ -46,13 +46,7 @@ github:
squash: true
merge: false
rebase: false
- protected_branches:
- master:
- required_status_checks:
- strict: true
- required_pull_request_reviews:
- dismiss_stale_reviews: true
- required_approving_review_count: 1
+
Review Comment:
If we enable this, we can't push directly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org