You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2021/06/27 05:04:41 UTC

[GitHub] [shardingsphere] sandynz opened a new issue #11033: Add unit test for ProcessRegistrySubscriber

sandynz opened a new issue #11033:
URL: https://github.com/apache/shardingsphere/issues/11033


   Hi community,
   
   This issue is for #10887.
   
   ### Aim
   Add unit test for `ProcessRegistrySubscriber` to test its public functions.
   
   ### Basic Qualifications
       * Java
       * Maven
       * Junit.Test
   
   ### Example FYI
       * `RegistryCenterTest`
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] terrymanu closed issue #11033: Add unit test for ProcessRegistrySubscriber

Posted by GitBox <gi...@apache.org>.
terrymanu closed issue #11033:
URL: https://github.com/apache/shardingsphere/issues/11033


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] tanu02 commented on issue #11033: Add unit test for ProcessRegistrySubscriber

Posted by GitBox <gi...@apache.org>.
tanu02 commented on issue #11033:
URL: https://github.com/apache/shardingsphere/issues/11033#issuecomment-883398827


   Thank you @tristaZero 
   Could you please review the PR: https://github.com/apache/shardingsphere/pull/11419


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] tristaZero commented on issue #11033: Add unit test for ProcessRegistrySubscriber

Posted by GitBox <gi...@apache.org>.
tristaZero commented on issue #11033:
URL: https://github.com/apache/shardingsphere/issues/11033#issuecomment-882948912


   Sure @tanu02 Welcome. ;-)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] tanu02 commented on issue #11033: Add unit test for ProcessRegistrySubscriber

Posted by GitBox <gi...@apache.org>.
tanu02 commented on issue #11033:
URL: https://github.com/apache/shardingsphere/issues/11033#issuecomment-882774009


   Hi Team 
   Can I assign this to myself?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] tristaZero commented on issue #11033: Add unit test for ProcessRegistrySubscriber

Posted by GitBox <gi...@apache.org>.
tristaZero commented on issue #11033:
URL: https://github.com/apache/shardingsphere/issues/11033#issuecomment-882948912


   Sure @tanu02 Welcome. ;-)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] tristaZero commented on issue #11033: Add unit test for ProcessRegistrySubscriber

Posted by GitBox <gi...@apache.org>.
tristaZero commented on issue #11033:
URL: https://github.com/apache/shardingsphere/issues/11033#issuecomment-882948912


   Sure @tanu02 Welcome. ;-)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] sandynz commented on issue #11033: Add unit test for ProcessRegistrySubscriber

Posted by GitBox <gi...@apache.org>.
sandynz commented on issue #11033:
URL: https://github.com/apache/shardingsphere/issues/11033#issuecomment-883789222


   Hi @tanu02 , seems CI is not enabled currently, you could run `./mvnw -T 1C clean install` on local for now, make sure it can be compiled and tested successfully.
   For more details, see [Code of Conduct](https://shardingsphere.apache.org/community/en/contribute/code-conduct/).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] tanu02 commented on issue #11033: Add unit test for ProcessRegistrySubscriber

Posted by GitBox <gi...@apache.org>.
tanu02 commented on issue #11033:
URL: https://github.com/apache/shardingsphere/issues/11033#issuecomment-883990776


   Got it. Seems like I had to add licence declaration in the file.  
   Thank you!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] tanu02 commented on issue #11033: Add unit test for ProcessRegistrySubscriber

Posted by GitBox <gi...@apache.org>.
tanu02 commented on issue #11033:
URL: https://github.com/apache/shardingsphere/issues/11033#issuecomment-884026328


   It is getting built on my local succesfully.  
   https://github.com/apache/shardingsphere/pull/11419
   Please review the PR.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] tanu02 commented on issue #11033: Add unit test for ProcessRegistrySubscriber

Posted by GitBox <gi...@apache.org>.
tanu02 commented on issue #11033:
URL: https://github.com/apache/shardingsphere/issues/11033#issuecomment-882774009


   Hi Team 
   Can I assign this to myself?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] tanu02 commented on issue #11033: Add unit test for ProcessRegistrySubscriber

Posted by GitBox <gi...@apache.org>.
tanu02 commented on issue #11033:
URL: https://github.com/apache/shardingsphere/issues/11033#issuecomment-882774009


   Hi Team 
   Can I assign this to myself?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] tanu02 commented on issue #11033: Add unit test for ProcessRegistrySubscriber

Posted by GitBox <gi...@apache.org>.
tanu02 commented on issue #11033:
URL: https://github.com/apache/shardingsphere/issues/11033#issuecomment-883441379


   There seems to be some issue with the license. Has this ever occurred before? 
   https://travis-ci.org/github/apache/shardingsphere/builds/774675252


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org