You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@ambari.apache.org by John Speidel <js...@hortonworks.com> on 2015/02/02 22:52:02 UTC

Review Request 30528: Fix regression of new high level "add hosts" api

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30528/
-----------------------------------------------------------

Review request for Ambari, Robert Levas, Robert Nettleton, and Tom Beerbower.

Bugs: AMBARI-9367
https://issues.apache.org/jira/browse/AMBARI-9367

Repository: ambari

Description
-------

The new "add hosts" api is now completely broken and could return several errors to the user depending on the topology assigned to the hosts being added. This is a regression that was introduced in the patch for AMBARI-8868.
The root issue here is AMBARI-4782.
The patch for AMBARI-8868 attempted to resolve its issue without resolving the root problem and in doing so, broke this functionality.
To fix this issue correctly, the root issue AMBARI-4782 needs to be resolved. This will require coordination with the UI guys.

This patch is yet another hack to work around the root issue, AMBARI-4782.

Also, ensures that the kerberos client is installed to all hosts added to a kerberized cluster.

Diffs
-----

ambari-server/src/main/java/org/apache/ambari/server/controller/internal/HostComponentResourceProvider.java b1e05cc
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/HostResourceProvider.java b5d2d6d
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/HostComponentResourceProviderTest.java 337cc74

Diff: https://reviews.apache.org/r/30528/diff/

Testing
-------

Manual Functional testing:
Tested add hosts for both kerberized and non-kerberized clusters.

Unit Tests:
Updated existing unit tests.
All unit tests pass.

Thanks,

John Speidel

Re: Review Request 30528: Fix regression of new high level "add hosts" api

Posted by Robert Nettleton <rn...@hortonworks.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30528/#review70637
-----------------------------------------------------------

Ship it!


Ship It!

- Robert Nettleton


On Feb. 2, 2015, 9:52 p.m., John Speidel wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30528/
> -----------------------------------------------------------
> 
> (Updated Feb. 2, 2015, 9:52 p.m.)
> 
> 
> Review request for Ambari, Robert Levas, Robert Nettleton, and Tom Beerbower.
> 
> 
> Bugs: AMBARI-9367
>     https://issues.apache.org/jira/browse/AMBARI-9367
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> The new "add hosts" api is now completely broken and could return several errors to the user depending on the topology assigned to the hosts being added. This is a regression that was introduced in the patch for AMBARI-8868.
> The root issue here is AMBARI-4782.
> The patch for AMBARI-8868 attempted to resolve its issue without resolving the root problem and in doing so, broke this functionality.
> To fix this issue correctly, the root issue AMBARI-4782 needs to be resolved. This will require coordination with the UI guys.
> 
> This patch is yet another hack to work around the root issue, AMBARI-4782.
> 
> Also, ensures that the kerberos client is installed to all hosts added to a kerberized cluster.
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/HostComponentResourceProvider.java b1e05cc 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/HostResourceProvider.java b5d2d6d 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/internal/HostComponentResourceProviderTest.java 337cc74 
> 
> Diff: https://reviews.apache.org/r/30528/diff/
> 
> 
> Testing
> -------
> 
> Manual Functional testing:
> Tested add hosts for both kerberized and non-kerberized clusters.
> 
> Unit Tests:
> Updated existing unit tests.
> All unit tests pass.
> 
> 
> Thanks,
> 
> John Speidel
> 
>

Re: Review Request 30528: Fix regression of new high level "add hosts" api

Posted by Robert Levas <rl...@hortonworks.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30528/#review70641
-----------------------------------------------------------

Ship it!


Ship It!

- Robert Levas


On Feb. 2, 2015, 4:52 p.m., John Speidel wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30528/
> -----------------------------------------------------------
> 
> (Updated Feb. 2, 2015, 4:52 p.m.)
> 
> 
> Review request for Ambari, Robert Levas, Robert Nettleton, and Tom Beerbower.
> 
> 
> Bugs: AMBARI-9367
>     https://issues.apache.org/jira/browse/AMBARI-9367
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> The new "add hosts" api is now completely broken and could return several errors to the user depending on the topology assigned to the hosts being added. This is a regression that was introduced in the patch for AMBARI-8868.
> The root issue here is AMBARI-4782.
> The patch for AMBARI-8868 attempted to resolve its issue without resolving the root problem and in doing so, broke this functionality.
> To fix this issue correctly, the root issue AMBARI-4782 needs to be resolved. This will require coordination with the UI guys.
> 
> This patch is yet another hack to work around the root issue, AMBARI-4782.
> 
> Also, ensures that the kerberos client is installed to all hosts added to a kerberized cluster.
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/HostComponentResourceProvider.java b1e05cc 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/HostResourceProvider.java b5d2d6d 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/internal/HostComponentResourceProviderTest.java 337cc74 
> 
> Diff: https://reviews.apache.org/r/30528/diff/
> 
> 
> Testing
> -------
> 
> Manual Functional testing:
> Tested add hosts for both kerberized and non-kerberized clusters.
> 
> Unit Tests:
> Updated existing unit tests.
> All unit tests pass.
> 
> 
> Thanks,
> 
> John Speidel
> 
>

Re: Review Request 30528: Fix regression of new high level "add hosts" api

Posted by Tom Beerbower <tb...@hortonworks.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30528/#review70634
-----------------------------------------------------------

Ship it!


Ship It!

- Tom Beerbower


On Feb. 2, 2015, 9:52 p.m., John Speidel wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30528/
> -----------------------------------------------------------
> 
> (Updated Feb. 2, 2015, 9:52 p.m.)
> 
> 
> Review request for Ambari, Robert Levas, Robert Nettleton, and Tom Beerbower.
> 
> 
> Bugs: AMBARI-9367
>     https://issues.apache.org/jira/browse/AMBARI-9367
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> The new "add hosts" api is now completely broken and could return several errors to the user depending on the topology assigned to the hosts being added. This is a regression that was introduced in the patch for AMBARI-8868.
> The root issue here is AMBARI-4782.
> The patch for AMBARI-8868 attempted to resolve its issue without resolving the root problem and in doing so, broke this functionality.
> To fix this issue correctly, the root issue AMBARI-4782 needs to be resolved. This will require coordination with the UI guys.
> 
> This patch is yet another hack to work around the root issue, AMBARI-4782.
> 
> Also, ensures that the kerberos client is installed to all hosts added to a kerberized cluster.
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/HostComponentResourceProvider.java b1e05cc 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/HostResourceProvider.java b5d2d6d 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/internal/HostComponentResourceProviderTest.java 337cc74 
> 
> Diff: https://reviews.apache.org/r/30528/diff/
> 
> 
> Testing
> -------
> 
> Manual Functional testing:
> Tested add hosts for both kerberized and non-kerberized clusters.
> 
> Unit Tests:
> Updated existing unit tests.
> All unit tests pass.
> 
> 
> Thanks,
> 
> John Speidel
> 
>

Re: Review Request 30528: Fix regression of new high level "add hosts" api

Posted by John Speidel <js...@hortonworks.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30528/#review70649
-----------------------------------------------------------


Results :

Tests run: 2635, Failures: 0, Errors: 0, Skipped: 15
...
Total run:588
Total errors:0
Total failures:0

- John Speidel


On Feb. 2, 2015, 9:52 p.m., John Speidel wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30528/
> -----------------------------------------------------------
> 
> (Updated Feb. 2, 2015, 9:52 p.m.)
> 
> 
> Review request for Ambari, Robert Levas, Robert Nettleton, and Tom Beerbower.
> 
> 
> Bugs: AMBARI-9367
>     https://issues.apache.org/jira/browse/AMBARI-9367
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> The new "add hosts" api is now completely broken and could return several errors to the user depending on the topology assigned to the hosts being added. This is a regression that was introduced in the patch for AMBARI-8868.
> The root issue here is AMBARI-4782.
> The patch for AMBARI-8868 attempted to resolve its issue without resolving the root problem and in doing so, broke this functionality.
> To fix this issue correctly, the root issue AMBARI-4782 needs to be resolved. This will require coordination with the UI guys.
> 
> This patch is yet another hack to work around the root issue, AMBARI-4782.
> 
> Also, ensures that the kerberos client is installed to all hosts added to a kerberized cluster.
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/HostComponentResourceProvider.java b1e05cc 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/HostResourceProvider.java b5d2d6d 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/internal/HostComponentResourceProviderTest.java 337cc74 
> 
> Diff: https://reviews.apache.org/r/30528/diff/
> 
> 
> Testing
> -------
> 
> Manual Functional testing:
> Tested add hosts for both kerberized and non-kerberized clusters.
> 
> Unit Tests:
> Updated existing unit tests.
> All unit tests pass.
> 
> 
> Thanks,
> 
> John Speidel
> 
>