[GitHub] [arrow] kou commented on a diff in pull request #34512: GH-34543: [CI] Self-hosted ARM workflows improvements

["kou (via GitHub)" <gi...@apache.org>]

kou commented on code in PR #34512:
URL: https://github.com/apache/arrow/pull/34512#discussion_r1134579066


##########
.github/workflows/cpp.yml:
##########
@@ -55,22 +55,39 @@ env:
 jobs:
   docker:
     name: ${{ matrix.title }}
-    runs-on: ubuntu-latest
+    runs-on: ${{ matrix.runs-on }}
     if: ${{ !contains(github.event.pull_request.title, 'WIP') }}
     timeout-minutes: 75
     strategy:
       fail-fast: false
       matrix:
-        image:
-          - conda-cpp
-          - ubuntu-cpp-sanitizer
         include:
-          - image: conda-cpp
+          - arch: amd64
+            clang_tools: "14"

Review Comment:
   Could you use `-` not `_` for word separator for `matrix` parameter names like `ruins-on`?
   
   ```suggestion
               clang-tools: "14"
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org