You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@geode.apache.org by "kirklund (GitHub)" <gi...@apache.org> on 2019/01/25 20:51:50 UTC

[GitHub] [geode] kirklund opened pull request #3123: GEODE-6301: Use ThreadInfo.toString in ExecutorServiceRule.dumpThreads

ThreadInfo.toString contains all of the relevant monitor/synchronizer lock info that ExecutorServiceRule.dumpThreads needs so I removed customization of the dump and just use what ThreadInfo provides.

[ Full content available at: https://github.com/apache/geode/pull/3123 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] kirklund commented on pull request #3123: GEODE-6301: Use ThreadInfo.toString in ExecutorServiceRule.dumpThreads

Posted by "kirklund (GitHub)" <gi...@apache.org>.

Oops, I merged to develop before refreshing the page. I'll file another PR with removal of hard-coded inner-classes from the assertions. The only reason it's there is to assert that the class is in the thread stack.

[ Full content available at: https://github.com/apache/geode/pull/3123 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] kirklund closed pull request #3123: GEODE-6301: Use ThreadInfo.toString in ExecutorServiceRule.dumpThreads

Posted by "kirklund (GitHub)" <gi...@apache.org>.

[ pull request closed by kirklund ]

[ Full content available at: https://github.com/apache/geode/pull/3123 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] demery-pivotal commented on issue #3123: GEODE-6301: Use ThreadInfo.toString in ExecutorServiceRule.dumpThreads

Posted by "demery-pivotal (GitHub)" <gi...@apache.org>.

Wow! Those tests look very helpful!

[ Full content available at: https://github.com/apache/geode/pull/3123 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] demery-pivotal commented on pull request #3123: GEODE-6301: Use ThreadInfo.toString in ExecutorServiceRule.dumpThreads

Posted by "demery-pivotal (GitHub)" <gi...@apache.org>.

Is there something in this test that requires it to be a non-fair sync? If so, I'd like the test to indicate more clearly why it's non-fair. If this inner class name is just an implementation detail, consider ignoring the inner class name by comparing via regex.

Similar for other comparisons involving inner class names.

[ Full content available at: https://github.com/apache/geode/pull/3123 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org