You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "zhengruifeng (via GitHub)" <gi...@apache.org> on 2025/04/23 10:00:00 UTC
[PR] [SPARK-51877][PYTHON][CONNECT] Add functions 'chr', 'random' and 'uuid' [spark]
zhengruifeng opened a new pull request, #50678:
URL: https://github.com/apache/spark/pull/50678
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://spark.apache.org/contributing.html
2. Ensure you have added or run the appropriate tests for your PR: https://spark.apache.org/developer-tools.html
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][SPARK-XXXX] Your PR title ...'.
4. Be sure to keep the PR description updated to reflect all changes.
5. Please write your PR title to summarize what this PR proposes.
6. If possible, provide a concise example to reproduce the issue for a faster review.
7. If you want to add a new configuration, please read the guideline first for naming configurations in
'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
8. If you want to add or modify an error type or message, please read the guideline first in
'common/utils/src/main/resources/error/README.md'.
-->
### What changes were proposed in this pull request?
Add functions 'chr', 'random' and 'uuid'
### Why are the changes needed?
for feature parity between python and scala
### Does this PR introduce _any_ user-facing change?
yes, but the 3 functions can must explicitly imported. They will not be included in wildcard import `from pyspark.sql.functions import *` due to namespace conflicts.
### How was this patch tested?
new doctests and updated unittests
### Was this patch authored or co-authored using generative AI tooling?
no
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-51877][PYTHON][CONNECT] Add functions 'chr', 'random' and 'uuid' [spark]
Posted by "zhengruifeng (via GitHub)" <gi...@apache.org>.
zhengruifeng commented on code in PR #50678:
URL: https://github.com/apache/spark/pull/50678#discussion_r2055705281
##########
python/pyspark/sql/functions/__init__.py:
##########
@@ -98,6 +98,7 @@
"power",
"radians",
"rand",
+ # "random": Excluded because of the name conflict with builtin random module
Review Comment:
add note here to avoid being unintentionally added in the future
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-51877][PYTHON][CONNECT] Add functions 'chr', 'random' and 'uuid' [spark]
Posted by "zhengruifeng (via GitHub)" <gi...@apache.org>.
zhengruifeng closed pull request #50678: [SPARK-51877][PYTHON][CONNECT] Add functions 'chr', 'random' and 'uuid'
URL: https://github.com/apache/spark/pull/50678
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-51877][PYTHON][CONNECT] Add functions 'chr', 'random' and 'uuid' [spark]
Posted by "zhengruifeng (via GitHub)" <gi...@apache.org>.
zhengruifeng commented on PR #50678:
URL: https://github.com/apache/spark/pull/50678#issuecomment-2826474595
thanks, merged to master for 4.1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-51877][PYTHON][CONNECT] Add functions 'chr', 'random' and 'uuid' [spark]
Posted by "zhengruifeng (via GitHub)" <gi...@apache.org>.
zhengruifeng commented on code in PR #50678:
URL: https://github.com/apache/spark/pull/50678#discussion_r2055705281
##########
python/pyspark/sql/functions/__init__.py:
##########
@@ -98,6 +98,7 @@
"power",
"radians",
"rand",
+ # "random": Excluded because of the name conflict with builtin random module
Review Comment:
add note here to avoid unintentionally add in the future
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org