You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by "terrymanu (via GitHub)" <gi...@apache.org> on 2026/06/24 18:22:28 UTC

[PR] Harden authenticated GitHub evidence collection [shardingsphere]

terrymanu opened a new pull request, #38909:
URL: https://github.com/apache/shardingsphere/pull/38909

   (no comment)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Harden authenticated GitHub evidence collection [shardingsphere]

Posted by "terrymanu (via GitHub)" <gi...@apache.org>.
terrymanu merged PR #38909:
URL: https://github.com/apache/shardingsphere/pull/38909


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Harden authenticated GitHub evidence collection [shardingsphere]

Posted by "terrymanu (via GitHub)" <gi...@apache.org>.
terrymanu commented on PR #38909:
URL: https://github.com/apache/shardingsphere/pull/38909#issuecomment-4792438542

   ### Summary
   
   **Review Result: Mergeable**
   
   Reason: The PR is a narrow review-skill instruction update. It strengthens GitHub evidence collection without changing production code, tests, runtime behavior, public APIs, dependencies, or release artifacts.
   
   ### Evidence
   
   - `.codex/skills/review-pr/SKILL.md:133` adds a clear access strategy that tries available GitHub app/CLI/API evidence before treating public PR facts as unavailable.
   - `.codex/skills/review-pr/SKILL.md:142` adds credential-safety and pagination rules, including avoiding token exposure, fetching all pages, classifying endpoint access separately, and not converting secondary endpoint access failures into blockers unless the endpoint is required.
   - `.codex/skills/review-pr/SKILL.md:440` extends required review details so inaccessible relevant GitHub endpoints and their mergeability impact are recorded.
   - The REST guidance is consistent with GitHub’s official documentation for `Authorization: Bearer` authentication and REST pagination via `link` headers:
     - https://docs.github.com/en/rest/authentication/authenticating-to-the-rest-api
     - https://docs.github.com/en/rest/using-the-rest-api/using-pagination-in-the-rest-api
   - No linked issue, PR comments, review comments, or prior review rounds were present, so there are no unresolved public feedback items to compare.
   - Latest available check runs for `cc1e9b955815ef58662d516fca308c5cce7bc51f` were successful: CheckStyle, License, Spotless, and init-environment.
   
   ### Review Details
   
   - Reviewed Scope: `.codex/skills/review-pr/SKILL.md`; latest PR head `cc1e9b955815ef58662d516fca308c5cce7bc51f`; base/merge-base `aa5ad5e14c523b10599e5cb36880de84254c6e7a`; local triple-dot file list matched GitHub `/pulls/38909/files`.
   - Not Reviewed Scope: production modules, tests, SQL parser/protocol/runtime paths, dependencies, packaging, and distribution artifacts, because the PR does not touch them.
   - Verification:
     - GitHub PR metadata, files, commits, comments, reviews, review comments, and latest commit checks were queried successfully; no relevant endpoint was inaccessible.
     - `git fetch apache master refs/pull/38909/head:refs/remotes/apache/pr/38909` exited 0.
     - `git diff --name-status aa5ad5e14c523b10599e5cb36880de84254c6e7a..apache/pr/38909` exited 0 and matched GitHub’s changed-file list.
     - `python3 .codex/skills/review-pr/scripts/build_review_inventory.py --base-ref aa5ad5e14c523b10599e5cb36880de84254c6e7a --head-ref apache/pr/38909 --github-files <github-file-list> --format markdown` exited 0.
     - `git diff --check aa5ad5e14c523b10599e5cb36880de84254c6e7a..apache/pr/38909 -- .codex/skills/review-pr/SKILL.md` exited 0.
   - Release Note / User Docs: Not required; this is an internal Codex review-skill instruction update with no user-facing ShardingSphere runtime behavior or configuration change.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org