You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/08/14 15:23:13 UTC
[GitHub] [airflow] potiuk commented on a change in pull request #10329: More fancy environment checking
potiuk commented on a change in pull request #10329:
URL: https://github.com/apache/airflow/pull/10329#discussion_r470692592
##########
File path: scripts/ci/in_container/check_environment.sh
##########
@@ -131,34 +119,21 @@ function resetdb_if_requested() {
return $?
}
-if [[ -n ${BACKEND:=} ]]; then
- echo "==============================================================================================="
- echo " Checking backend: ${BACKEND}"
- echo "==============================================================================================="
- set +e
+echo "==============================================================================================="
+echo " Checking integrations and backends"
+echo "==============================================================================================="
+if [[ -n ${BACKEND:=} ]]; then
Review comment:
set +e / -e should be around that - check_db_connection exits with '1" in case of error.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org