[GitHub] [incubator-superset] bkyryliuk commented on a change in pull request #9444: Implement dttm column configuration through db extra config

[GitBox <gi...@apache.org>]

bkyryliuk commented on a change in pull request #9444: Implement dttm column configuration through db extra config
URL: https://github.com/apache/incubator-superset/pull/9444#discussion_r403169620
 
 

 ##########
 File path: docs/installation.rst
 ##########
 @@ -1379,8 +1379,14 @@ Prior to SIP-15 SQLAlchemy used inclusive endpoints however these may behave lik
 To remedy this rather than having to define the date/time format for every non-IS0 8601 date-time column, once can define a default column mapping on a per database level via the ``extra`` parameter ::
 
     {
+        "main_dttm_column": "ds",
+        "default_dttm_column_names": ["ds", "hour_ts"],
         "python_date_format_by_column_name": {
-            "ds": "%Y-%m-%d"
+            "ds": "%Y-%m-%d",
+            "hour_ts": "epoch_s",
+        }
+        "expression_by_column_name": {
+            "hour_ts": "CAST(hour_ts as INTEGER)",
 
 Review comment:
   @john-bodley we actually use both of them in combination - this is a real example from our setup.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org