You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@kie.apache.org by "jstastny-cz (via GitHub)" <gi...@apache.org> on 2026/02/24 08:44:21 UTC

[PR] NO-ISSUE: workaround buildchain jenkinsfile reference to GITHUB_WORKSPACE [incubator-kie-kogito-pipelines]

jstastny-cz opened a new pull request, #1296:
URL: https://github.com/apache/incubator-kie-kogito-pipelines/pull/1296

   In attempt to reduce size of logs, the applicable build-chain config was adjusted to write mvn dependency:tree verbose output into a file inside workspace. The primary focus was GitHub PR checks, so the destination is now defined as env.GITHUB_WORKSPACE.
   
   While this fits GitHub actions, obviously there's problem in jenkins, where the same build-chain configuration file is shared by the nightly jobs.
   There were two options:
   1. refactor the build-chain configuration to use a different env variable, which then would need to be explicitly set in all the workflows (quite many all around the repos).
   2. adjust Jenkinsfile that uses the shared build-chain configuration to "fake" env.GITHUB_WORKSPACE while providing explanation in a comment. Which isolates the change to a single Jenkinsfile.
   
   The PR here implements option 2 from the above.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org

Re: [PR] NO-ISSUE: workaround buildchain jenkinsfile reference to GITHUB_WORKSPACE [incubator-kie-kogito-pipelines]

Posted by "jstastny-cz (via GitHub)" <gi...@apache.org>.
jstastny-cz commented on code in PR #1296:
URL: https://github.com/apache/incubator-kie-kogito-pipelines/pull/1296#discussion_r2845467389


##########
dsl/seed/jenkinsfiles/Jenkinsfile.buildchain:
##########
@@ -57,6 +57,10 @@ pipeline {
         timestamps()
         timeout(time: timeoutValue, unit: 'MINUTES')
     }
+    environment {
+        GITHUB_WORKSPACE = "${WORKSPACE}" // faking GITHUB_WORKSPACE env var for the build-chain config mvn dependency:tree output
+        DEPENDENCY_TREE_FILE = "mvn_dependency_tree.txt"

Review Comment:
   You also used `-DappendOutput=true` , so it should not be problem during individual configuration's execution. And even if there's a matrix job in Jenkins (which I don't think there is such), each workspace is isolated in Jenkins. Perhaps not in GitHub action and that's why you introduced the distinction?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org

Re: [PR] NO-ISSUE: workaround buildchain jenkinsfile reference to GITHUB_WORKSPACE [incubator-kie-kogito-pipelines]

Posted by "domhanak (via GitHub)" <gi...@apache.org>.
domhanak merged PR #1296:
URL: https://github.com/apache/incubator-kie-kogito-pipelines/pull/1296


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org

Re: [PR] NO-ISSUE: workaround buildchain jenkinsfile reference to GITHUB_WORKSPACE [incubator-kie-kogito-pipelines]

Posted by "gitgabrio (via GitHub)" <gi...@apache.org>.
gitgabrio commented on code in PR #1296:
URL: https://github.com/apache/incubator-kie-kogito-pipelines/pull/1296#discussion_r2845457856


##########
dsl/seed/jenkinsfiles/Jenkinsfile.buildchain:
##########
@@ -57,6 +57,10 @@ pipeline {
         timestamps()
         timeout(time: timeoutValue, unit: 'MINUTES')
     }
+    environment {
+        GITHUB_WORKSPACE = "${WORKSPACE}" // faking GITHUB_WORKSPACE env var for the build-chain config mvn dependency:tree output
+        DEPENDENCY_TREE_FILE = "mvn_dependency_tree.txt"

Review Comment:
   HI @jstastny-cz 
   Many thanks for the quick fix.
   My only doubt is that, in my original PRs, I had to create different "names" to avoid clashing:
   is there a way to check that for this PR ?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org

Re: [PR] NO-ISSUE: workaround buildchain jenkinsfile reference to GITHUB_WORKSPACE [incubator-kie-kogito-pipelines]

Posted by "gitgabrio (via GitHub)" <gi...@apache.org>.
gitgabrio commented on code in PR #1296:
URL: https://github.com/apache/incubator-kie-kogito-pipelines/pull/1296#discussion_r2846035787


##########
dsl/seed/jenkinsfiles/Jenkinsfile.buildchain:
##########
@@ -57,6 +57,10 @@ pipeline {
         timestamps()
         timeout(time: timeoutValue, unit: 'MINUTES')
     }
+    environment {
+        GITHUB_WORKSPACE = "${WORKSPACE}" // faking GITHUB_WORKSPACE env var for the build-chain config mvn dependency:tree output
+        DEPENDENCY_TREE_FILE = "mvn_dependency_tree.txt"

Review Comment:
   Yup, exactly.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org