[GitHub] [shardingsphere] tristaZero commented on a change in pull request #9149: Test Calcite doing query across single and sharding tables.

[GitBox <gi...@apache.org>]

tristaZero commented on a change in pull request #9149:
URL: https://github.com/apache/shardingsphere/pull/9149#discussion_r563487289



##########
File path: shardingsphere-jdbc/shardingsphere-jdbc-core/src/test/resources/sql/calcite_data_1.sql
##########
@@ -16,8 +16,15 @@
  */
 
 DELETE FROM t_order_item_calcite;
+DELETE FROM t_order_item_calcite_sharding_0;
+ DELETE FROM t_order_item_calcite_sharding_1;

Review comment:
       Please remove the first blank space.

##########
File path: shardingsphere-jdbc/shardingsphere-jdbc-core/src/test/resources/sql/jdbc_init_calcite_1.sql
##########
@@ -16,3 +16,5 @@
  */
 
 CREATE TABLE IF NOT EXISTS t_order_item_calcite (item_id INT NOT NULL, order_id INT NOT NULL, user_id INT NOT NULL, status VARCHAR(45) NULL, PRIMARY KEY (item_id));
+CREATE TABLE IF NOT EXISTS t_order_item_calcite_sharding_0 (item_id INT NOT NULL, order_id INT NOT NULL, user_id INT NOT NULL, status VARCHAR(45) NULL, remarks VARCHAR(45) NULL, PRIMARY KEY (item_id));
+ CREATE TABLE IF NOT EXISTS t_order_item_calcite_sharding_1 (item_id INT NOT NULL, order_id INT NOT NULL, user_id INT NOT NULL, status VARCHAR(45) NULL, remarks VARCHAR(45) NULL, PRIMARY KEY (item_id));

Review comment:
       Please remove the first blank space.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org