You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@phoenix.apache.org by la...@apache.org on 2019/06/23 21:08:40 UTC

[phoenix] branch 4.x-HBase-1.4 updated: PHOENIX-5365 IndexToolIT tests run multable times.

This is an automated email from the ASF dual-hosted git repository.

larsh pushed a commit to branch 4.x-HBase-1.4
in repository https://gitbox.apache.org/repos/asf/phoenix.git


The following commit(s) were added to refs/heads/4.x-HBase-1.4 by this push:
     new 4503dd6  PHOENIX-5365 IndexToolIT tests run multable times.
4503dd6 is described below

commit 4503dd69a8edd5f26468ed8ac685f1e5cdcbdbef
Author: Lars Hofhansl <la...@apache.org>
AuthorDate: Sun Jun 23 14:09:07 2019 -0700

    PHOENIX-5365 IndexToolIT tests run multable times.
---
 .../src/it/java/org/apache/phoenix/end2end/IndexToolIT.java         | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/phoenix-core/src/it/java/org/apache/phoenix/end2end/IndexToolIT.java b/phoenix-core/src/it/java/org/apache/phoenix/end2end/IndexToolIT.java
index 3b1dc51..c4bdf47 100644
--- a/phoenix-core/src/it/java/org/apache/phoenix/end2end/IndexToolIT.java
+++ b/phoenix-core/src/it/java/org/apache/phoenix/end2end/IndexToolIT.java
@@ -79,6 +79,7 @@ import com.google.common.collect.Maps;
 public class IndexToolIT extends BaseUniqueNamesOwnClusterIT {
 
     private final boolean localIndex;
+    private final boolean mutable;
     private final boolean transactional;
     private final boolean directApi;
     private final String tableDDLOptions;
@@ -88,6 +89,7 @@ public class IndexToolIT extends BaseUniqueNamesOwnClusterIT {
     public IndexToolIT(String transactionProvider, boolean mutable, boolean localIndex,
             boolean directApi, boolean useSnapshot, boolean useTenantId) {
         this.localIndex = localIndex;
+        this.mutable = mutable;
         this.transactional = transactionProvider != null;
         this.directApi = directApi;
         this.useSnapshot = useSnapshot;
@@ -330,6 +332,8 @@ public class IndexToolIT extends BaseUniqueNamesOwnClusterIT {
 
     @Test
     public void testSaltedVariableLengthPK() throws Exception {
+        if (!mutable) return;
+        if (transactional) return;
         String schemaName = generateUniqueName();
         String dataTableName = generateUniqueName();
         String dataTableFullName = SchemaUtil.getTableName(schemaName, dataTableName);
@@ -374,6 +378,8 @@ public class IndexToolIT extends BaseUniqueNamesOwnClusterIT {
     @Test
     public void testSplitIndex() throws Exception {
         if (localIndex) return; // can't split local indexes
+        if (!mutable) return;
+        if (transactional) return;
         String schemaName = generateUniqueName();
         String dataTableName = generateUniqueName();
         String dataTableFullName = SchemaUtil.getTableName(schemaName, dataTableName);