You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Meng Zhu <mz...@mesosphere.io> on 2019/02/27 18:15:08 UTC
Review Request 70067: Added star operator for `Result`,
`Try` and `Option`.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70067/
-----------------------------------------------------------
Review request for mesos and Benjamin Mahler.
Repository: mesos
Description
-------
Added star operator for `Result`, `Try` and `Option`.
Diffs
-----
3rdparty/stout/include/stout/option.hpp 8feed012a55fed6eab89c883958324f3345e46e9
3rdparty/stout/include/stout/result.hpp c1387ae957edffc31250b9b236b5f1fd8ff0acd3
3rdparty/stout/include/stout/try.hpp 30cce7e27fa040d0ce5a86efc4820f8c39178444
3rdparty/stout/tests/option_tests.cpp 815d40e0bf342998634dc69a1719c3f717c7202c
3rdparty/stout/tests/result_tests.cpp 1750e6b4a90afec3b7de0621779f8b69a856da41
3rdparty/stout/tests/try_tests.cpp 99b7b2a3f968abb87549fb9075d65bc5bcc827f1
Diff: https://reviews.apache.org/r/70067/diff/1/
Testing
-------
make check
Thanks,
Meng Zhu
Re: Review Request 70067: Added star operator for `Result`,
`Try` and `Option`.
Posted by Meng Zhu <mz...@mesosphere.io>.
> On March 4, 2019, 4:45 a.m., Benjamin Bannier wrote:
> > 3rdparty/stout/include/stout/option.hpp
> > Lines 129-130 (patched)
> > <https://reviews.apache.org/r/70067/diff/3/?file=2127549#file2127549line129>
> >
> > Not sure this comment adds much value since it just restates what is already in code.
Removed. Ditto below.
- Meng
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70067/#review213393
-----------------------------------------------------------
On March 4, 2019, 2:50 p.m., Meng Zhu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70067/
> -----------------------------------------------------------
>
> (Updated March 4, 2019, 2:50 p.m.)
>
>
> Review request for mesos, Benjamin Bannier and Benjamin Mahler.
>
>
> Bugs: MESOS-7124
> https://issues.apache.org/jira/browse/MESOS-7124
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added star operator for `Result`, `Try` and `Option`.
>
>
> Diffs
> -----
>
> 3rdparty/stout/include/stout/option.hpp 8feed012a55fed6eab89c883958324f3345e46e9
> 3rdparty/stout/include/stout/result.hpp c1387ae957edffc31250b9b236b5f1fd8ff0acd3
> 3rdparty/stout/include/stout/try.hpp 30cce7e27fa040d0ce5a86efc4820f8c39178444
> 3rdparty/stout/tests/option_tests.cpp 815d40e0bf342998634dc69a1719c3f717c7202c
> 3rdparty/stout/tests/result_tests.cpp 1750e6b4a90afec3b7de0621779f8b69a856da41
> 3rdparty/stout/tests/try_tests.cpp 99b7b2a3f968abb87549fb9075d65bc5bcc827f1
>
>
> Diff: https://reviews.apache.org/r/70067/diff/4/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Meng Zhu
>
>
Re: Review Request 70067: Added star operator for `Result`,
`Try` and `Option`.
Posted by Benjamin Bannier <be...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70067/#review213393
-----------------------------------------------------------
3rdparty/stout/include/stout/option.hpp
Lines 129-130 (patched)
<https://reviews.apache.org/r/70067/#comment299332>
Not sure this comment adds much value since it just restates what is already in code.
3rdparty/stout/include/stout/option.hpp
Lines 131-132 (patched)
<https://reviews.apache.org/r/70067/#comment299331>
Needs `#include <utility>`.
3rdparty/stout/include/stout/try.hpp
Lines 84-85 (patched)
<https://reviews.apache.org/r/70067/#comment299333>
Not sure this comment adds much value since it just restates what is already in code.
3rdparty/stout/include/stout/try.hpp
Lines 86-87 (patched)
<https://reviews.apache.org/r/70067/#comment299334>
Needs `#include <utility>`.
3rdparty/stout/tests/option_tests.cpp
Lines 137 (patched)
<https://reviews.apache.org/r/70067/#comment299336>
Needs `#include <utility>`.
3rdparty/stout/tests/try_tests.cpp
Lines 37 (patched)
<https://reviews.apache.org/r/70067/#comment299335>
Needs `#include <utility>`.
- Benjamin Bannier
On Feb. 27, 2019, 7:15 p.m., Meng Zhu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70067/
> -----------------------------------------------------------
>
> (Updated Feb. 27, 2019, 7:15 p.m.)
>
>
> Review request for mesos, Benjamin Bannier and Benjamin Mahler.
>
>
> Bugs: MESOS-7124
> https://issues.apache.org/jira/browse/MESOS-7124
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added star operator for `Result`, `Try` and `Option`.
>
>
> Diffs
> -----
>
> 3rdparty/stout/include/stout/option.hpp 8feed012a55fed6eab89c883958324f3345e46e9
> 3rdparty/stout/include/stout/result.hpp c1387ae957edffc31250b9b236b5f1fd8ff0acd3
> 3rdparty/stout/include/stout/try.hpp 30cce7e27fa040d0ce5a86efc4820f8c39178444
> 3rdparty/stout/tests/option_tests.cpp 815d40e0bf342998634dc69a1719c3f717c7202c
> 3rdparty/stout/tests/result_tests.cpp 1750e6b4a90afec3b7de0621779f8b69a856da41
> 3rdparty/stout/tests/try_tests.cpp 99b7b2a3f968abb87549fb9075d65bc5bcc827f1
>
>
> Diff: https://reviews.apache.org/r/70067/diff/3/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Meng Zhu
>
>
Re: Review Request 70067: Added star operator for `Result`,
`Try` and `Option`.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70067/#review213268
-----------------------------------------------------------
Patch looks great!
Reviews applied: [70067]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers --disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On Feb. 27, 2019, 6:15 p.m., Meng Zhu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70067/
> -----------------------------------------------------------
>
> (Updated Feb. 27, 2019, 6:15 p.m.)
>
>
> Review request for mesos and Benjamin Mahler.
>
>
> Bugs: MESOS-7124
> https://issues.apache.org/jira/browse/MESOS-7124
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added star operator for `Result`, `Try` and `Option`.
>
>
> Diffs
> -----
>
> 3rdparty/stout/include/stout/option.hpp 8feed012a55fed6eab89c883958324f3345e46e9
> 3rdparty/stout/include/stout/result.hpp c1387ae957edffc31250b9b236b5f1fd8ff0acd3
> 3rdparty/stout/include/stout/try.hpp 30cce7e27fa040d0ce5a86efc4820f8c39178444
> 3rdparty/stout/tests/option_tests.cpp 815d40e0bf342998634dc69a1719c3f717c7202c
> 3rdparty/stout/tests/result_tests.cpp 1750e6b4a90afec3b7de0621779f8b69a856da41
> 3rdparty/stout/tests/try_tests.cpp 99b7b2a3f968abb87549fb9075d65bc5bcc827f1
>
>
> Diff: https://reviews.apache.org/r/70067/diff/1/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Meng Zhu
>
>
Re: Review Request 70067: Added star operator for `Result`,
`Try` and `Option`.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70067/#review213310
-----------------------------------------------------------
Patch looks great!
Reviews applied: [70067]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers --disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On Feb. 27, 2019, 6:15 p.m., Meng Zhu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70067/
> -----------------------------------------------------------
>
> (Updated Feb. 27, 2019, 6:15 p.m.)
>
>
> Review request for mesos, Benjamin Bannier and Benjamin Mahler.
>
>
> Bugs: MESOS-7124
> https://issues.apache.org/jira/browse/MESOS-7124
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added star operator for `Result`, `Try` and `Option`.
>
>
> Diffs
> -----
>
> 3rdparty/stout/include/stout/option.hpp 8feed012a55fed6eab89c883958324f3345e46e9
> 3rdparty/stout/include/stout/result.hpp c1387ae957edffc31250b9b236b5f1fd8ff0acd3
> 3rdparty/stout/include/stout/try.hpp 30cce7e27fa040d0ce5a86efc4820f8c39178444
> 3rdparty/stout/tests/option_tests.cpp 815d40e0bf342998634dc69a1719c3f717c7202c
> 3rdparty/stout/tests/result_tests.cpp 1750e6b4a90afec3b7de0621779f8b69a856da41
> 3rdparty/stout/tests/try_tests.cpp 99b7b2a3f968abb87549fb9075d65bc5bcc827f1
>
>
> Diff: https://reviews.apache.org/r/70067/diff/3/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Meng Zhu
>
>
Re: Review Request 70067: Added star operator for `Result`,
`Try` and `Option`.
Posted by Benjamin Bannier <be...@mesosphere.io>.
> On March 2, 2019, 4:24 p.m., Benjamin Mahler wrote:
> > 3rdparty/stout/include/stout/result.hpp
> > Lines 142 (patched)
> > <https://reviews.apache.org/r/70067/diff/3/?file=2127550#file2127550line142>
> >
> > why is it left out when the others are already included?
The rvalue-qualified `get` overloads are missing here.
I'd suggest we either implement them here so we can address this `TODO`, or to lvalue-qualify the existing `get` overloads and add a `TODO` for rvalue-qualified `get` overloads and implement rvalue qualified `operator*` (which cannot be used until the rvalue-qualified `get` overloads are implemented).
Probably easiest to just fix `get`.
> On March 2, 2019, 4:24 p.m., Benjamin Mahler wrote:
> > 3rdparty/stout/tests/option_tests.cpp
> > Lines 137 (patched)
> > <https://reviews.apache.org/r/70067/diff/3/?file=2127552#file2127552line137>
> >
> > this doesn't test that moving is working correctly? Can we test to ensure that this operator lets just move?
> >
> > ```
> > Option<hashmap<int,int>> moved = {{1,1}};
> >
> > hashmap<int,int> map = *std::move(moved);
> >
> > // Expect moved is empty
> > // Expect map is {1,1}
> > ```
Hmm, is there anything in the standard promising that the source of a `move` gets emptied out? I am not sure adding an expectation related to `move`.
- Benjamin
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70067/#review213350
-----------------------------------------------------------
On Feb. 27, 2019, 7:15 p.m., Meng Zhu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70067/
> -----------------------------------------------------------
>
> (Updated Feb. 27, 2019, 7:15 p.m.)
>
>
> Review request for mesos, Benjamin Bannier and Benjamin Mahler.
>
>
> Bugs: MESOS-7124
> https://issues.apache.org/jira/browse/MESOS-7124
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added star operator for `Result`, `Try` and `Option`.
>
>
> Diffs
> -----
>
> 3rdparty/stout/include/stout/option.hpp 8feed012a55fed6eab89c883958324f3345e46e9
> 3rdparty/stout/include/stout/result.hpp c1387ae957edffc31250b9b236b5f1fd8ff0acd3
> 3rdparty/stout/include/stout/try.hpp 30cce7e27fa040d0ce5a86efc4820f8c39178444
> 3rdparty/stout/tests/option_tests.cpp 815d40e0bf342998634dc69a1719c3f717c7202c
> 3rdparty/stout/tests/result_tests.cpp 1750e6b4a90afec3b7de0621779f8b69a856da41
> 3rdparty/stout/tests/try_tests.cpp 99b7b2a3f968abb87549fb9075d65bc5bcc827f1
>
>
> Diff: https://reviews.apache.org/r/70067/diff/3/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Meng Zhu
>
>
Re: Review Request 70067: Added star operator for `Result`,
`Try` and `Option`.
Posted by Benjamin Mahler <bm...@apache.org>.
> On March 2, 2019, 3:24 p.m., Benjamin Mahler wrote:
> > 3rdparty/stout/tests/option_tests.cpp
> > Lines 137 (patched)
> > <https://reviews.apache.org/r/70067/diff/3/?file=2127552#file2127552line137>
> >
> > this doesn't test that moving is working correctly? Can we test to ensure that this operator lets just move?
> >
> > ```
> > Option<hashmap<int,int>> moved = {{1,1}};
> >
> > hashmap<int,int> map = *std::move(moved);
> >
> > // Expect moved is empty
> > // Expect map is {1,1}
> > ```
>
> Benjamin Bannier wrote:
> Hmm, is there anything in the standard promising that the source of a `move` gets emptied out? I am not sure adding an expectation related to `move`.
>
> Meng Zhu wrote:
> I do not think we need to test content after the move, just need to test the returned content of the `*` which the code has already tested. Dropping, Bmahler please feel free to re-open if you think otherwise.
As it stands, the test would compile if it actually was copying instead of moving? Or no?
Seems prudent to test a move is actually occurring, if there's nothing in std containers to rely on w.r.t post-move invariants, we can just have our own struct that stores a boolean indicating that it's been moved and we can test that to make sure the move actually occurs?
- Benjamin
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70067/#review213350
-----------------------------------------------------------
On March 4, 2019, 10:50 p.m., Meng Zhu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70067/
> -----------------------------------------------------------
>
> (Updated March 4, 2019, 10:50 p.m.)
>
>
> Review request for mesos, Benjamin Bannier and Benjamin Mahler.
>
>
> Bugs: MESOS-7124
> https://issues.apache.org/jira/browse/MESOS-7124
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added star operator for `Result`, `Try` and `Option`.
>
>
> Diffs
> -----
>
> 3rdparty/stout/include/stout/option.hpp 8feed012a55fed6eab89c883958324f3345e46e9
> 3rdparty/stout/include/stout/result.hpp c1387ae957edffc31250b9b236b5f1fd8ff0acd3
> 3rdparty/stout/include/stout/try.hpp 30cce7e27fa040d0ce5a86efc4820f8c39178444
> 3rdparty/stout/tests/option_tests.cpp 815d40e0bf342998634dc69a1719c3f717c7202c
> 3rdparty/stout/tests/result_tests.cpp 1750e6b4a90afec3b7de0621779f8b69a856da41
> 3rdparty/stout/tests/try_tests.cpp 99b7b2a3f968abb87549fb9075d65bc5bcc827f1
>
>
> Diff: https://reviews.apache.org/r/70067/diff/4/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Meng Zhu
>
>
Re: Review Request 70067: Added star operator for `Result`,
`Try` and `Option`.
Posted by Meng Zhu <mz...@mesosphere.io>.
> On March 2, 2019, 7:24 a.m., Benjamin Mahler wrote:
> > 3rdparty/stout/tests/option_tests.cpp
> > Lines 137 (patched)
> > <https://reviews.apache.org/r/70067/diff/3/?file=2127552#file2127552line137>
> >
> > this doesn't test that moving is working correctly? Can we test to ensure that this operator lets just move?
> >
> > ```
> > Option<hashmap<int,int>> moved = {{1,1}};
> >
> > hashmap<int,int> map = *std::move(moved);
> >
> > // Expect moved is empty
> > // Expect map is {1,1}
> > ```
>
> Benjamin Bannier wrote:
> Hmm, is there anything in the standard promising that the source of a `move` gets emptied out? I am not sure adding an expectation related to `move`.
>
> Meng Zhu wrote:
> I do not think we need to test content after the move, just need to test the returned content of the `*` which the code has already tested. Dropping, Bmahler please feel free to re-open if you think otherwise.
>
> Benjamin Mahler wrote:
> As it stands, the test would compile if it actually was copying instead of moving? Or no?
>
> Seems prudent to test a move is actually occurring, if there's nothing in std containers to rely on w.r.t post-move invariants, we can just have our own struct that stores a boolean indicating that it's been moved and we can test that to make sure the move actually occurs?
OK, added a custom type to verify the moving. Funny that it actually leads me to find missing constructors in `Try` which would lead to redundant copy and convoluted logic.
- Meng
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70067/#review213350
-----------------------------------------------------------
On March 8, 2019, 5:56 p.m., Meng Zhu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70067/
> -----------------------------------------------------------
>
> (Updated March 8, 2019, 5:56 p.m.)
>
>
> Review request for mesos, Benjamin Bannier and Benjamin Mahler.
>
>
> Bugs: MESOS-7124
> https://issues.apache.org/jira/browse/MESOS-7124
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added star operator for `Result`, `Try` and `Option`.
>
>
> Diffs
> -----
>
> 3rdparty/stout/include/stout/option.hpp 8feed012a55fed6eab89c883958324f3345e46e9
> 3rdparty/stout/include/stout/result.hpp c1387ae957edffc31250b9b236b5f1fd8ff0acd3
> 3rdparty/stout/include/stout/try.hpp 30cce7e27fa040d0ce5a86efc4820f8c39178444
> 3rdparty/stout/tests/option_tests.cpp 815d40e0bf342998634dc69a1719c3f717c7202c
> 3rdparty/stout/tests/result_tests.cpp 1750e6b4a90afec3b7de0621779f8b69a856da41
> 3rdparty/stout/tests/try_tests.cpp 99b7b2a3f968abb87549fb9075d65bc5bcc827f1
>
>
> Diff: https://reviews.apache.org/r/70067/diff/5/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Meng Zhu
>
>
Re: Review Request 70067: Added star operator for `Result`,
`Try` and `Option`.
Posted by Meng Zhu <mz...@mesosphere.io>.
> On March 2, 2019, 7:24 a.m., Benjamin Mahler wrote:
> > 3rdparty/stout/include/stout/result.hpp
> > Lines 142 (patched)
> > <https://reviews.apache.org/r/70067/diff/3/?file=2127550#file2127550line142>
> >
> > why is it left out when the others are already included?
>
> Benjamin Bannier wrote:
> The rvalue-qualified `get` overloads are missing here.
>
> I'd suggest we either implement them here so we can address this `TODO`, or to lvalue-qualify the existing `get` overloads and add a `TODO` for rvalue-qualified `get` overloads and implement rvalue qualified `operator*` (which cannot be used until the rvalue-qualified `get` overloads are implemented).
>
> Probably easiest to just fix `get`.
Added rvalue overload for `Result::get()` in https://reviews.apache.org/r/70123/.
And added rvalue qualified `*` for `Result` in the patch.
> On March 2, 2019, 7:24 a.m., Benjamin Mahler wrote:
> > 3rdparty/stout/tests/option_tests.cpp
> > Lines 137 (patched)
> > <https://reviews.apache.org/r/70067/diff/3/?file=2127552#file2127552line137>
> >
> > this doesn't test that moving is working correctly? Can we test to ensure that this operator lets just move?
> >
> > ```
> > Option<hashmap<int,int>> moved = {{1,1}};
> >
> > hashmap<int,int> map = *std::move(moved);
> >
> > // Expect moved is empty
> > // Expect map is {1,1}
> > ```
>
> Benjamin Bannier wrote:
> Hmm, is there anything in the standard promising that the source of a `move` gets emptied out? I am not sure adding an expectation related to `move`.
I do not think we need to test content after the move, just need to test the returned content of the `*` which the code has already tested. Dropping, Bmahler please feel free to re-open if you think otherwise.
- Meng
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70067/#review213350
-----------------------------------------------------------
On March 4, 2019, 2:50 p.m., Meng Zhu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70067/
> -----------------------------------------------------------
>
> (Updated March 4, 2019, 2:50 p.m.)
>
>
> Review request for mesos, Benjamin Bannier and Benjamin Mahler.
>
>
> Bugs: MESOS-7124
> https://issues.apache.org/jira/browse/MESOS-7124
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added star operator for `Result`, `Try` and `Option`.
>
>
> Diffs
> -----
>
> 3rdparty/stout/include/stout/option.hpp 8feed012a55fed6eab89c883958324f3345e46e9
> 3rdparty/stout/include/stout/result.hpp c1387ae957edffc31250b9b236b5f1fd8ff0acd3
> 3rdparty/stout/include/stout/try.hpp 30cce7e27fa040d0ce5a86efc4820f8c39178444
> 3rdparty/stout/tests/option_tests.cpp 815d40e0bf342998634dc69a1719c3f717c7202c
> 3rdparty/stout/tests/result_tests.cpp 1750e6b4a90afec3b7de0621779f8b69a856da41
> 3rdparty/stout/tests/try_tests.cpp 99b7b2a3f968abb87549fb9075d65bc5bcc827f1
>
>
> Diff: https://reviews.apache.org/r/70067/diff/4/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Meng Zhu
>
>
Re: Review Request 70067: Added star operator for `Result`,
`Try` and `Option`.
Posted by Benjamin Mahler <bm...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70067/#review213350
-----------------------------------------------------------
3rdparty/stout/include/stout/result.hpp
Lines 142 (patched)
<https://reviews.apache.org/r/70067/#comment299297>
why is it left out when the others are already included?
3rdparty/stout/tests/option_tests.cpp
Lines 137 (patched)
<https://reviews.apache.org/r/70067/#comment299298>
this doesn't test that moving is working correctly? Can we test to ensure that this operator lets just move?
```
Option<hashmap<int,int>> moved = {{1,1}};
hashmap<int,int> map = *std::move(moved);
// Expect moved is empty
// Expect map is {1,1}
```
- Benjamin Mahler
On Feb. 27, 2019, 6:15 p.m., Meng Zhu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70067/
> -----------------------------------------------------------
>
> (Updated Feb. 27, 2019, 6:15 p.m.)
>
>
> Review request for mesos, Benjamin Bannier and Benjamin Mahler.
>
>
> Bugs: MESOS-7124
> https://issues.apache.org/jira/browse/MESOS-7124
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added star operator for `Result`, `Try` and `Option`.
>
>
> Diffs
> -----
>
> 3rdparty/stout/include/stout/option.hpp 8feed012a55fed6eab89c883958324f3345e46e9
> 3rdparty/stout/include/stout/result.hpp c1387ae957edffc31250b9b236b5f1fd8ff0acd3
> 3rdparty/stout/include/stout/try.hpp 30cce7e27fa040d0ce5a86efc4820f8c39178444
> 3rdparty/stout/tests/option_tests.cpp 815d40e0bf342998634dc69a1719c3f717c7202c
> 3rdparty/stout/tests/result_tests.cpp 1750e6b4a90afec3b7de0621779f8b69a856da41
> 3rdparty/stout/tests/try_tests.cpp 99b7b2a3f968abb87549fb9075d65bc5bcc827f1
>
>
> Diff: https://reviews.apache.org/r/70067/diff/3/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Meng Zhu
>
>
Re: Review Request 70067: Added star operator for `Result`,
`Try` and `Option`.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70067/#review213293
-----------------------------------------------------------
Patch looks great!
Reviews applied: [70067]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers --disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On Feb. 27, 2019, 6:15 p.m., Meng Zhu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70067/
> -----------------------------------------------------------
>
> (Updated Feb. 27, 2019, 6:15 p.m.)
>
>
> Review request for mesos, Benjamin Bannier and Benjamin Mahler.
>
>
> Bugs: MESOS-7124
> https://issues.apache.org/jira/browse/MESOS-7124
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added star operator for `Result`, `Try` and `Option`.
>
>
> Diffs
> -----
>
> 3rdparty/stout/include/stout/option.hpp 8feed012a55fed6eab89c883958324f3345e46e9
> 3rdparty/stout/include/stout/result.hpp c1387ae957edffc31250b9b236b5f1fd8ff0acd3
> 3rdparty/stout/include/stout/try.hpp 30cce7e27fa040d0ce5a86efc4820f8c39178444
> 3rdparty/stout/tests/option_tests.cpp 815d40e0bf342998634dc69a1719c3f717c7202c
> 3rdparty/stout/tests/result_tests.cpp 1750e6b4a90afec3b7de0621779f8b69a856da41
> 3rdparty/stout/tests/try_tests.cpp 99b7b2a3f968abb87549fb9075d65bc5bcc827f1
>
>
> Diff: https://reviews.apache.org/r/70067/diff/2/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Meng Zhu
>
>
Re: Review Request 70067: Added star operator for `Result`,
`Try` and `Option`.
Posted by Benjamin Mahler <bm...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70067/#review213265
-----------------------------------------------------------
Ship it!
Can you link this up with [MESOS-7124]([https://issues.apache.org/jira/browse/MESOS-7124)? It doesn't quite close it but let's associate them and show that we've added the star operator (but haven't removed/updated .get())
- Benjamin Mahler
On Feb. 27, 2019, 6:15 p.m., Meng Zhu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70067/
> -----------------------------------------------------------
>
> (Updated Feb. 27, 2019, 6:15 p.m.)
>
>
> Review request for mesos and Benjamin Mahler.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added star operator for `Result`, `Try` and `Option`.
>
>
> Diffs
> -----
>
> 3rdparty/stout/include/stout/option.hpp 8feed012a55fed6eab89c883958324f3345e46e9
> 3rdparty/stout/include/stout/result.hpp c1387ae957edffc31250b9b236b5f1fd8ff0acd3
> 3rdparty/stout/include/stout/try.hpp 30cce7e27fa040d0ce5a86efc4820f8c39178444
> 3rdparty/stout/tests/option_tests.cpp 815d40e0bf342998634dc69a1719c3f717c7202c
> 3rdparty/stout/tests/result_tests.cpp 1750e6b4a90afec3b7de0621779f8b69a856da41
> 3rdparty/stout/tests/try_tests.cpp 99b7b2a3f968abb87549fb9075d65bc5bcc827f1
>
>
> Diff: https://reviews.apache.org/r/70067/diff/1/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Meng Zhu
>
>
Re: Review Request 70067: Added star operator for `Result`,
`Try` and `Option`.
Posted by Benjamin Bannier <be...@mesosphere.io>.
> On Feb. 27, 2019, 8:14 p.m., Benjamin Bannier wrote:
> > 3rdparty/stout/include/stout/option.hpp
> > Lines 127 (patched)
> > <https://reviews.apache.org/r/70067/diff/1/?file=2127187#file2127187line127>
> >
> > I feel we should disable this one for rvalues (which should also have been done for `T* operator->`).
> > ```
> > T& operator*() & { return get(); }
> > ```
>
> Meng Zhu wrote:
> Thanks for reviewing! I added rvalue versions for `*`. (except `Result` where a todo is added to add ref-qualified `get()` first).
>
> Looking at the `std::optional` (https://en.cppreference.com/w/cpp/utility/optional/operator*), both are allowed. Though I cannot think of a compelling use case, probably just for completeness.
Marking this and similar issues below as fixed. Please reopen if you wanted to discuss anything else.
- Benjamin
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70067/#review213266
-----------------------------------------------------------
On Feb. 27, 2019, 7:15 p.m., Meng Zhu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70067/
> -----------------------------------------------------------
>
> (Updated Feb. 27, 2019, 7:15 p.m.)
>
>
> Review request for mesos, Benjamin Bannier and Benjamin Mahler.
>
>
> Bugs: MESOS-7124
> https://issues.apache.org/jira/browse/MESOS-7124
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added star operator for `Result`, `Try` and `Option`.
>
>
> Diffs
> -----
>
> 3rdparty/stout/include/stout/option.hpp 8feed012a55fed6eab89c883958324f3345e46e9
> 3rdparty/stout/include/stout/result.hpp c1387ae957edffc31250b9b236b5f1fd8ff0acd3
> 3rdparty/stout/include/stout/try.hpp 30cce7e27fa040d0ce5a86efc4820f8c39178444
> 3rdparty/stout/tests/option_tests.cpp 815d40e0bf342998634dc69a1719c3f717c7202c
> 3rdparty/stout/tests/result_tests.cpp 1750e6b4a90afec3b7de0621779f8b69a856da41
> 3rdparty/stout/tests/try_tests.cpp 99b7b2a3f968abb87549fb9075d65bc5bcc827f1
>
>
> Diff: https://reviews.apache.org/r/70067/diff/3/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Meng Zhu
>
>
Re: Review Request 70067: Added star operator for `Result`,
`Try` and `Option`.
Posted by Meng Zhu <mz...@mesosphere.io>.
> On Feb. 27, 2019, 11:14 a.m., Benjamin Bannier wrote:
> > Thanks for adding these!
> >
> > Like Ben said, let's link this to MESOS-7124. Let's additionally create a ticket linked there for writing a linter to catch uses of `get` where `operator*` should be used (this could be modelled based on the existing `mesos-redundant-get` linter).
Linked and filed MESOS-9617.
> On Feb. 27, 2019, 11:14 a.m., Benjamin Bannier wrote:
> > 3rdparty/stout/include/stout/option.hpp
> > Lines 127 (patched)
> > <https://reviews.apache.org/r/70067/diff/1/?file=2127187#file2127187line127>
> >
> > I feel we should disable this one for rvalues (which should also have been done for `T* operator->`).
> > ```
> > T& operator*() & { return get(); }
> > ```
Thanks for reviewing! I added rvalue versions for `*`. (except `Result` where a todo is added to add ref-qualified `get()` first).
Looking at the `std::optional` (https://en.cppreference.com/w/cpp/utility/optional/operator*), both are allowed. Though I cannot think of a compelling use case, probably just for completeness.
> On Feb. 27, 2019, 11:14 a.m., Benjamin Bannier wrote:
> > 3rdparty/stout/include/stout/result.hpp
> > Lines 138 (patched)
> > <https://reviews.apache.org/r/70067/diff/1/?file=2127188#file2127188line138>
> >
> > Disable for rvalues?
See my comment above.
> On Feb. 27, 2019, 11:14 a.m., Benjamin Bannier wrote:
> > 3rdparty/stout/include/stout/try.hpp
> > Lines 82 (patched)
> > <https://reviews.apache.org/r/70067/diff/1/?file=2127189#file2127189line82>
> >
> > Disable for rvalues?
See my comment above.
- Meng
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70067/#review213266
-----------------------------------------------------------
On Feb. 27, 2019, 10:15 a.m., Meng Zhu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70067/
> -----------------------------------------------------------
>
> (Updated Feb. 27, 2019, 10:15 a.m.)
>
>
> Review request for mesos, Benjamin Bannier and Benjamin Mahler.
>
>
> Bugs: MESOS-7124
> https://issues.apache.org/jira/browse/MESOS-7124
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added star operator for `Result`, `Try` and `Option`.
>
>
> Diffs
> -----
>
> 3rdparty/stout/include/stout/option.hpp 8feed012a55fed6eab89c883958324f3345e46e9
> 3rdparty/stout/include/stout/result.hpp c1387ae957edffc31250b9b236b5f1fd8ff0acd3
> 3rdparty/stout/include/stout/try.hpp 30cce7e27fa040d0ce5a86efc4820f8c39178444
> 3rdparty/stout/tests/option_tests.cpp 815d40e0bf342998634dc69a1719c3f717c7202c
> 3rdparty/stout/tests/result_tests.cpp 1750e6b4a90afec3b7de0621779f8b69a856da41
> 3rdparty/stout/tests/try_tests.cpp 99b7b2a3f968abb87549fb9075d65bc5bcc827f1
>
>
> Diff: https://reviews.apache.org/r/70067/diff/2/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Meng Zhu
>
>
Re: Review Request 70067: Added star operator for `Result`,
`Try` and `Option`.
Posted by Benjamin Bannier <be...@mesosphere.io>.
- Benjamin
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70067/#review213266
-----------------------------------------------------------
On Feb. 27, 2019, 7:15 p.m., Meng Zhu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70067/
> -----------------------------------------------------------
>
> (Updated Feb. 27, 2019, 7:15 p.m.)
>
>
> Review request for mesos, Benjamin Bannier and Benjamin Mahler.
>
>
> Bugs: MESOS-7124
> https://issues.apache.org/jira/browse/MESOS-7124
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added star operator for `Result`, `Try` and `Option`.
>
>
> Diffs
> -----
>
> 3rdparty/stout/include/stout/option.hpp 8feed012a55fed6eab89c883958324f3345e46e9
> 3rdparty/stout/include/stout/result.hpp c1387ae957edffc31250b9b236b5f1fd8ff0acd3
> 3rdparty/stout/include/stout/try.hpp 30cce7e27fa040d0ce5a86efc4820f8c39178444
> 3rdparty/stout/tests/option_tests.cpp 815d40e0bf342998634dc69a1719c3f717c7202c
> 3rdparty/stout/tests/result_tests.cpp 1750e6b4a90afec3b7de0621779f8b69a856da41
> 3rdparty/stout/tests/try_tests.cpp 99b7b2a3f968abb87549fb9075d65bc5bcc827f1
>
>
> Diff: https://reviews.apache.org/r/70067/diff/3/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Meng Zhu
>
>
Re: Review Request 70067: Added star operator for `Result`,
`Try` and `Option`.
Posted by Benjamin Bannier <be...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70067/#review213266
-----------------------------------------------------------
Thanks for adding these!
Like Ben said, let's link this to MESOS-7124. Let's additionally create a ticket linked there for writing a linter to catch uses of `get` where `operator*` should be used (this could be modelled based on the existing `mesos-redundant-get` linter).
3rdparty/stout/include/stout/option.hpp
Lines 127 (patched)
<https://reviews.apache.org/r/70067/#comment299199>
I feel we should disable this one for rvalues (which should also have been done for `T* operator->`).
```
T& operator*() & { return get(); }
```
3rdparty/stout/include/stout/result.hpp
Lines 138 (patched)
<https://reviews.apache.org/r/70067/#comment299197>
Disable for rvalues?
3rdparty/stout/include/stout/try.hpp
Lines 82 (patched)
<https://reviews.apache.org/r/70067/#comment299198>
Disable for rvalues?
- Benjamin Bannier
On Feb. 27, 2019, 7:15 p.m., Meng Zhu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70067/
> -----------------------------------------------------------
>
> (Updated Feb. 27, 2019, 7:15 p.m.)
>
>
> Review request for mesos and Benjamin Mahler.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added star operator for `Result`, `Try` and `Option`.
>
>
> Diffs
> -----
>
> 3rdparty/stout/include/stout/option.hpp 8feed012a55fed6eab89c883958324f3345e46e9
> 3rdparty/stout/include/stout/result.hpp c1387ae957edffc31250b9b236b5f1fd8ff0acd3
> 3rdparty/stout/include/stout/try.hpp 30cce7e27fa040d0ce5a86efc4820f8c39178444
> 3rdparty/stout/tests/option_tests.cpp 815d40e0bf342998634dc69a1719c3f717c7202c
> 3rdparty/stout/tests/result_tests.cpp 1750e6b4a90afec3b7de0621779f8b69a856da41
> 3rdparty/stout/tests/try_tests.cpp 99b7b2a3f968abb87549fb9075d65bc5bcc827f1
>
>
> Diff: https://reviews.apache.org/r/70067/diff/1/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Meng Zhu
>
>
Re: Review Request 70067: Added star operator for `Result`,
`Try` and `Option`.
Posted by Benjamin Bannier <be...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70067/#review213443
-----------------------------------------------------------
Ship it!
Ship It!
- Benjamin Bannier
On March 4, 2019, 11:50 p.m., Meng Zhu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70067/
> -----------------------------------------------------------
>
> (Updated March 4, 2019, 11:50 p.m.)
>
>
> Review request for mesos, Benjamin Bannier and Benjamin Mahler.
>
>
> Bugs: MESOS-7124
> https://issues.apache.org/jira/browse/MESOS-7124
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added star operator for `Result`, `Try` and `Option`.
>
>
> Diffs
> -----
>
> 3rdparty/stout/include/stout/option.hpp 8feed012a55fed6eab89c883958324f3345e46e9
> 3rdparty/stout/include/stout/result.hpp c1387ae957edffc31250b9b236b5f1fd8ff0acd3
> 3rdparty/stout/include/stout/try.hpp 30cce7e27fa040d0ce5a86efc4820f8c39178444
> 3rdparty/stout/tests/option_tests.cpp 815d40e0bf342998634dc69a1719c3f717c7202c
> 3rdparty/stout/tests/result_tests.cpp 1750e6b4a90afec3b7de0621779f8b69a856da41
> 3rdparty/stout/tests/try_tests.cpp 99b7b2a3f968abb87549fb9075d65bc5bcc827f1
>
>
> Diff: https://reviews.apache.org/r/70067/diff/4/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Meng Zhu
>
>
Re: Review Request 70067: Added star operator for `Result`,
`Try` and `Option`.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70067/#review213432
-----------------------------------------------------------
Patch looks great!
Reviews applied: [70123, 70067]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers --disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On March 4, 2019, 10:50 p.m., Meng Zhu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70067/
> -----------------------------------------------------------
>
> (Updated March 4, 2019, 10:50 p.m.)
>
>
> Review request for mesos, Benjamin Bannier and Benjamin Mahler.
>
>
> Bugs: MESOS-7124
> https://issues.apache.org/jira/browse/MESOS-7124
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added star operator for `Result`, `Try` and `Option`.
>
>
> Diffs
> -----
>
> 3rdparty/stout/include/stout/option.hpp 8feed012a55fed6eab89c883958324f3345e46e9
> 3rdparty/stout/include/stout/result.hpp c1387ae957edffc31250b9b236b5f1fd8ff0acd3
> 3rdparty/stout/include/stout/try.hpp 30cce7e27fa040d0ce5a86efc4820f8c39178444
> 3rdparty/stout/tests/option_tests.cpp 815d40e0bf342998634dc69a1719c3f717c7202c
> 3rdparty/stout/tests/result_tests.cpp 1750e6b4a90afec3b7de0621779f8b69a856da41
> 3rdparty/stout/tests/try_tests.cpp 99b7b2a3f968abb87549fb9075d65bc5bcc827f1
>
>
> Diff: https://reviews.apache.org/r/70067/diff/4/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Meng Zhu
>
>
Re: Review Request 70067: Added star operator for `Result`,
`Try` and `Option`.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70067/#review213582
-----------------------------------------------------------
Patch looks great!
Reviews applied: [70123, 70171, 70067]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers --disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On March 9, 2019, 1:56 a.m., Meng Zhu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70067/
> -----------------------------------------------------------
>
> (Updated March 9, 2019, 1:56 a.m.)
>
>
> Review request for mesos, Benjamin Bannier and Benjamin Mahler.
>
>
> Bugs: MESOS-7124
> https://issues.apache.org/jira/browse/MESOS-7124
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added star operator for `Result`, `Try` and `Option`.
>
>
> Diffs
> -----
>
> 3rdparty/stout/include/stout/option.hpp 8feed012a55fed6eab89c883958324f3345e46e9
> 3rdparty/stout/include/stout/result.hpp c1387ae957edffc31250b9b236b5f1fd8ff0acd3
> 3rdparty/stout/include/stout/try.hpp 30cce7e27fa040d0ce5a86efc4820f8c39178444
> 3rdparty/stout/tests/option_tests.cpp 815d40e0bf342998634dc69a1719c3f717c7202c
> 3rdparty/stout/tests/result_tests.cpp 1750e6b4a90afec3b7de0621779f8b69a856da41
> 3rdparty/stout/tests/try_tests.cpp 99b7b2a3f968abb87549fb9075d65bc5bcc827f1
>
>
> Diff: https://reviews.apache.org/r/70067/diff/5/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Meng Zhu
>
>
Re: Review Request 70067: Added star operator for `Result`,
`Try` and `Option`.
Posted by Meng Zhu <mz...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70067/
-----------------------------------------------------------
(Updated March 8, 2019, 5:56 p.m.)
Review request for mesos, Benjamin Bannier and Benjamin Mahler.
Bugs: MESOS-7124
https://issues.apache.org/jira/browse/MESOS-7124
Repository: mesos
Description
-------
Added star operator for `Result`, `Try` and `Option`.
Diffs (updated)
-----
3rdparty/stout/include/stout/option.hpp 8feed012a55fed6eab89c883958324f3345e46e9
3rdparty/stout/include/stout/result.hpp c1387ae957edffc31250b9b236b5f1fd8ff0acd3
3rdparty/stout/include/stout/try.hpp 30cce7e27fa040d0ce5a86efc4820f8c39178444
3rdparty/stout/tests/option_tests.cpp 815d40e0bf342998634dc69a1719c3f717c7202c
3rdparty/stout/tests/result_tests.cpp 1750e6b4a90afec3b7de0621779f8b69a856da41
3rdparty/stout/tests/try_tests.cpp 99b7b2a3f968abb87549fb9075d65bc5bcc827f1
Diff: https://reviews.apache.org/r/70067/diff/5/
Changes: https://reviews.apache.org/r/70067/diff/4-5/
Testing
-------
make check
Thanks,
Meng Zhu
Re: Review Request 70067: Added star operator for `Result`,
`Try` and `Option`.
Posted by Meng Zhu <mz...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70067/
-----------------------------------------------------------
(Updated March 4, 2019, 2:50 p.m.)
Review request for mesos, Benjamin Bannier and Benjamin Mahler.
Changes
-------
Addressed Bbannier's comment.
Bugs: MESOS-7124
https://issues.apache.org/jira/browse/MESOS-7124
Repository: mesos
Description
-------
Added star operator for `Result`, `Try` and `Option`.
Diffs (updated)
-----
3rdparty/stout/include/stout/option.hpp 8feed012a55fed6eab89c883958324f3345e46e9
3rdparty/stout/include/stout/result.hpp c1387ae957edffc31250b9b236b5f1fd8ff0acd3
3rdparty/stout/include/stout/try.hpp 30cce7e27fa040d0ce5a86efc4820f8c39178444
3rdparty/stout/tests/option_tests.cpp 815d40e0bf342998634dc69a1719c3f717c7202c
3rdparty/stout/tests/result_tests.cpp 1750e6b4a90afec3b7de0621779f8b69a856da41
3rdparty/stout/tests/try_tests.cpp 99b7b2a3f968abb87549fb9075d65bc5bcc827f1
Diff: https://reviews.apache.org/r/70067/diff/4/
Changes: https://reviews.apache.org/r/70067/diff/3-4/
Testing
-------
make check
Thanks,
Meng Zhu
Re: Review Request 70067: Added star operator for `Result`,
`Try` and `Option`.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70067/#review213267
-----------------------------------------------------------
Patch looks great!
Reviews applied: [70067]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers --disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On Feb. 27, 2019, 6:15 p.m., Meng Zhu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70067/
> -----------------------------------------------------------
>
> (Updated Feb. 27, 2019, 6:15 p.m.)
>
>
> Review request for mesos and Benjamin Mahler.
>
>
> Bugs: MESOS-7124
> https://issues.apache.org/jira/browse/MESOS-7124
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added star operator for `Result`, `Try` and `Option`.
>
>
> Diffs
> -----
>
> 3rdparty/stout/include/stout/option.hpp 8feed012a55fed6eab89c883958324f3345e46e9
> 3rdparty/stout/include/stout/result.hpp c1387ae957edffc31250b9b236b5f1fd8ff0acd3
> 3rdparty/stout/include/stout/try.hpp 30cce7e27fa040d0ce5a86efc4820f8c39178444
> 3rdparty/stout/tests/option_tests.cpp 815d40e0bf342998634dc69a1719c3f717c7202c
> 3rdparty/stout/tests/result_tests.cpp 1750e6b4a90afec3b7de0621779f8b69a856da41
> 3rdparty/stout/tests/try_tests.cpp 99b7b2a3f968abb87549fb9075d65bc5bcc827f1
>
>
> Diff: https://reviews.apache.org/r/70067/diff/1/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Meng Zhu
>
>
Re: Review Request 70067: Added star operator for `Result`,
`Try` and `Option`.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70067/#review213311
-----------------------------------------------------------
Patch looks great!
Reviews applied: [70067]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers --disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On Feb. 27, 2019, 6:15 p.m., Meng Zhu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70067/
> -----------------------------------------------------------
>
> (Updated Feb. 27, 2019, 6:15 p.m.)
>
>
> Review request for mesos, Benjamin Bannier and Benjamin Mahler.
>
>
> Bugs: MESOS-7124
> https://issues.apache.org/jira/browse/MESOS-7124
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added star operator for `Result`, `Try` and `Option`.
>
>
> Diffs
> -----
>
> 3rdparty/stout/include/stout/option.hpp 8feed012a55fed6eab89c883958324f3345e46e9
> 3rdparty/stout/include/stout/result.hpp c1387ae957edffc31250b9b236b5f1fd8ff0acd3
> 3rdparty/stout/include/stout/try.hpp 30cce7e27fa040d0ce5a86efc4820f8c39178444
> 3rdparty/stout/tests/option_tests.cpp 815d40e0bf342998634dc69a1719c3f717c7202c
> 3rdparty/stout/tests/result_tests.cpp 1750e6b4a90afec3b7de0621779f8b69a856da41
> 3rdparty/stout/tests/try_tests.cpp 99b7b2a3f968abb87549fb9075d65bc5bcc827f1
>
>
> Diff: https://reviews.apache.org/r/70067/diff/3/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Meng Zhu
>
>