You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2020/09/28 17:35:33 UTC

[GitHub] [arrow] Luminarys commented on pull request #8279: ARROW-10102: [C++] Refactor BasicDecimal128 Multiplication to use unsigned helper

Luminarys commented on pull request #8279:
URL: https://github.com/apache/arrow/pull/8279#issuecomment-700179007


   Looks like the tests all use the native branch so the 64 * 64 -> 128 helper is unused. Should we skip the native fallback for the 128 * 128 -> 128 for now and add it in the Decimal256 changes?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org