You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@myfaces.apache.org by we...@apache.org on 2009/06/10 14:55:49 UTC
svn commit: r783336 - in
/myfaces/core/branches/2_0_0/impl/src/main/java/org/apache/myfaces/component/visit:
FullVisitContext.java PartialVisitContext.java PartialVisitIdProxy.java
Author: werpu
Date: Wed Jun 10 12:55:49 2009
New Revision: 783336
URL: http://svn.apache.org/viewvc?rev=783336&view=rev
Log:
https://issues.apache.org/jira/browse/MYFACES-2241
added a few comments
Modified:
myfaces/core/branches/2_0_0/impl/src/main/java/org/apache/myfaces/component/visit/FullVisitContext.java
myfaces/core/branches/2_0_0/impl/src/main/java/org/apache/myfaces/component/visit/PartialVisitContext.java
myfaces/core/branches/2_0_0/impl/src/main/java/org/apache/myfaces/component/visit/PartialVisitIdProxy.java
Modified: myfaces/core/branches/2_0_0/impl/src/main/java/org/apache/myfaces/component/visit/FullVisitContext.java
URL: http://svn.apache.org/viewvc/myfaces/core/branches/2_0_0/impl/src/main/java/org/apache/myfaces/component/visit/FullVisitContext.java?rev=783336&r1=783335&r2=783336&view=diff
==============================================================================
--- myfaces/core/branches/2_0_0/impl/src/main/java/org/apache/myfaces/component/visit/FullVisitContext.java (original)
+++ myfaces/core/branches/2_0_0/impl/src/main/java/org/apache/myfaces/component/visit/FullVisitContext.java Wed Jun 10 12:55:49 2009
@@ -15,7 +15,6 @@
package org.apache.myfaces.component.visit;
import java.util.Collection;
-import java.util.Collections;
import java.util.EnumSet;
import java.util.HashSet;
import java.util.Set;
Modified: myfaces/core/branches/2_0_0/impl/src/main/java/org/apache/myfaces/component/visit/PartialVisitContext.java
URL: http://svn.apache.org/viewvc/myfaces/core/branches/2_0_0/impl/src/main/java/org/apache/myfaces/component/visit/PartialVisitContext.java?rev=783336&r1=783335&r2=783336&view=diff
==============================================================================
--- myfaces/core/branches/2_0_0/impl/src/main/java/org/apache/myfaces/component/visit/PartialVisitContext.java (original)
+++ myfaces/core/branches/2_0_0/impl/src/main/java/org/apache/myfaces/component/visit/PartialVisitContext.java Wed Jun 10 12:55:49 2009
@@ -29,6 +29,13 @@
import javax.faces.component.UINamingContainer;
import javax.faces.context.FacesContext;
+/**
+ * Implementation of a PartialVisitContext!
+ * The partial visit context works on a subset of ids and has several
+ * differences to a Full visit context!
+ * First getIds returns a mutable set
+ * Secondly getSubtreeIdsToVisit returns either a valid id subset or ALL_IDS
+ */
public class PartialVisitContext extends VisitContext {
FacesContext _facesContext;
Modified: myfaces/core/branches/2_0_0/impl/src/main/java/org/apache/myfaces/component/visit/PartialVisitIdProxy.java
URL: http://svn.apache.org/viewvc/myfaces/core/branches/2_0_0/impl/src/main/java/org/apache/myfaces/component/visit/PartialVisitIdProxy.java?rev=783336&r1=783335&r2=783336&view=diff
==============================================================================
--- myfaces/core/branches/2_0_0/impl/src/main/java/org/apache/myfaces/component/visit/PartialVisitIdProxy.java (original)
+++ myfaces/core/branches/2_0_0/impl/src/main/java/org/apache/myfaces/component/visit/PartialVisitIdProxy.java Wed Jun 10 12:55:49 2009
@@ -23,7 +23,14 @@
import javax.faces.context.FacesContext;
/**
- * Proxying class to speedup partial ids
+ * A proxying class for our partial visit id handling
+ * we need this class because
+ * a) PartialVisitContext.getIds must return
+ * a valid modifyable set of client ids
+ *
+ * b) There are some speed improvements like an
+ * inverse index, which need to change as well
+ * if the ids are changed!
*/
class PartialVisitIdProxy implements Set<String>{
@@ -76,13 +83,6 @@
}
-
-
-
-
-
-
-
private boolean addToIndex(String clientId) {
//we do not use a split here because we cannot rely on regexps in case of unknown chars