You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@httpd.apache.org by Jean-Jacques Clar <JJ...@novell.com> on 2004/08/26 19:55:24 UTC
Re: cvs commit: httpd-2.0/modules/experimental cache_storage.c
cache_util.c mod_cache.c mod_cache.h mod_
Should the type for refcount be apr_atomic_t instead of apr_uint32_t?
It does not build currently for NetWare.
JJ
>>> stoddard@apache.org 08/26/04 10:59 AM >>>
stoddard 2004/08/26 09:59:46
Index: mod_cache.h
===================================================================
RCS file: /home/cvs/httpd-2.0/modules/experimental/mod_cache.h,v
retrieving revision 1.36.2.6
retrieving revision 1.36.2.7
diff -u -r1.36.2.6 -r1.36.2.7
--- mod_cache.h 9 Feb 2004 20:53:16 -0000 1.36.2.6
+++ mod_cache.h 26 Aug 2004 16:59:44 -0000 1.36.2.7
@@ -175,29 +172,46 @@
void *vobj; /* Opaque portion (specific to the cache
implementation) of the cache object */
apr_size_t count; /* Number of body bytes written to the cache
so far */
int complete;
-#ifdef USE_ATOMICS
- apr_atomic_t refcount;
-#else
- apr_size_t refcount;
-#endif
+ apr_uint32_t refcount;
apr_size_t cleanup;
};
Re: cvs commit: httpd-2.0/modules/experimental cache_storage.c cache_util.c
mod_cache.c mod_cache.h mod_
Posted by Bill Stoddard <bi...@wstoddard.com>.
Jean-Jacques Clar wrote:
> Should the type for refcount be apr_atomic_t instead of apr_uint32_t?
>
> It does not build currently for NetWare.
> JJ
>
> >>> stoddard@apache.org 08/26/04 10:59 AM >>>
> stoddard 2004/08/26 09:59:46
>
> Index: mod_cache.h
> ===================================================================
> RCS file: /home/cvs/httpd-2.0/modules/experimental/mod_cache.h,v
> retrieving revision 1.36.2.6
> retrieving revision 1.36.2.7
> diff -u -r1.36.2.6 -r1.36.2.7
> --- mod_cache.h 9 Feb 2004 20:53:16 -0000 1.36.2.6
> +++ mod_cache.h 26 Aug 2004 16:59:44 -0000 1.36.2.7
> @@ -175,29 +172,46 @@
> void *vobj; /* Opaque portion (specific to the cache
> implementation) of the cache object */
> apr_size_t count; /* Number of body bytes written to the cache
> so far */
> int complete;
> -#ifdef USE_ATOMICS
> - apr_atomic_t refcount;
> -#else
> - apr_size_t refcount;
> -#endif
> + apr_uint32_t refcount;
> apr_size_t cleanup;
> };
>
I can make that change. Is this the only netware breakage?
Bill