You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@knox.apache.org by GitBox <gi...@apache.org> on 2021/10/08 08:16:17 UTC
[GitHub] [knox] smolnar82 opened a new pull request #508: KNOX-2678 - Removing expired tokens from in-memory cache properly
smolnar82 opened a new pull request #508:
URL: https://github.com/apache/knox/pull/508
## What changes were proposed in this pull request?
Instead of invoking the entire `evictExpiredTokens` in `DefaultTokenStateService` we only need to call the `removeTokens` method since at this point we already removed expired tokens from the DB and we know the token ID list.
## How was this patch tested?
Manual testing:
- configured Knox to use the JDBC token state service and set the token eviction interval to 30 secs (5 mins is the default)
- I also changed the log level to `DEBUG`
- generated 10 tokens with TTL=1 min
- waited ~30 seconds
- confirmed that all were removed successfully from the DB
- checked the gateway log
```
2021-10-08 10:06:17,526 INFO token.state (JDBCTokenStateService.java:evictExpiredTokens(216)) - Removing 10 expired token(s) from the database: 9c118d02...b546c9202292, 6058370b...e68f85617ab2, c4d3e7ed...db35eb6c82bc, 451b8967...f0f73a4dfa80, 9e5efecb...7e3914bf447c, 7a1cd43c...1ddd6d71d132, 0543ebc5...286128a53628, 77d7c202...da3950e7c919, c5c9d7ee...ed2f7e586789, f1bfe575...1914316db17e
2021-10-08 10:06:17,532 DEBUG token.state (JDBCTokenStateService.java:evictExpiredTokens(219)) - 10 expired tokens have been removed from the database
2021-10-08 10:06:17,533 DEBUG token.state (DefaultTokenStateService.java:removeTokenState(311)) - Removed state for tokens 9c118d02...b546c9202292, 6058370b...e68f85617ab2, c4d3e7ed...db35eb6c82bc, 451b8967...f0f73a4dfa80, 9e5efecb...7e3914bf447c, 7a1cd43c...1ddd6d71d132, 0543ebc5...286128a53628, 77d7c202...da3950e7c919, c5c9d7ee...ed2f7e586789, f1bfe575...1914316db17e
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@knox.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [knox] smolnar82 merged pull request #508: KNOX-2678 - Removing expired tokens from in-memory cache properly
Posted by GitBox <gi...@apache.org>.
smolnar82 merged pull request #508:
URL: https://github.com/apache/knox/pull/508
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@knox.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [knox] smolnar82 commented on pull request #508: KNOX-2678 - Removing expired tokens from in-memory cache properly
Posted by GitBox <gi...@apache.org>.
smolnar82 commented on pull request #508:
URL: https://github.com/apache/knox/pull/508#issuecomment-938441251
Cc. @zeroflag
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@knox.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [knox] zeroflag commented on pull request #508: KNOX-2678 - Removing expired tokens from in-memory cache properly
Posted by GitBox <gi...@apache.org>.
zeroflag commented on pull request #508:
URL: https://github.com/apache/knox/pull/508#issuecomment-938509934
LGTM
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@knox.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org