[GitHub] [echarts] susiwen8 commented on a change in pull request #14393: bug(tooltip): tooltip arrow will follow borderWidth. close #14373

[GitBox <gi...@apache.org>]

susiwen8 commented on a change in pull request #14393:
URL: https://github.com/apache/echarts/pull/14393#discussion_r627008124



##########
File path: src/component/tooltip/TooltipHTMLContent.ts
##########
@@ -60,17 +60,21 @@ function mirrorPos(pos: string): string {
 }
 
 function assembleArrow(
-    backgroundColor: ColorString,
+    tooltipModel: Model<TooltipOption>,
     borderColor: ZRColor,
     arrowPosition: TooltipOption['position']
 ) {
+    const backgroundColor = tooltipModel.get('backgroundColor');
+    const borderWidth = tooltipModel.get('borderWidth');
+

Review comment:
       Just notice a very small thing, could it move this after `if` statement? Since it only affect whatever after `if`.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org