You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@calcite.apache.org by Alessandro Solimando <al...@gmail.com> on 2018/01/20 14:05:52 UTC
mvn test fails for calcite-avatica
Hello everyone,
I have tried to setup calcite-avatica in order to start working on
[CALCITE-508], but mvn test fails:
[...]
> Results :
> Failed tests:
>
> RemoteDriverTest.testBatchInsertWithDates:1379->eachConnection:228->access$1100:91->executeBatchInsertWithDates:1444
> Wrong day for row 0 expected:<20> but was:<19>
>
> RemoteDriverTest.testBatchInsertWithDates:1379->eachConnection:228->access$1100:91->executeBatchInsertWithDates:1444
> Wrong day for row 0 expected:<20> but was:<19>
> Tests run: 219, Failures: 2, Errors: 0, Skipped: 15
> [INFO]
> ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Apache Calcite Avatica Project ..................... SUCCESS [
> 2.026 s]
> [INFO] Apache Calcite Avatica Metrics ..................... SUCCESS [
> 3.124 s]
> [INFO] Apache Calcite Avatica ............................. SUCCESS [
> 22.435 s]
> [INFO] Apache Calcite Avatica Server ...................... FAILURE [
> 11.393 s]
> [...]
Exactly the same result if I import the project in IntelliJ and run
RemoteDriverTest.java from there.
I am in sync with the latest commit
(160e1a9382935997ba5a5ae42510d32734b76906) on the github repo for avatica.
Can someone please try to reproduce this?
Best regards,
Alessandro
Re: mvn test fails for calcite-avatica
Posted by Alessandro Solimando <al...@gmail.com>.
I have opened it (https://issues.apache.org/jira/browse/CALCITE-2145).
I have mimicked the style of other cases, I hope I haven't missed anything
relevant.
On 21 January 2018 at 02:41, Julian Hyde <jh...@apache.org> wrote:
> Yes, please open a JIRA case. Tests should pass in all time zones (and
> locales).
>
> https://issues.apache.org/jira/browse/CALCITE-1667 was supposed to fix
> this problem once and for all, but apparently it did not.
> https://issues.apache.org/jira/browse/CALCITE-2138 is evidence of that
> on the Calcite side.
>
> On Sat, Jan 20, 2018 at 1:21 PM, Alessandro Solimando
> <al...@gmail.com> wrote:
> > Can you try to set your timezone to Europe/Paris (as mine) and re-run? I
> > expect you to be able to reproduce it then.
> >
> > I am debugging the test, I see that everything is supposed to work with
> > UTC.
> > However, somehow the calendar switches to my local timezone when deriving
> > the expected date, and this explains the 1 day gap in the error.
> >
> > By changing line 1391 in RemoteDriverTest.java from
> > "final Calendar calendar = DateTimeUtils.calendar();" (based on UTC)
> > to
> > "final Calendar calendar = Calendar.getInstance(
> DateTimeUtils.DEFAULT_ZONE,
> > Locale.ROOT);"
> > I don't have the error anymore, but I would like to understand what's
> going
> > on more precisely.
> >
> > I know it is way less probable, but I would rule out any difference due
> to
> > the jre version we are using.
> >
> > Could you specify also your setup?
> >
> > If the problem is confirmed shall I open a ticket on Calcite's JIRA?
> >
> >
> > On 20 January 2018 at 15:55, Michael Mior <mm...@uwaterloo.ca> wrote:
> >
> >> All tests pass for me. I'm not too familiar with the Avatica side of
> things
> >> so I don't have any particular suggestions but I'm sure someone else
> will
> >> chime in.
> >>
> >> --
> >> Michael Mior
> >> mmior@apache.org
> >>
> >> 2018-01-20 9:05 GMT-05:00 Alessandro Solimando <
> >> alessandro.solimando@gmail.com>:
> >>
> >> > Hello everyone,
> >> > I have tried to setup calcite-avatica in order to start working on
> >> > [CALCITE-508], but mvn test fails:
> >> >
> >> > [...]
> >> > > Results :
> >> > > Failed tests:
> >> > >
> >> > > RemoteDriverTest.testBatchInsertWithDates:1379-
> >> > >eachConnection:228->access$1100:91->executeBatchInsertWithDates:1444
> >> > > Wrong day for row 0 expected:<20> but was:<19>
> >> > >
> >> > > RemoteDriverTest.testBatchInsertWithDates:1379-
> >> > >eachConnection:228->access$1100:91->executeBatchInsertWithDates:1444
> >> > > Wrong day for row 0 expected:<20> but was:<19>
> >> > > Tests run: 219, Failures: 2, Errors: 0, Skipped: 15
> >> > > [INFO]
> >> > > ------------------------------------------------------------
> >> ------------
> >> > > [INFO] Reactor Summary:
> >> > > [INFO]
> >> > > [INFO] Apache Calcite Avatica Project ..................... SUCCESS
> [
> >> > > 2.026 s]
> >> > > [INFO] Apache Calcite Avatica Metrics ..................... SUCCESS
> [
> >> > > 3.124 s]
> >> > > [INFO] Apache Calcite Avatica ............................. SUCCESS
> [
> >> > > 22.435 s]
> >> > > [INFO] Apache Calcite Avatica Server ...................... FAILURE
> [
> >> > > 11.393 s]
> >> > > [...]
> >> >
> >> >
> >> > Exactly the same result if I import the project in IntelliJ and run
> >> > RemoteDriverTest.java from there.
> >> >
> >> > I am in sync with the latest commit
> >> > (160e1a9382935997ba5a5ae42510d32734b76906) on the github repo for
> >> avatica.
> >> >
> >> > Can someone please try to reproduce this?
> >> >
> >> > Best regards,
> >> > Alessandro
> >> >
> >>
>
Re: mvn test fails for calcite-avatica
Posted by Julian Hyde <jh...@apache.org>.
Yes, please open a JIRA case. Tests should pass in all time zones (and locales).
https://issues.apache.org/jira/browse/CALCITE-1667 was supposed to fix
this problem once and for all, but apparently it did not.
https://issues.apache.org/jira/browse/CALCITE-2138 is evidence of that
on the Calcite side.
On Sat, Jan 20, 2018 at 1:21 PM, Alessandro Solimando
<al...@gmail.com> wrote:
> Can you try to set your timezone to Europe/Paris (as mine) and re-run? I
> expect you to be able to reproduce it then.
>
> I am debugging the test, I see that everything is supposed to work with
> UTC.
> However, somehow the calendar switches to my local timezone when deriving
> the expected date, and this explains the 1 day gap in the error.
>
> By changing line 1391 in RemoteDriverTest.java from
> "final Calendar calendar = DateTimeUtils.calendar();" (based on UTC)
> to
> "final Calendar calendar = Calendar.getInstance(DateTimeUtils.DEFAULT_ZONE,
> Locale.ROOT);"
> I don't have the error anymore, but I would like to understand what's going
> on more precisely.
>
> I know it is way less probable, but I would rule out any difference due to
> the jre version we are using.
>
> Could you specify also your setup?
>
> If the problem is confirmed shall I open a ticket on Calcite's JIRA?
>
>
> On 20 January 2018 at 15:55, Michael Mior <mm...@uwaterloo.ca> wrote:
>
>> All tests pass for me. I'm not too familiar with the Avatica side of things
>> so I don't have any particular suggestions but I'm sure someone else will
>> chime in.
>>
>> --
>> Michael Mior
>> mmior@apache.org
>>
>> 2018-01-20 9:05 GMT-05:00 Alessandro Solimando <
>> alessandro.solimando@gmail.com>:
>>
>> > Hello everyone,
>> > I have tried to setup calcite-avatica in order to start working on
>> > [CALCITE-508], but mvn test fails:
>> >
>> > [...]
>> > > Results :
>> > > Failed tests:
>> > >
>> > > RemoteDriverTest.testBatchInsertWithDates:1379-
>> > >eachConnection:228->access$1100:91->executeBatchInsertWithDates:1444
>> > > Wrong day for row 0 expected:<20> but was:<19>
>> > >
>> > > RemoteDriverTest.testBatchInsertWithDates:1379-
>> > >eachConnection:228->access$1100:91->executeBatchInsertWithDates:1444
>> > > Wrong day for row 0 expected:<20> but was:<19>
>> > > Tests run: 219, Failures: 2, Errors: 0, Skipped: 15
>> > > [INFO]
>> > > ------------------------------------------------------------
>> ------------
>> > > [INFO] Reactor Summary:
>> > > [INFO]
>> > > [INFO] Apache Calcite Avatica Project ..................... SUCCESS [
>> > > 2.026 s]
>> > > [INFO] Apache Calcite Avatica Metrics ..................... SUCCESS [
>> > > 3.124 s]
>> > > [INFO] Apache Calcite Avatica ............................. SUCCESS [
>> > > 22.435 s]
>> > > [INFO] Apache Calcite Avatica Server ...................... FAILURE [
>> > > 11.393 s]
>> > > [...]
>> >
>> >
>> > Exactly the same result if I import the project in IntelliJ and run
>> > RemoteDriverTest.java from there.
>> >
>> > I am in sync with the latest commit
>> > (160e1a9382935997ba5a5ae42510d32734b76906) on the github repo for
>> avatica.
>> >
>> > Can someone please try to reproduce this?
>> >
>> > Best regards,
>> > Alessandro
>> >
>>
Re: mvn test fails for calcite-avatica
Posted by Alessandro Solimando <al...@gmail.com>.
Can you try to set your timezone to Europe/Paris (as mine) and re-run? I
expect you to be able to reproduce it then.
I am debugging the test, I see that everything is supposed to work with
UTC.
However, somehow the calendar switches to my local timezone when deriving
the expected date, and this explains the 1 day gap in the error.
By changing line 1391 in RemoteDriverTest.java from
"final Calendar calendar = DateTimeUtils.calendar();" (based on UTC)
to
"final Calendar calendar = Calendar.getInstance(DateTimeUtils.DEFAULT_ZONE,
Locale.ROOT);"
I don't have the error anymore, but I would like to understand what's going
on more precisely.
I know it is way less probable, but I would rule out any difference due to
the jre version we are using.
Could you specify also your setup?
If the problem is confirmed shall I open a ticket on Calcite's JIRA?
On 20 January 2018 at 15:55, Michael Mior <mm...@uwaterloo.ca> wrote:
> All tests pass for me. I'm not too familiar with the Avatica side of things
> so I don't have any particular suggestions but I'm sure someone else will
> chime in.
>
> --
> Michael Mior
> mmior@apache.org
>
> 2018-01-20 9:05 GMT-05:00 Alessandro Solimando <
> alessandro.solimando@gmail.com>:
>
> > Hello everyone,
> > I have tried to setup calcite-avatica in order to start working on
> > [CALCITE-508], but mvn test fails:
> >
> > [...]
> > > Results :
> > > Failed tests:
> > >
> > > RemoteDriverTest.testBatchInsertWithDates:1379-
> > >eachConnection:228->access$1100:91->executeBatchInsertWithDates:1444
> > > Wrong day for row 0 expected:<20> but was:<19>
> > >
> > > RemoteDriverTest.testBatchInsertWithDates:1379-
> > >eachConnection:228->access$1100:91->executeBatchInsertWithDates:1444
> > > Wrong day for row 0 expected:<20> but was:<19>
> > > Tests run: 219, Failures: 2, Errors: 0, Skipped: 15
> > > [INFO]
> > > ------------------------------------------------------------
> ------------
> > > [INFO] Reactor Summary:
> > > [INFO]
> > > [INFO] Apache Calcite Avatica Project ..................... SUCCESS [
> > > 2.026 s]
> > > [INFO] Apache Calcite Avatica Metrics ..................... SUCCESS [
> > > 3.124 s]
> > > [INFO] Apache Calcite Avatica ............................. SUCCESS [
> > > 22.435 s]
> > > [INFO] Apache Calcite Avatica Server ...................... FAILURE [
> > > 11.393 s]
> > > [...]
> >
> >
> > Exactly the same result if I import the project in IntelliJ and run
> > RemoteDriverTest.java from there.
> >
> > I am in sync with the latest commit
> > (160e1a9382935997ba5a5ae42510d32734b76906) on the github repo for
> avatica.
> >
> > Can someone please try to reproduce this?
> >
> > Best regards,
> > Alessandro
> >
>
Re: mvn test fails for calcite-avatica
Posted by Michael Mior <mm...@uwaterloo.ca>.
All tests pass for me. I'm not too familiar with the Avatica side of things
so I don't have any particular suggestions but I'm sure someone else will
chime in.
--
Michael Mior
mmior@apache.org
2018-01-20 9:05 GMT-05:00 Alessandro Solimando <
alessandro.solimando@gmail.com>:
> Hello everyone,
> I have tried to setup calcite-avatica in order to start working on
> [CALCITE-508], but mvn test fails:
>
> [...]
> > Results :
> > Failed tests:
> >
> > RemoteDriverTest.testBatchInsertWithDates:1379-
> >eachConnection:228->access$1100:91->executeBatchInsertWithDates:1444
> > Wrong day for row 0 expected:<20> but was:<19>
> >
> > RemoteDriverTest.testBatchInsertWithDates:1379-
> >eachConnection:228->access$1100:91->executeBatchInsertWithDates:1444
> > Wrong day for row 0 expected:<20> but was:<19>
> > Tests run: 219, Failures: 2, Errors: 0, Skipped: 15
> > [INFO]
> > ------------------------------------------------------------------------
> > [INFO] Reactor Summary:
> > [INFO]
> > [INFO] Apache Calcite Avatica Project ..................... SUCCESS [
> > 2.026 s]
> > [INFO] Apache Calcite Avatica Metrics ..................... SUCCESS [
> > 3.124 s]
> > [INFO] Apache Calcite Avatica ............................. SUCCESS [
> > 22.435 s]
> > [INFO] Apache Calcite Avatica Server ...................... FAILURE [
> > 11.393 s]
> > [...]
>
>
> Exactly the same result if I import the project in IntelliJ and run
> RemoteDriverTest.java from there.
>
> I am in sync with the latest commit
> (160e1a9382935997ba5a5ae42510d32734b76906) on the github repo for avatica.
>
> Can someone please try to reproduce this?
>
> Best regards,
> Alessandro
>