You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@pinot.apache.org by GitBox <gi...@apache.org> on 2019/10/28 16:28:03 UTC

[GitHub] [incubator-pinot] npawar commented on issue #3849: Using PinotFS interface instead of local file to download a segment f…

npawar commented on issue #3849: Using PinotFS interface instead of local file to download a segment f…
URL: https://github.com/apache/incubator-pinot/pull/3849#issuecomment-547029458
 
 
   Let's avoid the extra copy in the localFS case. Like you suggested, adding an isLocal check should be an okay approach for now.
   One thing we could do is  push the entire logic of fetching file and building Response into the PinotFS interface. But that wouldn't be very clean either, as it is too specific a task for an FS to perform. 
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org