[GitHub] [lucene-solr] dweiss commented on a change in pull request #2203: LUCENE-9665: Hunspell: support default encoding

[GitBox <gi...@apache.org>]

dweiss commented on a change in pull request #2203:
URL: https://github.com/apache/lucene-solr/pull/2203#discussion_r557667155



##########
File path: lucene/analysis/common/src/java/org/apache/lucene/analysis/hunspell/Dictionary.java
##########
@@ -98,6 +98,7 @@
   // TODO: really for suffixes we should reverse the automaton and run them backwards
   private static final String PREFIX_CONDITION_REGEX_PATTERN = "%s.*";
   private static final String SUFFIX_CONDITION_REGEX_PATTERN = ".*%s";
+  static final String DEFAULT_ENCODING = "ISO8859-1";

Review comment:
       This should reference a constant in StandardCharsets (and get the name from there).




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org