You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@iotdb.apache.org by GitBox <gi...@apache.org> on 2021/11/12 09:36:57 UTC
[GitHub] [iotdb] ericpai opened a new pull request #4373: Fix bug of descending aggregation query
ericpai opened a new pull request #4373:
URL: https://github.com/apache/iotdb/pull/4373
See JIRA https://issues.apache.org/jira/browse/IOTDB-1997
The following bugs are fixed:
1. LocalQueryExecutor passes `AggregationResult` list into an ascending and decending one to create proper reader with the `AggregationResult.isAscending()`.
2. Fix the bug of `FirstValueDescAggrResult` implementation.
3. Add java doc and unit test cases.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] ericpai commented on pull request #4373: Fix bug of descending aggregation query
Posted by GitBox <gi...@apache.org>.
ericpai commented on pull request #4373:
URL: https://github.com/apache/iotdb/pull/4373#issuecomment-966959000
@Alima777 @JackieTien97 Thanks for reviewing these codes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] qiaojialin commented on pull request #4373: [IOTDB-1997] Fix bug of descending aggregation query
Posted by GitBox <gi...@apache.org>.
qiaojialin commented on pull request #4373:
URL: https://github.com/apache/iotdb/pull/4373#issuecomment-967759810
Hi, please add the Jira id in the PR name when creating, then it will be linked in the Jira
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] JackieTien97 merged pull request #4373: [IOTDB-1997] Fix bug of descending aggregation query
Posted by GitBox <gi...@apache.org>.
JackieTien97 merged pull request #4373:
URL: https://github.com/apache/iotdb/pull/4373
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org