You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lens.apache.org by Rajat Khandelwal <ra...@gmail.com> on 2015/07/22 15:24:21 UTC
Review Request 36685: LENS-682: XML marshalling errors not descriptive
enough on CLI
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36685/
-----------------------------------------------------------
Review request for lens.
Bugs: LENS-682
https://issues.apache.org/jira/browse/LENS-682
Repository: lens
Description
-------
Diffs
-----
lens-api/src/main/java/org/apache/lens/api/APIResult.java d0483731e930eb456935041c6b73be3665b199bb
lens-client/src/main/java/org/apache/lens/client/LensMetadataClient.java 4bec6add6ab2d8e7110a135cf1056fa5ecd986a0
Diff: https://reviews.apache.org/r/36685/diff/
Testing
-------
```
lens-shell>fact add single-partition fact storage /Users/rajat.khandelwal/raw_partition.xml
<?xml version="1.0" encoding="utf-8" standalone="yes"?><result><status>failed</status><message>cvc-complex-type.2.4.a: invalid content was found starting with element 'knon_time_partition_spec'. one of '{"uri:lens:cube:0.1":non_time_partition_spec, "uri:lens:cube:0.1":time_partition_spec, "uri:lens:cube:0.1":full_partition_spec, "uri:lens:cube:0.1":partition_parameters, "uri:lens:cube:0.1":serde_parameters}' is expected.</message></result>
lens-shell>
```
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]
[INFO] Lens Checkstyle Rules ............................. SUCCESS [2.014s]
[INFO] Lens .............................................. SUCCESS [2.836s]
[INFO] Lens API .......................................... SUCCESS [23.340s]
[INFO] Lens API for server and extensions ................ SUCCESS [20.332s]
[INFO] Lens Cube ......................................... SUCCESS [4:20.623s]
[INFO] Lens DB storage ................................... SUCCESS [19.706s]
[INFO] Lens Query Library ................................ SUCCESS [14.357s]
[INFO] Lens Hive Driver .................................. SUCCESS [2:48.248s]
[INFO] Lens Driver for JDBC .............................. SUCCESS [34.321s]
[INFO] Lens Server ....................................... SUCCESS [5:24.965s]
[INFO] Lens client ....................................... SUCCESS [37.547s]
[INFO] Lens CLI .......................................... SUCCESS [2:38.158s]
[INFO] Lens Examples ..................................... SUCCESS [8.075s]
[INFO] Lens Distribution ................................. SUCCESS [8.551s]
[INFO] Lens ML Lib ....................................... SUCCESS [1:20.390s]
[INFO] Lens ML Ext Distribution .......................... SUCCESS [1.679s]
[INFO] Lens Regression ................................... SUCCESS [11.775s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 19:37.760s
[INFO] Finished at: Wed Jul 22 08:10:41 UTC 2015
[INFO] Final Memory: 193M/2304M
[INFO] ------------------------------------------------------------------------
Thanks,
Rajat Khandelwal
Re: Review Request 36685: LENS-682: XML marshalling errors not
descriptive enough on CLI
Posted by Rajat Khandelwal <ra...@gmail.com>.
> On July 23, 2015, 10:48 a.m., Amareshwari Sriramadasu wrote:
> > lens-client/src/main/java/org/apache/lens/client/LensMetadataClient.java, lines 502-513
> > <https://reviews.apache.org/r/36685/diff/1/?file=1018788#file1018788line502>
> >
> > Not necessary any more? Why?
wasn't used anywhere.
- Rajat
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36685/#review92724
-----------------------------------------------------------
On July 22, 2015, 6:54 p.m., Rajat Khandelwal wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36685/
> -----------------------------------------------------------
>
> (Updated July 22, 2015, 6:54 p.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-682
> https://issues.apache.org/jira/browse/LENS-682
>
>
> Repository: lens
>
>
> Description
> -------
>
>
> Diffs
> -----
>
> lens-api/src/main/java/org/apache/lens/api/APIResult.java d0483731e930eb456935041c6b73be3665b199bb
> lens-client/src/main/java/org/apache/lens/client/LensMetadataClient.java 4bec6add6ab2d8e7110a135cf1056fa5ecd986a0
>
> Diff: https://reviews.apache.org/r/36685/diff/
>
>
> Testing
> -------
>
> ```
>
> lens-shell>fact add single-partition fact storage /Users/rajat.khandelwal/raw_partition.xml
> <?xml version="1.0" encoding="utf-8" standalone="yes"?><result><status>failed</status><message>cvc-complex-type.2.4.a: invalid content was found starting with element 'knon_time_partition_spec'. one of '{"uri:lens:cube:0.1":non_time_partition_spec, "uri:lens:cube:0.1":time_partition_spec, "uri:lens:cube:0.1":full_partition_spec, "uri:lens:cube:0.1":partition_parameters, "uri:lens:cube:0.1":serde_parameters}' is expected.</message></result>
> lens-shell>
>
> ```
>
>
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Lens Checkstyle Rules ............................. SUCCESS [2.014s]
> [INFO] Lens .............................................. SUCCESS [2.836s]
> [INFO] Lens API .......................................... SUCCESS [23.340s]
> [INFO] Lens API for server and extensions ................ SUCCESS [20.332s]
> [INFO] Lens Cube ......................................... SUCCESS [4:20.623s]
> [INFO] Lens DB storage ................................... SUCCESS [19.706s]
> [INFO] Lens Query Library ................................ SUCCESS [14.357s]
> [INFO] Lens Hive Driver .................................. SUCCESS [2:48.248s]
> [INFO] Lens Driver for JDBC .............................. SUCCESS [34.321s]
> [INFO] Lens Server ....................................... SUCCESS [5:24.965s]
> [INFO] Lens client ....................................... SUCCESS [37.547s]
> [INFO] Lens CLI .......................................... SUCCESS [2:38.158s]
> [INFO] Lens Examples ..................................... SUCCESS [8.075s]
> [INFO] Lens Distribution ................................. SUCCESS [8.551s]
> [INFO] Lens ML Lib ....................................... SUCCESS [1:20.390s]
> [INFO] Lens ML Ext Distribution .......................... SUCCESS [1.679s]
> [INFO] Lens Regression ................................... SUCCESS [11.775s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 19:37.760s
> [INFO] Finished at: Wed Jul 22 08:10:41 UTC 2015
> [INFO] Final Memory: 193M/2304M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Rajat Khandelwal
>
>
Re: Review Request 36685: LENS-682: XML marshalling errors not
descriptive enough on CLI
Posted by Amareshwari Sriramadasu <am...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36685/#review92724
-----------------------------------------------------------
lens-client/src/main/java/org/apache/lens/client/LensMetadataClient.java
<https://reviews.apache.org/r/36685/#comment146971>
Not necessary any more? Why?
- Amareshwari Sriramadasu
On July 22, 2015, 1:24 p.m., Rajat Khandelwal wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36685/
> -----------------------------------------------------------
>
> (Updated July 22, 2015, 1:24 p.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-682
> https://issues.apache.org/jira/browse/LENS-682
>
>
> Repository: lens
>
>
> Description
> -------
>
>
> Diffs
> -----
>
> lens-api/src/main/java/org/apache/lens/api/APIResult.java d0483731e930eb456935041c6b73be3665b199bb
> lens-client/src/main/java/org/apache/lens/client/LensMetadataClient.java 4bec6add6ab2d8e7110a135cf1056fa5ecd986a0
>
> Diff: https://reviews.apache.org/r/36685/diff/
>
>
> Testing
> -------
>
> ```
>
> lens-shell>fact add single-partition fact storage /Users/rajat.khandelwal/raw_partition.xml
> <?xml version="1.0" encoding="utf-8" standalone="yes"?><result><status>failed</status><message>cvc-complex-type.2.4.a: invalid content was found starting with element 'knon_time_partition_spec'. one of '{"uri:lens:cube:0.1":non_time_partition_spec, "uri:lens:cube:0.1":time_partition_spec, "uri:lens:cube:0.1":full_partition_spec, "uri:lens:cube:0.1":partition_parameters, "uri:lens:cube:0.1":serde_parameters}' is expected.</message></result>
> lens-shell>
>
> ```
>
>
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Lens Checkstyle Rules ............................. SUCCESS [2.014s]
> [INFO] Lens .............................................. SUCCESS [2.836s]
> [INFO] Lens API .......................................... SUCCESS [23.340s]
> [INFO] Lens API for server and extensions ................ SUCCESS [20.332s]
> [INFO] Lens Cube ......................................... SUCCESS [4:20.623s]
> [INFO] Lens DB storage ................................... SUCCESS [19.706s]
> [INFO] Lens Query Library ................................ SUCCESS [14.357s]
> [INFO] Lens Hive Driver .................................. SUCCESS [2:48.248s]
> [INFO] Lens Driver for JDBC .............................. SUCCESS [34.321s]
> [INFO] Lens Server ....................................... SUCCESS [5:24.965s]
> [INFO] Lens client ....................................... SUCCESS [37.547s]
> [INFO] Lens CLI .......................................... SUCCESS [2:38.158s]
> [INFO] Lens Examples ..................................... SUCCESS [8.075s]
> [INFO] Lens Distribution ................................. SUCCESS [8.551s]
> [INFO] Lens ML Lib ....................................... SUCCESS [1:20.390s]
> [INFO] Lens ML Ext Distribution .......................... SUCCESS [1.679s]
> [INFO] Lens Regression ................................... SUCCESS [11.775s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 19:37.760s
> [INFO] Finished at: Wed Jul 22 08:10:41 UTC 2015
> [INFO] Final Memory: 193M/2304M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Rajat Khandelwal
>
>
Re: Review Request 36685: LENS-682: XML marshalling errors not
descriptive enough on CLI
Posted by Amareshwari Sriramadasu <am...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36685/#review92734
-----------------------------------------------------------
Ship it!
Ship It!
- Amareshwari Sriramadasu
On July 22, 2015, 1:24 p.m., Rajat Khandelwal wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36685/
> -----------------------------------------------------------
>
> (Updated July 22, 2015, 1:24 p.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-682
> https://issues.apache.org/jira/browse/LENS-682
>
>
> Repository: lens
>
>
> Description
> -------
>
>
> Diffs
> -----
>
> lens-api/src/main/java/org/apache/lens/api/APIResult.java d0483731e930eb456935041c6b73be3665b199bb
> lens-client/src/main/java/org/apache/lens/client/LensMetadataClient.java 4bec6add6ab2d8e7110a135cf1056fa5ecd986a0
>
> Diff: https://reviews.apache.org/r/36685/diff/
>
>
> Testing
> -------
>
> ```
>
> lens-shell>fact add single-partition fact storage /Users/rajat.khandelwal/raw_partition.xml
> <?xml version="1.0" encoding="utf-8" standalone="yes"?><result><status>failed</status><message>cvc-complex-type.2.4.a: invalid content was found starting with element 'knon_time_partition_spec'. one of '{"uri:lens:cube:0.1":non_time_partition_spec, "uri:lens:cube:0.1":time_partition_spec, "uri:lens:cube:0.1":full_partition_spec, "uri:lens:cube:0.1":partition_parameters, "uri:lens:cube:0.1":serde_parameters}' is expected.</message></result>
> lens-shell>
>
> ```
>
>
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Lens Checkstyle Rules ............................. SUCCESS [2.014s]
> [INFO] Lens .............................................. SUCCESS [2.836s]
> [INFO] Lens API .......................................... SUCCESS [23.340s]
> [INFO] Lens API for server and extensions ................ SUCCESS [20.332s]
> [INFO] Lens Cube ......................................... SUCCESS [4:20.623s]
> [INFO] Lens DB storage ................................... SUCCESS [19.706s]
> [INFO] Lens Query Library ................................ SUCCESS [14.357s]
> [INFO] Lens Hive Driver .................................. SUCCESS [2:48.248s]
> [INFO] Lens Driver for JDBC .............................. SUCCESS [34.321s]
> [INFO] Lens Server ....................................... SUCCESS [5:24.965s]
> [INFO] Lens client ....................................... SUCCESS [37.547s]
> [INFO] Lens CLI .......................................... SUCCESS [2:38.158s]
> [INFO] Lens Examples ..................................... SUCCESS [8.075s]
> [INFO] Lens Distribution ................................. SUCCESS [8.551s]
> [INFO] Lens ML Lib ....................................... SUCCESS [1:20.390s]
> [INFO] Lens ML Ext Distribution .......................... SUCCESS [1.679s]
> [INFO] Lens Regression ................................... SUCCESS [11.775s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 19:37.760s
> [INFO] Finished at: Wed Jul 22 08:10:41 UTC 2015
> [INFO] Final Memory: 193M/2304M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Rajat Khandelwal
>
>