You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@logging.apache.org by GitBox <gi...@apache.org> on 2021/12/11 05:48:35 UTC

[GitHub] [logging-log4j2] Francis-FY opened a new pull request #617: LOG4J2-3204 - Correct SpringLookup package name in Interpolator

Francis-FY opened a new pull request #617:
URL: https://github.com/apache/logging-log4j2/pull/617


   Correct SpringLookup package name in the constructor of Interpolator


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [logging-log4j2] vy commented on pull request #617: LOG4J2-3204 - Correct SpringLookup package name in Interpolator

Posted by GitBox <gi...@apache.org>.
vy commented on pull request #617:
URL: https://github.com/apache/logging-log4j2/pull/617#issuecomment-1000845984


   LGTM. Thanks so much for the contribution @Francis-FY!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [logging-log4j2] vy merged pull request #617: LOG4J2-3204 Correct SpringLookup package name in Interpolator.

Posted by GitBox <gi...@apache.org>.
vy merged pull request #617:
URL: https://github.com/apache/logging-log4j2/pull/617


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [logging-log4j2] vy commented on pull request #617: LOG4J2-3204 Correct SpringLookup package name in Interpolator.

Posted by GitBox <gi...@apache.org>.
vy commented on pull request #617:
URL: https://github.com/apache/logging-log4j2/pull/617#issuecomment-1000847776


   Cherry-picked to `master`.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [logging-log4j2] quaff commented on pull request #617: LOG4J2-3204 - Correct SpringLookup package name in Interpolator

Posted by GitBox <gi...@apache.org>.
quaff commented on pull request #617:
URL: https://github.com/apache/logging-log4j2/pull/617#issuecomment-995530594


   This fix works. 
   Before this commit `<Property name="app">${spring:spring.application.name:-unknown}</Property>` will always be `unknown` even `spring.application.name` present.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [logging-log4j2] quaff commented on pull request #617: LOG4J2-3204 - Correct SpringLookup package name in Interpolator

Posted by GitBox <gi...@apache.org>.
quaff commented on pull request #617:
URL: https://github.com/apache/logging-log4j2/pull/617#issuecomment-997667402


   @rgoers , Please take a look at this.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org