[GitHub] [superset] villebro commented on a change in pull request #16397: fix(api): return total count on related endpoint

[GitBox <gi...@apache.org>]

villebro commented on a change in pull request #16397:
URL: https://github.com/apache/superset/pull/16397#discussion_r694478905



##########
File path: superset/views/base_api.py
##########
@@ -490,6 +490,12 @@ def related(self, column_name: str, **kwargs: Any) -> FlaskResponse:
 
         # handle pagination
         page, page_size = self._handle_page_args(args)
+
+        ids = args.get("include_ids")
+        if page and ids:
+            # pagination with forced ids is not supported
+            return self.response_400()

Review comment:
       That's a good idea - will update 👍 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org