You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@whimsical.apache.org by br...@apache.org on 2017/07/23 12:54:51 UTC
Re: [whimsy] 01/02: update tests for layout changes
I hope these are correct - I aligned them to the HTML structure that I see in the current version of Whimsy.
It seems that the tests are not always run - is there a CI environment that is doing this, or would it be worth me looking into adding it to Jenkins?
Cheers,
Brett
> On 23 Jul 2017, at 10:49 pm, brett@apache.org wrote:
>
> This is an automated email from the ASF dual-hosted git repository.
>
> brett pushed a commit to branch master
> in repository https://gitbox.apache.org/repos/asf/whimsy.git
>
> commit dad6ca8e0fe4393388521972026a2e17b47a658f
> Author: Brett Porter <br...@apache.org>
> AuthorDate: Sun Jul 23 22:45:56 2017 +1000
>
> update tests for layout changes
> ---
> www/board/agenda/spec/other_views_spec.rb | 10 +++++-----
> 1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/www/board/agenda/spec/other_views_spec.rb b/www/board/agenda/spec/other_views_spec.rb
> index f363b4d..7ce38df 100644
> --- a/www/board/agenda/spec/other_views_spec.rb
> +++ b/www/board/agenda/spec/other_views_spec.rb
> @@ -16,7 +16,7 @@ feature 'other reports' do
> visit '/2015-01-21/comments'
>
> # unseen items
> - expect(page).to have_selector 'h4 a', text: 'Curator'
> + expect(page).to have_selector 'a.h4', text: 'Curator'
> expect(page).to have_selector 'pre',
> text: /last PMC member and committer additions/
>
> @@ -68,20 +68,20 @@ feature 'other reports' do
> visit '/2015-01-21/shepherd/Sam'
>
> # action items
> - expect(page).to have_selector 'pre.report span',
> + expect(page).to have_selector 'pre.report',
> text: '* Sam: pursue a report for Abdera'
> expect(page).to have_selector 'pre.report em',
> text: "Clarification provided in this month's report."
>
> # committee reports
> - expect(page).to have_selector 'h3.reviewed a[href="shepherd/queue/Flink"]',
> + expect(page).to have_selector 'a.reviewed[href="shepherd/queue/Flink"]',
> text: 'Flink'
> - expect(page).to have_selector 'a.default', text: 'Airavata'
> + expect(page).to have_selector 'a.missing', text: 'Airavata'
> expect(page).to have_selector 'h4', text: 'Comments'
> expect(page).to have_selector 'pre.comment span',
> text: 'cm: great report!'
> expect(page).to have_selector 'h4', text: 'Action Items'
> - expect(page).to have_selector 'pre.report span',
> + expect(page).to have_selector 'pre.report',
> text: '* Chris: Please clarify what "voted on" means'
> expect(page).to have_selector 'button[data-attach=AY]', text: 'flag'
> expect(page).to have_selector '.shepherd button', text: 'send email'
>
> --
> To stop receiving notification emails like this one, please contact
> "commits@whimsical.apache.org" <co...@whimsical.apache.org>.
Re: [whimsy] 01/02: update tests for layout changes
Posted by Sam Ruby <ru...@intertwingly.net>.
On Sun, Jul 23, 2017 at 6:54 AM, <br...@apache.org> wrote:
> I hope these are correct - I aligned them to the HTML structure that I see in the current version of Whimsy.
>
> It seems that the tests are not always run - is there a CI environment that is doing this, or would it be worth me looking into adding it to Jenkins?
Please do!
Once a CI environment is set up, I can look into adding test for other tools.
> Cheers,
> Brett
- Sam Ruby
>> On 23 Jul 2017, at 10:49 pm, brett@apache.org wrote:
>>
>> This is an automated email from the ASF dual-hosted git repository.
>>
>> brett pushed a commit to branch master
>> in repository https://gitbox.apache.org/repos/asf/whimsy.git
>>
>> commit dad6ca8e0fe4393388521972026a2e17b47a658f
>> Author: Brett Porter <br...@apache.org>
>> AuthorDate: Sun Jul 23 22:45:56 2017 +1000
>>
>> update tests for layout changes
>> ---
>> www/board/agenda/spec/other_views_spec.rb | 10 +++++-----
>> 1 file changed, 5 insertions(+), 5 deletions(-)
>>
>> diff --git a/www/board/agenda/spec/other_views_spec.rb b/www/board/agenda/spec/other_views_spec.rb
>> index f363b4d..7ce38df 100644
>> --- a/www/board/agenda/spec/other_views_spec.rb
>> +++ b/www/board/agenda/spec/other_views_spec.rb
>> @@ -16,7 +16,7 @@ feature 'other reports' do
>> visit '/2015-01-21/comments'
>>
>> # unseen items
>> - expect(page).to have_selector 'h4 a', text: 'Curator'
>> + expect(page).to have_selector 'a.h4', text: 'Curator'
>> expect(page).to have_selector 'pre',
>> text: /last PMC member and committer additions/
>>
>> @@ -68,20 +68,20 @@ feature 'other reports' do
>> visit '/2015-01-21/shepherd/Sam'
>>
>> # action items
>> - expect(page).to have_selector 'pre.report span',
>> + expect(page).to have_selector 'pre.report',
>> text: '* Sam: pursue a report for Abdera'
>> expect(page).to have_selector 'pre.report em',
>> text: "Clarification provided in this month's report."
>>
>> # committee reports
>> - expect(page).to have_selector 'h3.reviewed a[href="shepherd/queue/Flink"]',
>> + expect(page).to have_selector 'a.reviewed[href="shepherd/queue/Flink"]',
>> text: 'Flink'
>> - expect(page).to have_selector 'a.default', text: 'Airavata'
>> + expect(page).to have_selector 'a.missing', text: 'Airavata'
>> expect(page).to have_selector 'h4', text: 'Comments'
>> expect(page).to have_selector 'pre.comment span',
>> text: 'cm: great report!'
>> expect(page).to have_selector 'h4', text: 'Action Items'
>> - expect(page).to have_selector 'pre.report span',
>> + expect(page).to have_selector 'pre.report',
>> text: '* Chris: Please clarify what "voted on" means'
>> expect(page).to have_selector 'button[data-attach=AY]', text: 'flag'
>> expect(page).to have_selector '.shepherd button', text: 'send email'
>>
>> --
>> To stop receiving notification emails like this one, please contact
>> "commits@whimsical.apache.org" <co...@whimsical.apache.org>.
>