You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@maka.apache.org by "me2seeks (via GitHub)" <gi...@apache.org> on 2026/10/19 16:24:55 UTC
[PR] fix(desktop): resolve assistant projects on Host-owned workspaces [maka]
me2seeks opened a new pull request, #6176:
URL: https://github.com/apache/maka/pull/6176
Opening Personal Assistant on a default WSL/remote Host with available projects but no persisted current-project selection fails with `Select a project from the remote Runtime Host first`. The assistant now resolves a usable project from that Host's catalog and creates the conversation on the captured Host before binding it.
Closes #6175.
- Preserve usable default/current project preferences (including project aliases); otherwise use an available, non-archived project when the Host requires one. Local projectless assistants retain dedicated task directories. Hosts without usable projects receive an actionable add-project error.
- Thread the captured Host through navigation and add an optional Host argument to `sessions.create`, using existing scope validation. Keep immediate Host creation: `newTasks.create` stages a Client draft and cannot satisfy assistant binding.
- Keep the remote Client-path guard and avoid changing persisted project preferences. This is independent of #6163's remote tool feature; no competing implementation was found.
Validation:
- 40/40 focused tests pass across assistant project/navigation, session workspace resolution, preload routing, and session catalog IPC. Restoring the old adapter reproduces the original remote-project guard in both environment and remote regressions.
- Desktop main, renderer and preload TypeScript checks pass. Renderer architecture, changed-file lint and `git diff --check` pass. Local review completed.
- Live Windows development Desktop at main `b0ed5707ff` with default WSL Host: confirmed two available projects, no current-project preference, no assistant binding, and failure of the original creation call. Executed the worktree's bundled adapter/navigation through CDP: Host session creation and assistant binding succeed; two opens reuse one session on the WSL project. The normal Personal Assistant button then opens that conversation. No model prompt was sent. Default Host and project preferences were unchanged; the reusable assistant conversation remains.
- The live probe used the already-running preload with an unchanged default Host; explicit cross-Host routing and stale-identity refusal are covered by the bundled preload regression. No Windows source changes/restart, full installer build, or complete repository suite was performed.
中文：已在真实 Windows + WSL Desktop 复现并验证修复。个人助手显式选择所属 Host 的可用项目，创建后再绑定；本地仍使用独立任务目录。新增 Host 参数避免默认 Host 切换时串建会话；不放宽远端路径守卫，不改项目偏好。
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For additional commands, e-mail: commits-help@maka.apache.org
Re: [PR] fix(assistant): allocate a Host workspace when remote project resolution fails [maka]
Posted by "me2seeks (via GitHub)" <gi...@apache.org>.
me2seeks merged PR #6176:
URL: https://github.com/apache/maka/pull/6176
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For additional commands, e-mail: commits-help@maka.apache.org
Re: [PR] fix(assistant): allocate a Host workspace when remote project resolution fails [maka]
Posted by "me2seeks (via GitHub)" <gi...@apache.org>.
me2seeks commented on PR #6176:
URL: https://github.com/apache/maka/pull/6176#issuecomment-6288923539
Codex follow-up: rebased #6176 onto current main `dc4515cd6e` and pushed head `467e16e6f8` with an exact-head lease. Resolved both conflicts by retaining main's `prepareBotWake` / Bot model synchronization alongside the workspace allocator in production composition and the assistant test fixture. The range-diff preserves both original feature commits.
#6183 is now included, and both Kimi K3 prompt-suggestion metadata scenarios pass. All 96 focused checks, root build/typecheck/lint/format, Desktop/UI Knip, strict renderer architecture, headers, Windows inventory and protocol guard pass locally.
Main still declares epoch 225; #6091 and #6163 remain open. This PR keeps 226 and must recheck the epoch before merging. No additional verified actionable P3 was found: the reported missing-model residue is fixed, while the acknowledged check-then-act window is documented rather than adding unsafe cleanup after an ambiguous Session-create response.
The PR description/checklist now reflects this rebased head and current validation. This automated response is not independent human approval.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For additional commands, e-mail: commits-help@maka.apache.org
Re: [PR] fix(assistant): allocate a Host workspace when remote project resolution fails [maka]
Posted by "me2seeks (via GitHub)" <gi...@apache.org>.
me2seeks commented on code in PR #6176:
URL: https://github.com/apache/maka/pull/6176#discussion_r4321066699
##########
apps/desktop/src/main/runtime-host-session-catalog-ipc-main.ts:
##########
@@ -155,10 +158,13 @@ export function registerRuntimeHostSessionCatalogIpc(
pendingCleanup.add(sessionId);
});
ipcMain.handle('sessions:create', async (_event, input?: CreateSessionRequestInput) => {
- const workspace = await deps.resolveCreateProject({
- ...(input?.cwd === undefined ? {} : { cwd: input.cwd }),
- ...(input?.projectId === undefined ? {} : { projectId: input.projectId }),
- });
+ const workspace = await deps.resolveCreateProject(
+ {
+ ...(input?.cwd === undefined ? {} : { cwd: input.cwd }),
+ ...(input?.projectId === undefined ? {} : { projectId: input.projectId }),
+ },
+ input?.labels?.includes('personal-assistant') ? deps.allocateAssistantWorkspace : undefined,
Review Comment:
Fixed in cc1978e2af. Before allocating a task directory or registering its Project, the Host now calls the same default-target resolver used by Session creation, which validates the configured model and execution policy. If no model is configured, allocation fails before creating filesystem/catalog state. Added a production-composition regression that verifies this leaves zero Sessions, Projects, or task directories; after configuring a model, allocation, normal Session creation/binding, and restart reuse succeed. The preflight does not clean up after Session creation, so an ambiguous create result cannot cause deletion of a workspace that may be in use.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For additional commands, e-mail: commits-help@maka.apache.org
Re: [PR] fix(assistant): allocate a Host workspace when remote project resolution fails [maka]
Posted by "Astro-Han (via GitHub)" <gi...@apache.org>.
Astro-Han commented on code in PR #6176:
URL: https://github.com/apache/maka/pull/6176#discussion_r4321012728
##########
apps/desktop/src/main/runtime-host-session-catalog-ipc-main.ts:
##########
@@ -155,10 +158,13 @@ export function registerRuntimeHostSessionCatalogIpc(
pendingCleanup.add(sessionId);
});
ipcMain.handle('sessions:create', async (_event, input?: CreateSessionRequestInput) => {
- const workspace = await deps.resolveCreateProject({
- ...(input?.cwd === undefined ? {} : { cwd: input.cwd }),
- ...(input?.projectId === undefined ? {} : { projectId: input.projectId }),
- });
+ const workspace = await deps.resolveCreateProject(
+ {
+ ...(input?.cwd === undefined ? {} : { cwd: input.cwd }),
+ ...(input?.projectId === undefined ? {} : { projectId: input.projectId }),
+ },
+ input?.labels?.includes('personal-assistant') ? deps.allocateAssistantWorkspace : undefined,
Review Comment:
[P3] Avoid retaining a fresh workspace when session creation definitely fails
This callback allocates and registers the Host project before `createSession` validates whether a session can be created. With no default model configured, I ran three attempts through this handler/resolver and the production Host composition: all three session creations failed, but the catalog retained three new projects and the filesystem retained three empty task directories (zero sessions and no assistant binding). Repeated retries therefore accumulate unused projects. Consider preflighting definite prerequisites, or reclaiming/reusing allocations proven to be unused after a definite failure. Cleanup must account for an ambiguous response where session creation may already have committed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For additional commands, e-mail: commits-help@maka.apache.org