You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/10/18 16:45:24 UTC

[GitHub] [airflow] kaxil commented on a change in pull request #11541: Optimizes CI builds heavily with selective checks

kaxil commented on a change in pull request #11541:
URL: https://github.com/apache/airflow/pull/11541#discussion_r507185051



##########
File path: .github/workflows/build-images-workflow-run.yml
##########
@@ -185,13 +185,26 @@ jobs:
     env:
       GITHUB_CONTEXT: ${{ toJson(github) }}
     outputs:
-      pythonVersions: ${{ steps.versions.outputs.python-versions }}
-      allPythonVersions: ${{ steps.versions.outputs.all-python-versions }}
-      defaultPythonVersion: ${{ steps.versions.outputs.default-python-version }}
+      pythonVersions: ${{ steps.selective-checks.python-versions }}
+      allPythonVersions: ${{ steps.selective-checks.outputs.all-python-versions }}
+      defaultPythonVersion: ${{ steps.selective-checks.outputs.default-python-version }}
+      run-tests: ${{ steps.selective-checks.outputs.run-tests }}
+      run-kubernetes-tests: ${{ steps.selective-checks.outputs.run-kubernetes-tests }}
+      basic-checks-only: ${{ steps.selective-checks.outputs.basic-checks-only }}
     if: >
       needs.cancel-workflow-runs.outputs.buildImages == 'true' &&
       (github.repository == 'apache/airflow' || github.event.workflow_run.event != 'schedule')
     steps:
+      # First fetch the sha of merge commit in case it is pull request so that we can
+      # Run selective tests
+      - name: >
+          Fetch merge commit ${{ github.ref }} ( ${{ github.sha }}:
+          merge_commit ${{ needs.cancel-workflow-runs.outputs.mergeCommitSha }} )"

Review comment:
       there is a missing quote here 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org