You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by "hanahmily (via GitHub)" <gi...@apache.org> on 2023/05/24 10:03:05 UTC

[GitHub] [skywalking-banyandb] hanahmily commented on a diff in pull request #274: Add Measure Reader

hanahmily commented on code in PR #274:
URL: https://github.com/apache/skywalking-banyandb/pull/274#discussion_r1203831957


##########
ui/src/components2/Read/index.vue:
##########
@@ -185,14 +201,23 @@ function getTableData() {
     data.tableData = []
     data.loading = true
     setTableParam()
-    let paramList = param
+    let paramList = JSON.parse(JSON.stringify(param))
+    if(data.type == 'measure') {
+        paramList.tagProjection = paramList.projection
+        delete paramList.projection
+    }
     /* paramList.offset = data.queryInfo.pagenum
     paramList.limit = data.queryInfo.pagesize */
     paramList.metadata = data.resourceData.metadata
-    getTableList(paramList)
+    getTableList(paramList, data.type)
         .then((res) => {
             if (res.status == 200) {
-                setTableData(res.data.elements)
+                if(data.type == 'stream') {
+                    setTableData(res.data.elements)
+                } else {
+                    setTableData(res.data.dataPoints)

Review Comment:
   The structure of the measure is different from stream. There is a “fields” field more than “tag_families”. https://github.com/apache/skywalking-banyandb/blob/23139b99ec2b0be194c3bf4bab140a125001fa0a/api/proto/banyandb/measure/v1/query.proto#L42



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org